From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH v1] igb_uio: fix unexpected removal for hot-unplug Date: Mon, 22 Oct 2018 12:13:48 +0100 Message-ID: References: <1534502916-31636-9-git-send-email-jia.guo@intel.com> <1539844035-11524-1-git-send-email-jia.guo@intel.com> <540b6dc6-5c58-2a6d-aeec-55b92408eef0@intel.com> <33442113-1445-21a4-3c1b-6ddd5e7586d4@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org, helin.zhang@intel.com To: Jeff Guo , stephen@networkplumber.org, bruce.richardson@intel.com, konstantin.ananyev@intel.com, thomas@monjalon.net, shaopeng.he@intel.com Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 309214CA9 for ; Mon, 22 Oct 2018 13:13:52 +0200 (CEST) In-Reply-To: <33442113-1445-21a4-3c1b-6ddd5e7586d4@intel.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/19/2018 9:35 AM, Jeff Guo wrote: > > On 10/19/2018 12:06 AM, Ferruh Yigit wrote: >> On 10/18/2018 7:27 AM, Jeff Guo wrote: >>> When a device is hot-unplugged, pci_remove will be invoked unexpectedly >>> before pci_release, it will caused kernel hung issue which will throw the >>> error info of "Trying to free already-free IRQ XXX". And on the other hand, >>> if pci_remove before pci_release, the interrupt will not got chance to be >>> disabled. So this patch aim to fix this issue by adding pci_release call >>> in pci_remove, it will gurranty that all pci clean up will be done before >>> pci removal. >>> >>> Signed-off-by: Jeff Guo Acked-by: Ferruh Yigit