From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751681AbdHELLH (ORCPT ); Sat, 5 Aug 2017 07:11:07 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34834 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751295AbdHELLG (ORCPT ); Sat, 5 Aug 2017 07:11:06 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com C3E5581229 Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=hdegoede@redhat.com Subject: Re: [RESEND PATCH] staging: vboxvideo: remove dead gamma lut code To: Peter Rosin , Daniel Vetter Cc: Greg Kroah-Hartman , devel@driverdev.osuosl.org, Boris Brezillon , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, vbox-dev@virtualbox.org, Michael Thayer References: <20170804103034.2342-1-peda@axentia.se> <20170804104506.2414-1-peda@axentia.se> From: Hans de Goede Message-ID: Date: Sat, 5 Aug 2017 13:11:02 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170804104506.2414-1-peda@axentia.se> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Sat, 05 Aug 2017 11:11:06 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 04-08-17 12:45, Peter Rosin wrote: > The redundant fb helpers .load_lut, .gamma_set and .gamma_get are > no longer used. Remove the dead code that was not doing anything > sensible anyway. > > Signed-off-by: Peter Rosin Thank you, patch looks good to me: Acked-by: Hans de Goede Regards, Hans > --- > drivers/staging/vboxvideo/vbox_fb.c | 15 --------------- > drivers/staging/vboxvideo/vbox_mode.c | 5 ----- > 2 files changed, 20 deletions(-) > > [This time with an improved Cc list, sorry for the noise. For new > people, please refer to https://lkml.org/lkml/2017/7/13/593 for > context] > > Hi Daniel, > > Here it goes, but do you really need me to resend v5 14/14? > > Cheers, > peda > > diff --git a/drivers/staging/vboxvideo/vbox_fb.c b/drivers/staging/vboxvideo/vbox_fb.c > index 35f6d9f8c203..bf6635826159 100644 > --- a/drivers/staging/vboxvideo/vbox_fb.c > +++ b/drivers/staging/vboxvideo/vbox_fb.c > @@ -317,22 +317,7 @@ static int vboxfb_create(struct drm_fb_helper *helper, > return 0; > } > > -static void vbox_fb_gamma_set(struct drm_crtc *crtc, u16 red, u16 green, > - u16 blue, int regno) > -{ > -} > - > -static void vbox_fb_gamma_get(struct drm_crtc *crtc, u16 *red, u16 *green, > - u16 *blue, int regno) > -{ > - *red = regno; > - *green = regno; > - *blue = regno; > -} > - > static struct drm_fb_helper_funcs vbox_fb_helper_funcs = { > - .gamma_set = vbox_fb_gamma_set, > - .gamma_get = vbox_fb_gamma_get, > .fb_probe = vboxfb_create, > }; > > diff --git a/drivers/staging/vboxvideo/vbox_mode.c b/drivers/staging/vboxvideo/vbox_mode.c > index f2b85f3256fa..996da1c79158 100644 > --- a/drivers/staging/vboxvideo/vbox_mode.c > +++ b/drivers/staging/vboxvideo/vbox_mode.c > @@ -134,10 +134,6 @@ static int vbox_set_view(struct drm_crtc *crtc) > return 0; > } > > -static void vbox_crtc_load_lut(struct drm_crtc *crtc) > -{ > -} > - > static void vbox_crtc_dpms(struct drm_crtc *crtc, int mode) > { > struct vbox_crtc *vbox_crtc = to_vbox_crtc(crtc); > @@ -330,7 +326,6 @@ static const struct drm_crtc_helper_funcs vbox_crtc_helper_funcs = { > .mode_set = vbox_crtc_mode_set, > /* .mode_set_base = vbox_crtc_mode_set_base, */ > .disable = vbox_crtc_disable, > - .load_lut = vbox_crtc_load_lut, > .prepare = vbox_crtc_prepare, > .commit = vbox_crtc_commit, > }; > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hans de Goede Subject: Re: [RESEND PATCH] staging: vboxvideo: remove dead gamma lut code Date: Sat, 5 Aug 2017 13:11:02 +0200 Message-ID: References: <20170804103034.2342-1-peda@axentia.se> <20170804104506.2414-1-peda@axentia.se> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by gabe.freedesktop.org (Postfix) with ESMTPS id 80EC16E42F for ; Sat, 5 Aug 2017 11:11:06 +0000 (UTC) In-Reply-To: <20170804104506.2414-1-peda@axentia.se> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Peter Rosin , Daniel Vetter Cc: devel@driverdev.osuosl.org, Boris Brezillon , vbox-dev@virtualbox.org, Greg Kroah-Hartman , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Michael Thayer List-Id: dri-devel@lists.freedesktop.org SGksCgpPbiAwNC0wOC0xNyAxMjo0NSwgUGV0ZXIgUm9zaW4gd3JvdGU6Cj4gVGhlIHJlZHVuZGFu dCBmYiBoZWxwZXJzIC5sb2FkX2x1dCwgLmdhbW1hX3NldCBhbmQgLmdhbW1hX2dldCBhcmUKPiBu byBsb25nZXIgdXNlZC4gUmVtb3ZlIHRoZSBkZWFkIGNvZGUgdGhhdCB3YXMgbm90IGRvaW5nIGFu eXRoaW5nCj4gc2Vuc2libGUgYW55d2F5Lgo+IAo+IFNpZ25lZC1vZmYtYnk6IFBldGVyIFJvc2lu IDxwZWRhQGF4ZW50aWEuc2U+CgpUaGFuayB5b3UsIHBhdGNoIGxvb2tzIGdvb2QgdG8gbWU6CgpB Y2tlZC1ieTogSGFucyBkZSBHb2VkZSA8aGRlZ29lZGVAcmVkaGF0LmNvbT4KClJlZ2FyZHMsCgpI YW5zCgoKCj4gLS0tCj4gICBkcml2ZXJzL3N0YWdpbmcvdmJveHZpZGVvL3Zib3hfZmIuYyAgIHwg MTUgLS0tLS0tLS0tLS0tLS0tCj4gICBkcml2ZXJzL3N0YWdpbmcvdmJveHZpZGVvL3Zib3hfbW9k ZS5jIHwgIDUgLS0tLS0KPiAgIDIgZmlsZXMgY2hhbmdlZCwgMjAgZGVsZXRpb25zKC0pCj4gCj4g W1RoaXMgdGltZSB3aXRoIGFuIGltcHJvdmVkIENjIGxpc3QsIHNvcnJ5IGZvciB0aGUgbm9pc2Uu IEZvciBuZXcKPiAgIHBlb3BsZSwgcGxlYXNlIHJlZmVyIHRvIGh0dHBzOi8vbGttbC5vcmcvbGtt bC8yMDE3LzcvMTMvNTkzIGZvcgo+ICAgY29udGV4dF0KPiAKPiBIaSBEYW5pZWwsCj4gCj4gSGVy ZSBpdCBnb2VzLCBidXQgZG8geW91IHJlYWxseSBuZWVkIG1lIHRvIHJlc2VuZCB2NSAxNC8xND8K PiAKPiBDaGVlcnMsCj4gcGVkYQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3N0YWdpbmcvdmJv eHZpZGVvL3Zib3hfZmIuYyBiL2RyaXZlcnMvc3RhZ2luZy92Ym94dmlkZW8vdmJveF9mYi5jCj4g aW5kZXggMzVmNmQ5ZjhjMjAzLi5iZjY2MzU4MjYxNTkgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9z dGFnaW5nL3Zib3h2aWRlby92Ym94X2ZiLmMKPiArKysgYi9kcml2ZXJzL3N0YWdpbmcvdmJveHZp ZGVvL3Zib3hfZmIuYwo+IEBAIC0zMTcsMjIgKzMxNyw3IEBAIHN0YXRpYyBpbnQgdmJveGZiX2Ny ZWF0ZShzdHJ1Y3QgZHJtX2ZiX2hlbHBlciAqaGVscGVyLAo+ICAgCXJldHVybiAwOwo+ICAgfQo+ ICAgCj4gLXN0YXRpYyB2b2lkIHZib3hfZmJfZ2FtbWFfc2V0KHN0cnVjdCBkcm1fY3J0YyAqY3J0 YywgdTE2IHJlZCwgdTE2IGdyZWVuLAo+IC0JCQkgICAgICB1MTYgYmx1ZSwgaW50IHJlZ25vKQo+ IC17Cj4gLX0KPiAtCj4gLXN0YXRpYyB2b2lkIHZib3hfZmJfZ2FtbWFfZ2V0KHN0cnVjdCBkcm1f Y3J0YyAqY3J0YywgdTE2ICpyZWQsIHUxNiAqZ3JlZW4sCj4gLQkJCSAgICAgIHUxNiAqYmx1ZSwg aW50IHJlZ25vKQo+IC17Cj4gLQkqcmVkID0gcmVnbm87Cj4gLQkqZ3JlZW4gPSByZWdubzsKPiAt CSpibHVlID0gcmVnbm87Cj4gLX0KPiAtCj4gICBzdGF0aWMgc3RydWN0IGRybV9mYl9oZWxwZXJf ZnVuY3MgdmJveF9mYl9oZWxwZXJfZnVuY3MgPSB7Cj4gLQkuZ2FtbWFfc2V0ID0gdmJveF9mYl9n YW1tYV9zZXQsCj4gLQkuZ2FtbWFfZ2V0ID0gdmJveF9mYl9nYW1tYV9nZXQsCj4gICAJLmZiX3By b2JlID0gdmJveGZiX2NyZWF0ZSwKPiAgIH07Cj4gICAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9z dGFnaW5nL3Zib3h2aWRlby92Ym94X21vZGUuYyBiL2RyaXZlcnMvc3RhZ2luZy92Ym94dmlkZW8v dmJveF9tb2RlLmMKPiBpbmRleCBmMmI4NWYzMjU2ZmEuLjk5NmRhMWM3OTE1OCAxMDA2NDQKPiAt LS0gYS9kcml2ZXJzL3N0YWdpbmcvdmJveHZpZGVvL3Zib3hfbW9kZS5jCj4gKysrIGIvZHJpdmVy cy9zdGFnaW5nL3Zib3h2aWRlby92Ym94X21vZGUuYwo+IEBAIC0xMzQsMTAgKzEzNCw2IEBAIHN0 YXRpYyBpbnQgdmJveF9zZXRfdmlldyhzdHJ1Y3QgZHJtX2NydGMgKmNydGMpCj4gICAJcmV0dXJu IDA7Cj4gICB9Cj4gICAKPiAtc3RhdGljIHZvaWQgdmJveF9jcnRjX2xvYWRfbHV0KHN0cnVjdCBk cm1fY3J0YyAqY3J0YykKPiAtewo+IC19Cj4gLQo+ICAgc3RhdGljIHZvaWQgdmJveF9jcnRjX2Rw bXMoc3RydWN0IGRybV9jcnRjICpjcnRjLCBpbnQgbW9kZSkKPiAgIHsKPiAgIAlzdHJ1Y3QgdmJv eF9jcnRjICp2Ym94X2NydGMgPSB0b192Ym94X2NydGMoY3J0Yyk7Cj4gQEAgLTMzMCw3ICszMjYs NiBAQCBzdGF0aWMgY29uc3Qgc3RydWN0IGRybV9jcnRjX2hlbHBlcl9mdW5jcyB2Ym94X2NydGNf aGVscGVyX2Z1bmNzID0gewo+ICAgCS5tb2RlX3NldCA9IHZib3hfY3J0Y19tb2RlX3NldCwKPiAg IAkvKiAubW9kZV9zZXRfYmFzZSA9IHZib3hfY3J0Y19tb2RlX3NldF9iYXNlLCAqLwo+ICAgCS5k aXNhYmxlID0gdmJveF9jcnRjX2Rpc2FibGUsCj4gLQkubG9hZF9sdXQgPSB2Ym94X2NydGNfbG9h ZF9sdXQsCj4gICAJLnByZXBhcmUgPSB2Ym94X2NydGNfcHJlcGFyZSwKPiAgIAkuY29tbWl0ID0g dmJveF9jcnRjX2NvbW1pdCwKPiAgIH07Cj4gCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3Rz LmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2RyaS1kZXZlbAo=