All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnout Vandecappelle <arnout@mind.be>
To: Romain Naour <romain.naour@gmail.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH RFC] package/binutils: build deterministic archives by default
Date: Sun, 3 Oct 2021 12:14:28 +0200	[thread overview]
Message-ID: <be59ca6e-1eee-a48b-809b-4dd815a7ac64@mind.be> (raw)
In-Reply-To: <20210929220027.10505-1-romain.naour@gmail.com>



On 30/09/2021 00:00, Romain Naour wrote:
> The option --enable-deterministic-archives that build deterministic
> archives is supported by binutils since binutils 2.23 [1][2].

  Should we make this dependent on BR2_REPRODUCIBLE? AFAICS it sets the date 
fields in static libraries to zero.

  Is this going to fix a reproducibility issue detected by the autobuilders?

  Regards,
  Arnout

> 
> See "Static libraries" chapter [3].
> https://reproducible-builds.org/docs/archives/
> 
> Enable this option for target and host variant.
> 
> It was added to Yocto Morty (2.2) in 2016 [4].
> 
> [1] https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=commitdiff;h=2e30cb575a1d2b1eb8f776356ed59b0722a943d1
> [2] https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=commitdiff;h=9cb80f72d8b8b2f59562692d9385cd5a533e9b3f
> [3] https://reproducible-builds.org/docs/archives
> [4] https://github.com/openembedded/openembedded-core/commit/df0d525c02780b5a0bd7a177a249c55f41797476
> 
> Signed-off-by: Romain Naour <romain.naour@gmail.com>
> ---
>   package/binutils/binutils.mk | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/package/binutils/binutils.mk b/package/binutils/binutils.mk
> index 8ec76134bc..c5c685ac85 100644
> --- a/package/binutils/binutils.mk
> +++ b/package/binutils/binutils.mk
> @@ -57,6 +57,7 @@ BINUTILS_CONF_OPTS = \
>   	--target=$(GNU_TARGET_NAME) \
>   	--enable-install-libiberty \
>   	--enable-build-warnings=no \
> +	--enable-deterministic-archives \
>   	$(BINUTILS_DISABLE_GDB_CONF_OPTS) \
>   	$(BINUTILS_EXTRA_CONFIG_OPTIONS)
>   
> @@ -93,6 +94,7 @@ HOST_BINUTILS_CONF_OPTS = \
>   	--disable-shared \
>   	--enable-static \
>   	--with-sysroot=$(STAGING_DIR) \
> +	--enable-deterministic-archives \
>   	--enable-poison-system-directories \
>   	--without-debuginfod \
>   	$(BINUTILS_DISABLE_GDB_CONF_OPTS) \
> 
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2021-10-03 10:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-29 22:00 [Buildroot] [PATCH RFC] package/binutils: build deterministic archives by default Romain Naour
2021-10-03 10:14 ` Arnout Vandecappelle [this message]
2021-10-03 13:16   ` Romain Naour
2022-01-13 21:50 ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=be59ca6e-1eee-a48b-809b-4dd815a7ac64@mind.be \
    --to=arnout@mind.be \
    --cc=buildroot@buildroot.org \
    --cc=romain.naour@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.