From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CE45C4332E for ; Tue, 12 Jan 2021 07:10:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 101DA22E03 for ; Tue, 12 Jan 2021 07:10:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391836AbhALHJ5 (ORCPT ); Tue, 12 Jan 2021 02:09:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55166 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391833AbhALHJ4 (ORCPT ); Tue, 12 Jan 2021 02:09:56 -0500 Received: from merlin.infradead.org (merlin.infradead.org [IPv6:2001:8b0:10b:1231::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4677FC061786; Mon, 11 Jan 2021 23:09:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:References:Cc:To:Subject:From:Sender :Reply-To:Content-ID:Content-Description; bh=CYhz2Ww/JXYKS7gTcI5CvohnDk+EDidThWUqwG2Ttlk=; b=pYHgNYbZ4/WygPHbzSXMWCqjHU 1EtyDbg3RO8A5KqFZMlr/KrvQ+1EOg8B5lrKvxHpb8636SaifgqV2MM4z+4brPmz4mvt4RAJdK2dg VDArwdpyAr5ZXxZIe7/6JjSA7/ZDBOXxB8FygyiRE1m5C9ozWu4aYH0BmP4Fh+jv2nIMmMKKa2H0C HtVlrNrFednhCJrtkSqcbWhbt7zEZtqdhn+zigsFDa5x54/eFyQ0/4arJgXO8KKKAgozCcyeEqHt5 uktkarKQ+A14/BzmYM/V4pS20btBhfEuEhllEAWaoLRvII6mx0K/3DnU0de4i7gaYLCp5Tg0KwdSr 1G6rbqdw==; Received: from [2601:1c0:6280:3f0::79df] by merlin.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1kzDnQ-0003IY-1q; Tue, 12 Jan 2021 07:08:52 +0000 From: Randy Dunlap Subject: Re: [RFC PATCH v3 04/16] cxl/mem: Introduce a driver for CXL-2.0-Type-3 endpoints To: Ben Widawsky , linux-cxl@vger.kernel.org Cc: Dan Williams , linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-acpi@vger.kernel.org, Ira Weiny , Vishal Verma , "Kelley, Sean V" , Rafael Wysocki , Bjorn Helgaas , Jonathan Cameron , Jon Masters , Chris Browy , Christoph Hellwig , daniel.lll@alibaba-inc.com References: <20210111225121.820014-1-ben.widawsky@intel.com> <20210111225121.820014-5-ben.widawsky@intel.com> Message-ID: Date: Mon, 11 Jan 2021 23:08:43 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <20210111225121.820014-5-ben.widawsky@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On 1/11/21 2:51 PM, Ben Widawsky wrote: > diff --git a/drivers/cxl/Kconfig b/drivers/cxl/Kconfig > index 68da926ba5b1..0ac5080cd6e0 100644 > --- a/drivers/cxl/Kconfig > +++ b/drivers/cxl/Kconfig > @@ -33,4 +33,26 @@ config CXL_ACPI > specification. > > If unsure say 'm' > + > +config CXL_MEM > + tristate "CXL.mem: Endpoint Support" > + depends on PCI && CXL_BUS_PROVIDER > + default CXL_BUS_PROVIDER > + help > + The CXL.mem protocol allows a device to act as a provider of > + "System RAM" and/or "Persistent Memory" that is fully coherent > + as if the memory was attached to the typical CPU memory > + controller. All of those indented lines should use one tab (tristate, depends, default, and help). The help text should be indented with one tab + 2 spaces, like the lines below are. > + > + Say 'y/m' to enable a driver (named "cxl_mem.ko" when built as > + a module) that will attach to CXL.mem devices for > + configuration, provisioning, and health monitoring. This > + driver is required for dynamic provisioning of CXL.mem > + attached memory which is a pre-requisite for persistent memory patch 2 spells this as: prerequisite which is preferred IMO. > + support. Typically volatile memory is mapped by platform > + firmware and included in the platform memory map, but in some > + cases the OS is responsible for mapping that memory. See > + Chapter 2.3 Type 3 CXL Device in the CXL 2.0 specification. > + > + If unsure say 'm'. That last line needs one tab + 2 spaces for indentation. > endif -- ~Randy