From: Leonid Bloch <lbloch@janustech.com>
To: Alberto Garcia <berto@igalia.com>, qemu-devel@nongnu.org
Cc: qemu-block@nongnu.org, Kevin Wolf <kwolf@redhat.com>,
Max Reitz <mreitz@redhat.com>, Eric Blake <eblake@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v4 4/5] qcow2: Set the default cache-clean-interval to 10 minutes
Date: Thu, 9 Aug 2018 13:52:34 +0300 [thread overview]
Message-ID: <be69de56-51b2-de63-a4ae-c5345a8dcce4@janustech.com> (raw)
In-Reply-To: <w51woszc2b1.fsf@maestria.local.igalia.com>
On 8/9/18 12:33 PM, Alberto Garcia wrote:
> On Thu 09 Aug 2018 12:11:37 AM CEST, Leonid Bloch wrote:
>> The default cache-clean-interval is set to 10 minutes, in order to lower
>> the overhead of the qcow2 caches (before the default was 0, i.e.
>> disabled).
>>
>> Signed-off-by: Leonid Bloch <lbloch@janustech.com>
>
>> --- a/qapi/block-core.json
>> +++ b/qapi/block-core.json
>> @@ -2830,7 +2830,8 @@
>> #
>> # @cache-clean-interval: clean unused entries in the L2 and refcount
>> # caches. The interval is in seconds. The default value
>> -# is 0 and it disables this feature (since 2.5)
>> +# is 600. Setting 0 disables this feature. (since 2.5)
>> +#
>
> It should be "Setting it to 0 ...".
How about:
"... is 600 (0 disables this feature). (since 2.5)"?
... To avoid the extra line. That's why I skipped the "it to" as well.
Alternatively, maybe we can skip the defaults altogether in this file,
just as with all the other qcow2 options there?
Leonid.
>
> With that corrected,
>
> Reviewed-by: Alberto Garcia <berto@igalia.com>
>
> Berto
>
next prev parent reply other threads:[~2018-08-09 10:53 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-08 22:11 [Qemu-devel] [PATCH v4 0/5] qcow2: Take the image size into account when allocating the L2 cache Leonid Bloch
2018-08-08 22:11 ` [Qemu-devel] [PATCH v4 1/5] qcow2: Options' documentation fixes Leonid Bloch
2018-08-09 9:00 ` Alberto Garcia
2018-08-09 9:04 ` Leonid Bloch
2018-08-08 22:11 ` [Qemu-devel] [PATCH v4 2/5] qcow2: Assign the L2 cache relatively to image size Leonid Bloch
2018-08-09 12:14 ` Alberto Garcia
2018-08-09 14:04 ` Leonid Bloch
2018-08-09 15:31 ` Alberto Garcia
2018-08-09 16:46 ` Leonid Bloch
2018-08-09 17:37 ` Eric Blake
2018-08-09 21:51 ` Leonid Bloch
2018-08-08 22:11 ` [Qemu-devel] [PATCH v4 3/5] qcow2: Resize the cache upon image resizing Leonid Bloch
2018-08-09 8:55 ` Alberto Garcia
2018-08-08 22:11 ` [Qemu-devel] [PATCH v4 4/5] qcow2: Set the default cache-clean-interval to 10 minutes Leonid Bloch
2018-08-09 9:33 ` Alberto Garcia
2018-08-09 10:52 ` Leonid Bloch [this message]
2018-08-09 10:58 ` Alberto Garcia
2018-08-08 22:11 ` [Qemu-devel] [PATCH v4 5/5] qcow2: Explicit number replaced by a constant Leonid Bloch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=be69de56-51b2-de63-a4ae-c5345a8dcce4@janustech.com \
--to=lbloch@janustech.com \
--cc=berto@igalia.com \
--cc=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.