From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A69CC07E97 for ; Sat, 3 Jul 2021 05:21:37 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 872DF61402 for ; Sat, 3 Jul 2021 05:21:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 872DF61402 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ilande.co.uk Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:60980 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lzY5v-0004h0-JZ for qemu-devel@archiver.kernel.org; Sat, 03 Jul 2021 01:21:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39368) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lzY5K-0003vu-4h for qemu-devel@nongnu.org; Sat, 03 Jul 2021 01:20:58 -0400 Received: from mail.ilande.co.uk ([2001:41c9:1:41f::167]:40648 helo=mail.default.ilande.bv.iomart.io) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lzY5H-0000dJ-0G for qemu-devel@nongnu.org; Sat, 03 Jul 2021 01:20:57 -0400 Received: from host86-179-59-238.range86-179.btcentralplus.com ([86.179.59.238] helo=[192.168.1.65]) by mail.default.ilande.bv.iomart.io with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lzY4n-0004wM-Fz; Sat, 03 Jul 2021 06:20:29 +0100 To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org References: <20210629053704.2584504-1-f4bug@amsat.org> From: Mark Cave-Ayland Message-ID: Date: Sat, 3 Jul 2021 06:20:40 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 86.179.59.238 X-SA-Exim-Mail-From: mark.cave-ayland@ilande.co.uk Subject: Re: [PATCH] hw/mips/jazz: Map the UART devices unconditionally X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on mail.default.ilande.bv.iomart.io) Received-SPF: pass client-ip=2001:41c9:1:41f::167; envelope-from=mark.cave-ayland@ilande.co.uk; helo=mail.default.ilande.bv.iomart.io X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Aleksandar Rikalo , =?UTF-8?Q?Herv=c3=a9_Poussineau?= , Aurelien Jarno Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 01/07/2021 22:21, Philippe Mathieu-Daudé wrote: > On 6/29/21 7:37 AM, Philippe Mathieu-Daudé wrote: >> When using the Magnum ARC firmware we can see accesses to the >> UART1 beeing rejected, because the device is not mapped: >> >> $ qemu-system-mips64el -M magnum -d guest_errors,unimp -bios NTPROM.RAW >> Invalid access at addr 0x80007004, size 1, region '(null)', reason: rejected >> Invalid access at addr 0x80007001, size 1, region '(null)', reason: rejected >> Invalid access at addr 0x80007002, size 1, region '(null)', reason: rejected >> Invalid access at addr 0x80007003, size 1, region '(null)', reason: rejected >> Invalid access at addr 0x80007004, size 1, region '(null)', reason: rejected >> >> Since both UARTs are present (soldered on the board) regardless there >> are character devices connected, map them unconditionally. >> >> Signed-off-by: Philippe Mathieu-Daudé >> --- >> hw/mips/jazz.c | 16 ++++++---------- >> 1 file changed, 6 insertions(+), 10 deletions(-) > > Patch queued to mips-next (with Peter's corrections applied). Looks good to me. For future reference serial_mm_init() was another candidate on my list of init functions that could be replaced with qdev at some point... ATB, Mark.