From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55722) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gCk7l-0000QS-3m for qemu-devel@nongnu.org; Wed, 17 Oct 2018 07:36:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gCk7h-00067X-ES for qemu-devel@nongnu.org; Wed, 17 Oct 2018 07:36:25 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56190) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gCk7g-00064S-UJ for qemu-devel@nongnu.org; Wed, 17 Oct 2018 07:36:21 -0400 References: <20181008131924.7377-1-d.csapak@proxmox.com> <1f00827b-4c94-e10c-ab57-4ceb5223bee9@proxmox.com> From: Paolo Bonzini Message-ID: Date: Wed, 17 Oct 2018 13:36:15 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] qapi: add info about reset to SHUTDOWN event List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Dominik Csapak , qemu-devel@nongnu.org Cc: armbru@redhat.com, eblake@redhat.com On 17/10/2018 13:34, Dominik Csapak wrote: > i would find it nicer to always be able to distinguish between > a reset and a normal exit, since it would be less work on the > management side (i.e. we would have to handle the qmp reset elsewhere > instead of in the same process that monitors the events) Ok---I am not opposed to this patch at all. I mentioned ShutdownCause only because it was brought up as a possible future extension when 'guest' was added. > also it would make the 'guest' parameter redundant or change the api and > i am not sure about how stable it has to be? The guest parameter would have to stay even if it is redundant. Paolo