From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.9 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A28FC433EF for ; Wed, 15 Sep 2021 14:08:14 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 55906611C1 for ; Wed, 15 Sep 2021 14:08:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 55906611C1 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=vivier.eu Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:57378 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mQVa8-0000qL-J5 for qemu-devel@archiver.kernel.org; Wed, 15 Sep 2021 10:08:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37574) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mQVUW-0003BF-Fo; Wed, 15 Sep 2021 10:02:25 -0400 Received: from mout.kundenserver.de ([212.227.126.135]:55323) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mQVUR-0002VT-7I; Wed, 15 Sep 2021 10:02:24 -0400 Received: from [192.168.100.1] ([82.142.27.6]) by mrelayeu.kundenserver.de (mreue012 [213.165.67.103]) with ESMTPSA (Nemesis) id 1MnFps-1n9QXp3k8K-00jJCL; Wed, 15 Sep 2021 16:02:14 +0200 Subject: Re: [PATCH] Add qemu_vga.ndrv to build/pc-bios folder To: Programmingkid , Mark Cave-Ayland References: <20210831165020.84855-1-programmingkidx@gmail.com> <694bebbe-9920-c110-4331-47cefbdfde51@ilande.co.uk> From: Laurent Vivier Message-ID: Date: Wed, 15 Sep 2021 16:02:10 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: fr Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K1:qvA28RnI0CskUgOBwDjhPUAoMI7FQ9sIG7YQ24vW/wWnMq4dmcp tLFr45ZKt8fj1B86chmBVdZEXYuLpRb8MJTCqXL8D9X9RIS7wAfm3YJK8NJAs4NYtydsaAc Cf16ZMlhSX/rqTBlIx4x/UTSYY0+1Ms9nZDl+ICDkJrK3qjB8GE3wBVun0TjAzhEwwcAfic OnXtl+18z7jfgH/6fi3Nw== X-UI-Out-Filterresults: notjunk:1;V03:K0:RbXwzOWbU7o=:WRWFNzW9bmj4ziYtBTsFWu d8ZppwvL1KOrip3UCzFxXtdIK+dz7tVlPe1sDMD30D/zFwUS45XvC5ifw8Vb8AF306b3ZVg5c PgmKKe5n3MJ/+z593DLuXnzFJuFHjq5x1kMaBR24VI0ztXojRaFq0LCZN66KZkT+ULzfMtTTv 4tLlSz+tHQBEb3yw1tXip8l0+nWYx9SsZBwUko1uD1so277ASVHQi1FXl6ClhEMiZ2zVH0lQ3 MD+sYjLu9sIGpBm+WUscMbGD4vzsyHggY5uAWy/pSVFo0H0d9mtG6fUk66m9DAYe7vGT7tdL5 cY4JwZmEoBlUdmHipNlrckdYmaKGikkeaHcx1aPsb3cOlAFoFt7YmFNzseXomIGveY2p/yvv8 /6BQGCg8bH5hvZMjvP/y1Pjp7pGY7/NTc5O4eZOpUjConR+F8HgE3i+ME7vgczQO3MkBCygYl SEe2u1b1k7gPtb67wNoP8MNgwGFzJzvtdVDWzZcX+4uuJvrC53B8YY1LqHmi563phg7vuYlbW 2ptjAvGt/hBDWS3p9UvzmSHrstJTZIYJyDiMkbYbzxdkUFqdRCsWC1t37/Fxwr4WUiAYbu58g Wn1HFm17t5+U6XRO6V8ZZV9qicv+qUJ/l8JiHTBtrjCbzm7o+Migx0WmBSHSuzbTnIW13pnT2 N6rvgqmiDt84InifKdNnKm0ILF+5Ft2wemu68WMNjUBPypFP8ZsZER410ujWASokTE1ZuhKYd oEu+BgzoPV+39GRqY7hhaWgJLXhgFf5NSSuhrw== Received-SPF: none client-ip=212.227.126.135; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-Spam_score_int: -35 X-Spam_score: -3.6 X-Spam_bar: --- X-Spam_report: (-3.6 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-1.698, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , QEMU Developers , groug@kaod.org, qemu-ppc@nongnu.org, hsp.cat7@gmail.com, david@gibson.dropbear.id.au Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Le 31/08/2021 à 22:52, Programmingkid a écrit : > > >> On Aug 31, 2021, at 4:33 PM, Mark Cave-Ayland wrote: >> >> On 31/08/2021 17:50, John Arbuckle wrote: >> >>> Currently the file qemu_vga.ndrv is not copied into the /build/pc-bios folder. This makes all video resolution choices disappear from a PowerPC Mac OS guest. This patch has the qemu_vga.ndrv file copied into the build/pc-bios folder giving users back their video resolution choices. >>> Signed-off-by: John Arbuckle >>> --- >>> configure | 4 +++- >>> 1 file changed, 3 insertions(+), 1 deletion(-) >>> diff --git a/configure b/configure >>> index 9a79a004d7..281577e46f 100755 >>> --- a/configure >>> +++ b/configure >>> @@ -5056,7 +5056,9 @@ for bios_file in \ >>> $source_path/pc-bios/openbios-* \ >>> $source_path/pc-bios/u-boot.* \ >>> $source_path/pc-bios/edk2-*.fd.bz2 \ >>> - $source_path/pc-bios/palcode-* >>> + $source_path/pc-bios/palcode-* \ >>> + $source_path/pc-bios/qemu_vga.ndrv >>> + >>> do >>> LINKS="$LINKS pc-bios/$(basename $bios_file)" >>> done >> >> I think the patch looks correct, however the commit message and subject aren't quite right. How about something like: >> >> [PATCH] configure: add missing pc-bios/qemu_vga.ndrv symlink in build tree >> >> Ensure that a link to pc-bios/qemu_vga.ndrv is added to the build tree, otherwise the optional MacOS client driver will not be loaded by OpenBIOS when launching QEMU directly from the build directory. >> >> >> ATB, >> >> Mark. > > Ok. I will create a new patch with these changes. > Applied to my trivial-patches branch with Mark's commit message rewording and Peter's R-b. Thanks, Laurent