All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: zhengbin <zhengbin13@huawei.com>,
	tim@cyberelk.net, linux-block@vger.kernel.org
Cc: yi.zhang@huawei.com
Subject: Re: [PATCH v2] paride/pcd: need to set queue to NULL before put_disk
Date: Wed, 4 Sep 2019 07:01:11 -0600	[thread overview]
Message-ID: <be8df565-8208-b97c-0b23-279e483c4717@kernel.dk> (raw)
In-Reply-To: <1565695660-13459-1-git-send-email-zhengbin13@huawei.com>

On 8/13/19 5:27 AM, zhengbin wrote:
> In pcd_init_units, if blk_mq_init_sq_queue fails, need to set queue to
> NULL before put_disk, otherwise null-ptr-deref Read will occur.
> 
> put_disk
>    kobject_put
>      disk_release
>        blk_put_queue(disk->queue)

Applied, thanks.

-- 
Jens Axboe


      parent reply	other threads:[~2019-09-04 13:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-13 11:27 [PATCH v2] paride/pcd: need to set queue to NULL before put_disk zhengbin
2019-09-04  8:40 ` zhengbin (A)
2019-09-04 13:01 ` Jens Axboe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=be8df565-8208-b97c-0b23-279e483c4717@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=linux-block@vger.kernel.org \
    --cc=tim@cyberelk.net \
    --cc=yi.zhang@huawei.com \
    --cc=zhengbin13@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.