From: "Amadeusz Sławiński" <amadeuszx.slawinski@linux.intel.com>
To: wangweidong.a@awinic.com, broonie@kernel.org, perex@perex.cz,
alsa-devel@alsa-project.org, tiwai@suse.com, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, ckeepax@opensource.cirrus.com,
tanureal@opensource.cirrus.com, quic_potturu@quicinc.com,
pierre-louis.bossart@linux.intel.com, cy_huang@richtek.com
Cc: zhangjianming@awinic.com, duanyibo@awinic.com,
yijiangtao@awinic.com, zhaolei@awinic.com, liweilei@awinic.com
Subject: Re: [PATCH V6 4/5] ASoC: codecs: Configure aw883xx chip register as well as Kconfig and Makefile
Date: Thu, 8 Dec 2022 15:32:16 +0100 [thread overview]
Message-ID: <be91b5a8-7671-41d3-df9d-ff0aeaca6e9a@linux.intel.com> (raw)
In-Reply-To: <20221208122313.55118-5-wangweidong.a@awinic.com>
On 12/8/2022 1:23 PM, wangweidong.a@awinic.com wrote:
(...)
> diff --git a/sound/soc/codecs/aw883xx/aw883xx_init.c b/sound/soc/codecs/aw883xx/aw883xx_init.c
> new file mode 100644
> index 000000000000..2ef62fdebb57
> --- /dev/null
> +++ b/sound/soc/codecs/aw883xx/aw883xx_init.c
> @@ -0,0 +1,615 @@
> +// SPDX-License-Identifier: GPL-2.0-only
> +/*
> + * aw883xx.c -- ALSA Soc AW883XX codec support
> + *
> + * Copyright (c) 2022 AWINIC Technology CO., LTD
> + *
> + * Author: Bruce zhao <zhaolei@awinic.com>
> + */
> +
> +#include <linux/delay.h>
> +#include <linux/device.h>
> +#include <linux/firmware.h>
> +#include <linux/i2c.h>
> +#include <linux/module.h>
> +#include <linux/of_gpio.h>
> +#include <linux/regmap.h>
> +#include <linux/syscalls.h>
> +#include <linux/uaccess.h>
> +#include <linux/version.h>
> +#include <linux/workqueue.h>
Again headers, picking at random: firmware.h, of_gpio, uaccess.h,
version.h, from quick check seem unnecessary and likely some others can
also be removed.
> +#include <sound/control.h>
> +#include <sound/core.h>
> +#include <sound/pcm.h>
> +#include <sound/pcm_params.h>
> +#include <sound/soc.h>
> +#include "aw883xx.h"
> +#include "aw883xx_bin_parse.h"
> +#include "aw883xx_pid_2049_reg.h"
> +
(...)
next prev parent reply other threads:[~2022-12-08 14:33 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-08 12:23 [PATCH V6 0/5] ASoC: codecs: Add Awinic AW883XX audio amplifier driver wangweidong.a
2022-12-08 12:23 ` [PATCH V6 1/5] ASoC: codecs: Add i2c and codec registration for aw883xx and their associated operation functions wangweidong.a
2022-12-08 13:11 ` Amadeusz Sławiński
2022-12-13 2:02 ` wangweidong.a
2022-12-08 12:23 ` [PATCH V6 2/5] ASoC: codecs: Implementation of aw883xx configuration file parsing function wangweidong.a
2022-12-08 13:48 ` Amadeusz Sławiński
2022-12-13 7:10 ` wangweidong.a
2022-12-08 12:23 ` [PATCH V6 3/5] ASoC: codecs: aw883xx chip control logic, such as power on and off wangweidong.a
2022-12-08 14:22 ` Amadeusz Sławiński
2022-12-08 12:23 ` [PATCH V6 4/5] ASoC: codecs: Configure aw883xx chip register as well as Kconfig and Makefile wangweidong.a
2022-12-08 14:32 ` Amadeusz Sławiński [this message]
2022-12-08 14:35 ` kernel test robot
2022-12-08 12:23 ` [PATCH V6 5/5] ASoC: dt-bindings: Add schema for "awinic,aw883xx" wangweidong.a
2022-12-08 15:57 ` [PATCH V6 5/5] ASoC: dt-bindings: Add schema for "awinic, aw883xx" Rob Herring
2022-12-13 7:26 ` wangweidong.a
2022-12-14 11:52 ` Krzysztof Kozlowski
2022-12-20 11:25 ` wangweidong.a
2022-12-20 11:39 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=be91b5a8-7671-41d3-df9d-ff0aeaca6e9a@linux.intel.com \
--to=amadeuszx.slawinski@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=cy_huang@richtek.com \
--cc=duanyibo@awinic.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=liweilei@awinic.com \
--cc=perex@perex.cz \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=quic_potturu@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=tanureal@opensource.cirrus.com \
--cc=tiwai@suse.com \
--cc=wangweidong.a@awinic.com \
--cc=yijiangtao@awinic.com \
--cc=zhangjianming@awinic.com \
--cc=zhaolei@awinic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.