All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rex-BC Chen <rex-bc.chen@mediatek.com>
To: CK Hu <ck.hu@mediatek.com>,
	Guillaume Ranquet <granquet@baylibre.com>,
	Chun-Kuang Hu <chunkuang.hu@kernel.org>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Chunfeng Yun <chunfeng.yun@mediatek.com>,
	"Kishon Vijay Abraham I" <kishon@ti.com>,
	Vinod Koul <vkoul@kernel.org>, "Helge Deller" <deller@gmx.de>,
	Jitao shi <jitao.shi@mediatek.com>
Cc: AngeloGioacchino Del Regno 
	<angelogioacchino.delregno@collabora.com>,
	<dri-devel@lists.freedesktop.org>,
	<linux-mediatek@lists.infradead.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-phy@lists.infradead.org>, <linux-fbdev@vger.kernel.org>
Subject: Re: [PATCH v10 11/21] drm/mediatek: dpi: move swap_shift to SoC config
Date: Thu, 2 Jun 2022 19:38:57 +0800	[thread overview]
Message-ID: <be98423304bd51959dd9334215114bd179ec1e6b.camel@mediatek.com> (raw)
In-Reply-To: <76ddd49bb2bb46923900b085056ce22d7bfa0b0a.camel@mediatek.com>

On Mon, 2022-05-30 at 16:38 +0800, CK Hu wrote:
> Hi, Guillaume:
> 
> On Mon, 2022-05-23 at 12:47 +0200, Guillaume Ranquet wrote:
> > Add flexibility by moving the swap shift value to SoC specific
> > config
> > 
> > Signed-off-by: Guillaume Ranquet <granquet@baylibre.com>
> > Reviewed-by: Rex-BC Chen <rex-bc.chen@mediatek.com>
> > Reviewed-by: AngeloGioacchino Del Regno <
> > angelogioacchino.delregno@collabora.com>
> > ---
> >  drivers/gpu/drm/mediatek/mtk_dpi.c | 8 +++++++-
> >  1 file changed, 7 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c
> > b/drivers/gpu/drm/mediatek/mtk_dpi.c
> > index 6eeda222a973..6d4d8c6ec47d 100644
> > --- a/drivers/gpu/drm/mediatek/mtk_dpi.c
> > +++ b/drivers/gpu/drm/mediatek/mtk_dpi.c
> > @@ -131,6 +131,7 @@ struct mtk_dpi_conf {
> >  	u32 dimension_mask;
> >  	/* HSIZE and VSIZE mask (no shift) */
> >  	u32 hvsize_mask;
> > +	u32 channel_swap_shift;
> >  	const struct mtk_dpi_yc_limit *limit;
> >  };
> >  
> > @@ -349,7 +350,8 @@ static void mtk_dpi_config_channel_swap(struct
> > mtk_dpi *dpi,
> >  		break;
> >  	}
> >  
> > -	mtk_dpi_mask(dpi, DPI_OUTPUT_SETTING, val << CH_SWAP,
> > CH_SWAP_MASK);
> > +	mtk_dpi_mask(dpi, DPI_OUTPUT_SETTING, val << dpi->conf-
> > > channel_swap_shift,
> > 
> > +		     CH_SWAP_MASK);
> > From the definiton:
> 
>  #define CH_SWAP				0
> +#define DPINTF_CH_SWAP			BIT(1)
>  #define CH_SWAP_MASK			(0x7 << 0)
> +#define DPINTF_CH_SWAP_MASK		(0x7 << 1)
> 
> This statement should be:
> 
> mtk_dpi_mask(dpi, DPI_OUTPUT_SETTING, val << dpi->conf-
> > channel_swap_shift, CH_SWAP_MASK << dpi->conf->channel_swap_shift);
> 
> dpi->conf->channel_swap_shift is 1 for MT8195-DP_INTF and 0 for
> others.
> And drop the definition of DPINTF_CH_SWAP and DPINTF_CH_SWAP_MASK,
> 
> Regards,
> CK
> 

Hello CK,

I think we should keep DPINTF_CH_SWAP?
BIT(1) = 2 so the shift should be:
dpi->conf->channel_swap_shift is 2 for MT8195-DP_INTF and 0 for
others.

BRs,
Bo-Chen
> 
> >  }
> >  
> >  static void mtk_dpi_config_yuv422_enable(struct mtk_dpi *dpi, bool
> > enable)
> > @@ -821,6 +823,7 @@ static const struct mtk_dpi_conf mt8173_conf =
> > {
> >  	.swap_input_support = true,
> >  	.dimension_mask = HPW_MASK,
> >  	.hvsize_mask = HSIZE_MASK,
> > +	.channel_swap_shift = CH_SWAP,
> >  	.limit = &mtk_dpi_limit,
> >  };
> >  
> > @@ -835,6 +838,7 @@ static const struct mtk_dpi_conf mt2701_conf =
> > {
> >  	.swap_input_support = true,
> >  	.dimension_mask = HPW_MASK,
> >  	.hvsize_mask = HSIZE_MASK,
> > +	.channel_swap_shift = CH_SWAP,
> >  	.limit = &mtk_dpi_limit,
> >  };
> >  
> > @@ -848,6 +852,7 @@ static const struct mtk_dpi_conf mt8183_conf =
> > {
> >  	.swap_input_support = true,
> >  	.dimension_mask = HPW_MASK,
> >  	.hvsize_mask = HSIZE_MASK,
> > +	.channel_swap_shift = CH_SWAP,
> >  	.limit = &mtk_dpi_limit,
> >  };
> >  
> > @@ -861,6 +866,7 @@ static const struct mtk_dpi_conf mt8192_conf =
> > {
> >  	.swap_input_support = true,
> >  	.dimension_mask = HPW_MASK,
> >  	.hvsize_mask = HSIZE_MASK,
> > +	.channel_swap_shift = CH_SWAP,
> >  	.limit = &mtk_dpi_limit,
> >  };
> >  
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel


WARNING: multiple messages have this Message-ID (diff)
From: Rex-BC Chen <rex-bc.chen@mediatek.com>
To: CK Hu <ck.hu@mediatek.com>,
	Guillaume Ranquet <granquet@baylibre.com>,
	Chun-Kuang Hu <chunkuang.hu@kernel.org>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Chunfeng Yun <chunfeng.yun@mediatek.com>,
	"Kishon Vijay Abraham I" <kishon@ti.com>,
	Vinod Koul <vkoul@kernel.org>, "Helge Deller" <deller@gmx.de>,
	Jitao shi <jitao.shi@mediatek.com>
Cc: devicetree@vger.kernel.org, linux-fbdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	linux-mediatek@lists.infradead.org,
	linux-phy@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	AngeloGioacchino Del Regno
	<angelogioacchino.delregno@collabora.com>
Subject: Re: [PATCH v10 11/21] drm/mediatek: dpi: move swap_shift to SoC config
Date: Thu, 2 Jun 2022 19:38:57 +0800	[thread overview]
Message-ID: <be98423304bd51959dd9334215114bd179ec1e6b.camel@mediatek.com> (raw)
In-Reply-To: <76ddd49bb2bb46923900b085056ce22d7bfa0b0a.camel@mediatek.com>

On Mon, 2022-05-30 at 16:38 +0800, CK Hu wrote:
> Hi, Guillaume:
> 
> On Mon, 2022-05-23 at 12:47 +0200, Guillaume Ranquet wrote:
> > Add flexibility by moving the swap shift value to SoC specific
> > config
> > 
> > Signed-off-by: Guillaume Ranquet <granquet@baylibre.com>
> > Reviewed-by: Rex-BC Chen <rex-bc.chen@mediatek.com>
> > Reviewed-by: AngeloGioacchino Del Regno <
> > angelogioacchino.delregno@collabora.com>
> > ---
> >  drivers/gpu/drm/mediatek/mtk_dpi.c | 8 +++++++-
> >  1 file changed, 7 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c
> > b/drivers/gpu/drm/mediatek/mtk_dpi.c
> > index 6eeda222a973..6d4d8c6ec47d 100644
> > --- a/drivers/gpu/drm/mediatek/mtk_dpi.c
> > +++ b/drivers/gpu/drm/mediatek/mtk_dpi.c
> > @@ -131,6 +131,7 @@ struct mtk_dpi_conf {
> >  	u32 dimension_mask;
> >  	/* HSIZE and VSIZE mask (no shift) */
> >  	u32 hvsize_mask;
> > +	u32 channel_swap_shift;
> >  	const struct mtk_dpi_yc_limit *limit;
> >  };
> >  
> > @@ -349,7 +350,8 @@ static void mtk_dpi_config_channel_swap(struct
> > mtk_dpi *dpi,
> >  		break;
> >  	}
> >  
> > -	mtk_dpi_mask(dpi, DPI_OUTPUT_SETTING, val << CH_SWAP,
> > CH_SWAP_MASK);
> > +	mtk_dpi_mask(dpi, DPI_OUTPUT_SETTING, val << dpi->conf-
> > > channel_swap_shift,
> > 
> > +		     CH_SWAP_MASK);
> > From the definiton:
> 
>  #define CH_SWAP				0
> +#define DPINTF_CH_SWAP			BIT(1)
>  #define CH_SWAP_MASK			(0x7 << 0)
> +#define DPINTF_CH_SWAP_MASK		(0x7 << 1)
> 
> This statement should be:
> 
> mtk_dpi_mask(dpi, DPI_OUTPUT_SETTING, val << dpi->conf-
> > channel_swap_shift, CH_SWAP_MASK << dpi->conf->channel_swap_shift);
> 
> dpi->conf->channel_swap_shift is 1 for MT8195-DP_INTF and 0 for
> others.
> And drop the definition of DPINTF_CH_SWAP and DPINTF_CH_SWAP_MASK,
> 
> Regards,
> CK
> 

Hello CK,

I think we should keep DPINTF_CH_SWAP?
BIT(1) = 2 so the shift should be:
dpi->conf->channel_swap_shift is 2 for MT8195-DP_INTF and 0 for
others.

BRs,
Bo-Chen
> 
> >  }
> >  
> >  static void mtk_dpi_config_yuv422_enable(struct mtk_dpi *dpi, bool
> > enable)
> > @@ -821,6 +823,7 @@ static const struct mtk_dpi_conf mt8173_conf =
> > {
> >  	.swap_input_support = true,
> >  	.dimension_mask = HPW_MASK,
> >  	.hvsize_mask = HSIZE_MASK,
> > +	.channel_swap_shift = CH_SWAP,
> >  	.limit = &mtk_dpi_limit,
> >  };
> >  
> > @@ -835,6 +838,7 @@ static const struct mtk_dpi_conf mt2701_conf =
> > {
> >  	.swap_input_support = true,
> >  	.dimension_mask = HPW_MASK,
> >  	.hvsize_mask = HSIZE_MASK,
> > +	.channel_swap_shift = CH_SWAP,
> >  	.limit = &mtk_dpi_limit,
> >  };
> >  
> > @@ -848,6 +852,7 @@ static const struct mtk_dpi_conf mt8183_conf =
> > {
> >  	.swap_input_support = true,
> >  	.dimension_mask = HPW_MASK,
> >  	.hvsize_mask = HSIZE_MASK,
> > +	.channel_swap_shift = CH_SWAP,
> >  	.limit = &mtk_dpi_limit,
> >  };
> >  
> > @@ -861,6 +866,7 @@ static const struct mtk_dpi_conf mt8192_conf =
> > {
> >  	.swap_input_support = true,
> >  	.dimension_mask = HPW_MASK,
> >  	.hvsize_mask = HSIZE_MASK,
> > +	.channel_swap_shift = CH_SWAP,
> >  	.limit = &mtk_dpi_limit,
> >  };
> >  
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel


WARNING: multiple messages have this Message-ID (diff)
From: Rex-BC Chen <rex-bc.chen@mediatek.com>
To: CK Hu <ck.hu@mediatek.com>,
	Guillaume Ranquet <granquet@baylibre.com>,
	Chun-Kuang Hu <chunkuang.hu@kernel.org>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Chunfeng Yun <chunfeng.yun@mediatek.com>,
	"Kishon Vijay Abraham I" <kishon@ti.com>,
	Vinod Koul <vkoul@kernel.org>, "Helge Deller" <deller@gmx.de>,
	Jitao shi <jitao.shi@mediatek.com>
Cc: AngeloGioacchino Del Regno
	<angelogioacchino.delregno@collabora.com>,
	<dri-devel@lists.freedesktop.org>,
	<linux-mediatek@lists.infradead.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-phy@lists.infradead.org>, <linux-fbdev@vger.kernel.org>
Subject: Re: [PATCH v10 11/21] drm/mediatek: dpi: move swap_shift to SoC config
Date: Thu, 2 Jun 2022 19:38:57 +0800	[thread overview]
Message-ID: <be98423304bd51959dd9334215114bd179ec1e6b.camel@mediatek.com> (raw)
In-Reply-To: <76ddd49bb2bb46923900b085056ce22d7bfa0b0a.camel@mediatek.com>

On Mon, 2022-05-30 at 16:38 +0800, CK Hu wrote:
> Hi, Guillaume:
> 
> On Mon, 2022-05-23 at 12:47 +0200, Guillaume Ranquet wrote:
> > Add flexibility by moving the swap shift value to SoC specific
> > config
> > 
> > Signed-off-by: Guillaume Ranquet <granquet@baylibre.com>
> > Reviewed-by: Rex-BC Chen <rex-bc.chen@mediatek.com>
> > Reviewed-by: AngeloGioacchino Del Regno <
> > angelogioacchino.delregno@collabora.com>
> > ---
> >  drivers/gpu/drm/mediatek/mtk_dpi.c | 8 +++++++-
> >  1 file changed, 7 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c
> > b/drivers/gpu/drm/mediatek/mtk_dpi.c
> > index 6eeda222a973..6d4d8c6ec47d 100644
> > --- a/drivers/gpu/drm/mediatek/mtk_dpi.c
> > +++ b/drivers/gpu/drm/mediatek/mtk_dpi.c
> > @@ -131,6 +131,7 @@ struct mtk_dpi_conf {
> >  	u32 dimension_mask;
> >  	/* HSIZE and VSIZE mask (no shift) */
> >  	u32 hvsize_mask;
> > +	u32 channel_swap_shift;
> >  	const struct mtk_dpi_yc_limit *limit;
> >  };
> >  
> > @@ -349,7 +350,8 @@ static void mtk_dpi_config_channel_swap(struct
> > mtk_dpi *dpi,
> >  		break;
> >  	}
> >  
> > -	mtk_dpi_mask(dpi, DPI_OUTPUT_SETTING, val << CH_SWAP,
> > CH_SWAP_MASK);
> > +	mtk_dpi_mask(dpi, DPI_OUTPUT_SETTING, val << dpi->conf-
> > > channel_swap_shift,
> > 
> > +		     CH_SWAP_MASK);
> > From the definiton:
> 
>  #define CH_SWAP				0
> +#define DPINTF_CH_SWAP			BIT(1)
>  #define CH_SWAP_MASK			(0x7 << 0)
> +#define DPINTF_CH_SWAP_MASK		(0x7 << 1)
> 
> This statement should be:
> 
> mtk_dpi_mask(dpi, DPI_OUTPUT_SETTING, val << dpi->conf-
> > channel_swap_shift, CH_SWAP_MASK << dpi->conf->channel_swap_shift);
> 
> dpi->conf->channel_swap_shift is 1 for MT8195-DP_INTF and 0 for
> others.
> And drop the definition of DPINTF_CH_SWAP and DPINTF_CH_SWAP_MASK,
> 
> Regards,
> CK
> 

Hello CK,

I think we should keep DPINTF_CH_SWAP?
BIT(1) = 2 so the shift should be:
dpi->conf->channel_swap_shift is 2 for MT8195-DP_INTF and 0 for
others.

BRs,
Bo-Chen
> 
> >  }
> >  
> >  static void mtk_dpi_config_yuv422_enable(struct mtk_dpi *dpi, bool
> > enable)
> > @@ -821,6 +823,7 @@ static const struct mtk_dpi_conf mt8173_conf =
> > {
> >  	.swap_input_support = true,
> >  	.dimension_mask = HPW_MASK,
> >  	.hvsize_mask = HSIZE_MASK,
> > +	.channel_swap_shift = CH_SWAP,
> >  	.limit = &mtk_dpi_limit,
> >  };
> >  
> > @@ -835,6 +838,7 @@ static const struct mtk_dpi_conf mt2701_conf =
> > {
> >  	.swap_input_support = true,
> >  	.dimension_mask = HPW_MASK,
> >  	.hvsize_mask = HSIZE_MASK,
> > +	.channel_swap_shift = CH_SWAP,
> >  	.limit = &mtk_dpi_limit,
> >  };
> >  
> > @@ -848,6 +852,7 @@ static const struct mtk_dpi_conf mt8183_conf =
> > {
> >  	.swap_input_support = true,
> >  	.dimension_mask = HPW_MASK,
> >  	.hvsize_mask = HSIZE_MASK,
> > +	.channel_swap_shift = CH_SWAP,
> >  	.limit = &mtk_dpi_limit,
> >  };
> >  
> > @@ -861,6 +866,7 @@ static const struct mtk_dpi_conf mt8192_conf =
> > {
> >  	.swap_input_support = true,
> >  	.dimension_mask = HPW_MASK,
> >  	.hvsize_mask = HSIZE_MASK,
> > +	.channel_swap_shift = CH_SWAP,
> >  	.limit = &mtk_dpi_limit,
> >  };
> >  
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel


_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

WARNING: multiple messages have this Message-ID (diff)
From: Rex-BC Chen <rex-bc.chen@mediatek.com>
To: CK Hu <ck.hu@mediatek.com>,
	Guillaume Ranquet <granquet@baylibre.com>,
	Chun-Kuang Hu <chunkuang.hu@kernel.org>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Chunfeng Yun <chunfeng.yun@mediatek.com>,
	"Kishon Vijay Abraham I" <kishon@ti.com>,
	Vinod Koul <vkoul@kernel.org>, "Helge Deller" <deller@gmx.de>,
	Jitao shi <jitao.shi@mediatek.com>
Cc: AngeloGioacchino Del Regno
	<angelogioacchino.delregno@collabora.com>,
	<dri-devel@lists.freedesktop.org>,
	<linux-mediatek@lists.infradead.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-phy@lists.infradead.org>, <linux-fbdev@vger.kernel.org>
Subject: Re: [PATCH v10 11/21] drm/mediatek: dpi: move swap_shift to SoC config
Date: Thu, 2 Jun 2022 19:38:57 +0800	[thread overview]
Message-ID: <be98423304bd51959dd9334215114bd179ec1e6b.camel@mediatek.com> (raw)
In-Reply-To: <76ddd49bb2bb46923900b085056ce22d7bfa0b0a.camel@mediatek.com>

On Mon, 2022-05-30 at 16:38 +0800, CK Hu wrote:
> Hi, Guillaume:
> 
> On Mon, 2022-05-23 at 12:47 +0200, Guillaume Ranquet wrote:
> > Add flexibility by moving the swap shift value to SoC specific
> > config
> > 
> > Signed-off-by: Guillaume Ranquet <granquet@baylibre.com>
> > Reviewed-by: Rex-BC Chen <rex-bc.chen@mediatek.com>
> > Reviewed-by: AngeloGioacchino Del Regno <
> > angelogioacchino.delregno@collabora.com>
> > ---
> >  drivers/gpu/drm/mediatek/mtk_dpi.c | 8 +++++++-
> >  1 file changed, 7 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c
> > b/drivers/gpu/drm/mediatek/mtk_dpi.c
> > index 6eeda222a973..6d4d8c6ec47d 100644
> > --- a/drivers/gpu/drm/mediatek/mtk_dpi.c
> > +++ b/drivers/gpu/drm/mediatek/mtk_dpi.c
> > @@ -131,6 +131,7 @@ struct mtk_dpi_conf {
> >  	u32 dimension_mask;
> >  	/* HSIZE and VSIZE mask (no shift) */
> >  	u32 hvsize_mask;
> > +	u32 channel_swap_shift;
> >  	const struct mtk_dpi_yc_limit *limit;
> >  };
> >  
> > @@ -349,7 +350,8 @@ static void mtk_dpi_config_channel_swap(struct
> > mtk_dpi *dpi,
> >  		break;
> >  	}
> >  
> > -	mtk_dpi_mask(dpi, DPI_OUTPUT_SETTING, val << CH_SWAP,
> > CH_SWAP_MASK);
> > +	mtk_dpi_mask(dpi, DPI_OUTPUT_SETTING, val << dpi->conf-
> > > channel_swap_shift,
> > 
> > +		     CH_SWAP_MASK);
> > From the definiton:
> 
>  #define CH_SWAP				0
> +#define DPINTF_CH_SWAP			BIT(1)
>  #define CH_SWAP_MASK			(0x7 << 0)
> +#define DPINTF_CH_SWAP_MASK		(0x7 << 1)
> 
> This statement should be:
> 
> mtk_dpi_mask(dpi, DPI_OUTPUT_SETTING, val << dpi->conf-
> > channel_swap_shift, CH_SWAP_MASK << dpi->conf->channel_swap_shift);
> 
> dpi->conf->channel_swap_shift is 1 for MT8195-DP_INTF and 0 for
> others.
> And drop the definition of DPINTF_CH_SWAP and DPINTF_CH_SWAP_MASK,
> 
> Regards,
> CK
> 

Hello CK,

I think we should keep DPINTF_CH_SWAP?
BIT(1) = 2 so the shift should be:
dpi->conf->channel_swap_shift is 2 for MT8195-DP_INTF and 0 for
others.

BRs,
Bo-Chen
> 
> >  }
> >  
> >  static void mtk_dpi_config_yuv422_enable(struct mtk_dpi *dpi, bool
> > enable)
> > @@ -821,6 +823,7 @@ static const struct mtk_dpi_conf mt8173_conf =
> > {
> >  	.swap_input_support = true,
> >  	.dimension_mask = HPW_MASK,
> >  	.hvsize_mask = HSIZE_MASK,
> > +	.channel_swap_shift = CH_SWAP,
> >  	.limit = &mtk_dpi_limit,
> >  };
> >  
> > @@ -835,6 +838,7 @@ static const struct mtk_dpi_conf mt2701_conf =
> > {
> >  	.swap_input_support = true,
> >  	.dimension_mask = HPW_MASK,
> >  	.hvsize_mask = HSIZE_MASK,
> > +	.channel_swap_shift = CH_SWAP,
> >  	.limit = &mtk_dpi_limit,
> >  };
> >  
> > @@ -848,6 +852,7 @@ static const struct mtk_dpi_conf mt8183_conf =
> > {
> >  	.swap_input_support = true,
> >  	.dimension_mask = HPW_MASK,
> >  	.hvsize_mask = HSIZE_MASK,
> > +	.channel_swap_shift = CH_SWAP,
> >  	.limit = &mtk_dpi_limit,
> >  };
> >  
> > @@ -861,6 +866,7 @@ static const struct mtk_dpi_conf mt8192_conf =
> > {
> >  	.swap_input_support = true,
> >  	.dimension_mask = HPW_MASK,
> >  	.hvsize_mask = HSIZE_MASK,
> > +	.channel_swap_shift = CH_SWAP,
> >  	.limit = &mtk_dpi_limit,
> >  };
> >  
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel


-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

WARNING: multiple messages have this Message-ID (diff)
From: Rex-BC Chen <rex-bc.chen@mediatek.com>
To: CK Hu <ck.hu@mediatek.com>,
	Guillaume Ranquet <granquet@baylibre.com>,
	Chun-Kuang Hu <chunkuang.hu@kernel.org>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Chunfeng Yun <chunfeng.yun@mediatek.com>,
	"Kishon Vijay Abraham I" <kishon@ti.com>,
	Vinod Koul <vkoul@kernel.org>, "Helge Deller" <deller@gmx.de>,
	Jitao shi <jitao.shi@mediatek.com>
Cc: AngeloGioacchino Del Regno
	<angelogioacchino.delregno@collabora.com>,
	<dri-devel@lists.freedesktop.org>,
	<linux-mediatek@lists.infradead.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-phy@lists.infradead.org>, <linux-fbdev@vger.kernel.org>
Subject: Re: [PATCH v10 11/21] drm/mediatek: dpi: move swap_shift to SoC config
Date: Thu, 2 Jun 2022 19:38:57 +0800	[thread overview]
Message-ID: <be98423304bd51959dd9334215114bd179ec1e6b.camel@mediatek.com> (raw)
In-Reply-To: <76ddd49bb2bb46923900b085056ce22d7bfa0b0a.camel@mediatek.com>

On Mon, 2022-05-30 at 16:38 +0800, CK Hu wrote:
> Hi, Guillaume:
> 
> On Mon, 2022-05-23 at 12:47 +0200, Guillaume Ranquet wrote:
> > Add flexibility by moving the swap shift value to SoC specific
> > config
> > 
> > Signed-off-by: Guillaume Ranquet <granquet@baylibre.com>
> > Reviewed-by: Rex-BC Chen <rex-bc.chen@mediatek.com>
> > Reviewed-by: AngeloGioacchino Del Regno <
> > angelogioacchino.delregno@collabora.com>
> > ---
> >  drivers/gpu/drm/mediatek/mtk_dpi.c | 8 +++++++-
> >  1 file changed, 7 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c
> > b/drivers/gpu/drm/mediatek/mtk_dpi.c
> > index 6eeda222a973..6d4d8c6ec47d 100644
> > --- a/drivers/gpu/drm/mediatek/mtk_dpi.c
> > +++ b/drivers/gpu/drm/mediatek/mtk_dpi.c
> > @@ -131,6 +131,7 @@ struct mtk_dpi_conf {
> >  	u32 dimension_mask;
> >  	/* HSIZE and VSIZE mask (no shift) */
> >  	u32 hvsize_mask;
> > +	u32 channel_swap_shift;
> >  	const struct mtk_dpi_yc_limit *limit;
> >  };
> >  
> > @@ -349,7 +350,8 @@ static void mtk_dpi_config_channel_swap(struct
> > mtk_dpi *dpi,
> >  		break;
> >  	}
> >  
> > -	mtk_dpi_mask(dpi, DPI_OUTPUT_SETTING, val << CH_SWAP,
> > CH_SWAP_MASK);
> > +	mtk_dpi_mask(dpi, DPI_OUTPUT_SETTING, val << dpi->conf-
> > > channel_swap_shift,
> > 
> > +		     CH_SWAP_MASK);
> > From the definiton:
> 
>  #define CH_SWAP				0
> +#define DPINTF_CH_SWAP			BIT(1)
>  #define CH_SWAP_MASK			(0x7 << 0)
> +#define DPINTF_CH_SWAP_MASK		(0x7 << 1)
> 
> This statement should be:
> 
> mtk_dpi_mask(dpi, DPI_OUTPUT_SETTING, val << dpi->conf-
> > channel_swap_shift, CH_SWAP_MASK << dpi->conf->channel_swap_shift);
> 
> dpi->conf->channel_swap_shift is 1 for MT8195-DP_INTF and 0 for
> others.
> And drop the definition of DPINTF_CH_SWAP and DPINTF_CH_SWAP_MASK,
> 
> Regards,
> CK
> 

Hello CK,

I think we should keep DPINTF_CH_SWAP?
BIT(1) = 2 so the shift should be:
dpi->conf->channel_swap_shift is 2 for MT8195-DP_INTF and 0 for
others.

BRs,
Bo-Chen
> 
> >  }
> >  
> >  static void mtk_dpi_config_yuv422_enable(struct mtk_dpi *dpi, bool
> > enable)
> > @@ -821,6 +823,7 @@ static const struct mtk_dpi_conf mt8173_conf =
> > {
> >  	.swap_input_support = true,
> >  	.dimension_mask = HPW_MASK,
> >  	.hvsize_mask = HSIZE_MASK,
> > +	.channel_swap_shift = CH_SWAP,
> >  	.limit = &mtk_dpi_limit,
> >  };
> >  
> > @@ -835,6 +838,7 @@ static const struct mtk_dpi_conf mt2701_conf =
> > {
> >  	.swap_input_support = true,
> >  	.dimension_mask = HPW_MASK,
> >  	.hvsize_mask = HSIZE_MASK,
> > +	.channel_swap_shift = CH_SWAP,
> >  	.limit = &mtk_dpi_limit,
> >  };
> >  
> > @@ -848,6 +852,7 @@ static const struct mtk_dpi_conf mt8183_conf =
> > {
> >  	.swap_input_support = true,
> >  	.dimension_mask = HPW_MASK,
> >  	.hvsize_mask = HSIZE_MASK,
> > +	.channel_swap_shift = CH_SWAP,
> >  	.limit = &mtk_dpi_limit,
> >  };
> >  
> > @@ -861,6 +866,7 @@ static const struct mtk_dpi_conf mt8192_conf =
> > {
> >  	.swap_input_support = true,
> >  	.dimension_mask = HPW_MASK,
> >  	.hvsize_mask = HSIZE_MASK,
> > +	.channel_swap_shift = CH_SWAP,
> >  	.limit = &mtk_dpi_limit,
> >  };
> >  
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-06-02 11:39 UTC|newest]

Thread overview: 450+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-23 10:47 [PATCH v10 00/21] drm/mediatek: Add mt8195 DisplayPort driver Guillaume Ranquet
2022-05-23 10:47 ` Guillaume Ranquet
2022-05-23 10:47 ` Guillaume Ranquet
2022-05-23 10:47 ` Guillaume Ranquet
2022-05-23 10:47 ` Guillaume Ranquet
2022-05-23 10:47 ` [PATCH v10 01/21] dt-bindings: mediatek,dpi: Add DPINTF compatible Guillaume Ranquet
2022-05-23 10:47   ` Guillaume Ranquet
2022-05-23 10:47   ` Guillaume Ranquet
2022-05-23 10:47   ` Guillaume Ranquet
2022-05-23 10:47   ` Guillaume Ranquet
2022-05-23 12:33   ` Rob Herring
2022-05-23 12:33     ` [PATCH v10 01/21] dt-bindings: mediatek, dpi: " Rob Herring
2022-05-23 12:33     ` Rob Herring
2022-05-23 12:33     ` Rob Herring
2022-05-23 12:33     ` Rob Herring
2022-05-24  3:29   ` [PATCH v10 01/21] dt-bindings: mediatek,dpi: " Chunfeng Yun
2022-05-24  3:29     ` Chunfeng Yun
2022-05-24  3:29     ` Chunfeng Yun
2022-05-24  3:29     ` Chunfeng Yun
2022-05-24  3:29     ` Chunfeng Yun
2022-05-25 11:55   ` AngeloGioacchino Del Regno
2022-05-25 11:55     ` AngeloGioacchino Del Regno
2022-05-25 11:55     ` AngeloGioacchino Del Regno
2022-05-25 11:55     ` AngeloGioacchino Del Regno
2022-05-25 11:55     ` AngeloGioacchino Del Regno
2022-06-07  2:31     ` Rex-BC Chen
2022-06-07  2:31       ` Rex-BC Chen
2022-06-07  2:31       ` Rex-BC Chen
2022-06-07  2:31       ` Rex-BC Chen
2022-06-07  2:31       ` Rex-BC Chen
2022-05-25 12:49   ` Maxime Ripard
2022-05-25 12:49     ` Maxime Ripard
2022-05-25 12:49     ` Maxime Ripard
2022-05-25 12:49     ` Maxime Ripard
2022-05-25 12:49     ` Maxime Ripard
2022-06-07  2:35     ` Rex-BC Chen
2022-06-07  2:35       ` Rex-BC Chen
2022-06-07  2:35       ` Rex-BC Chen
2022-06-07  2:35       ` Rex-BC Chen
2022-06-07  2:35       ` Rex-BC Chen
2022-05-23 10:47 ` [PATCH v10 02/21] dt-bindings: mediatek,dp: Add Display Port binding Guillaume Ranquet
2022-05-23 10:47   ` Guillaume Ranquet
2022-05-23 10:47   ` Guillaume Ranquet
2022-05-23 10:47   ` Guillaume Ranquet
2022-05-23 10:47   ` Guillaume Ranquet
2022-05-24  3:35   ` Chunfeng Yun
2022-05-24  3:35     ` Chunfeng Yun
2022-05-24  3:35     ` Chunfeng Yun
2022-05-24  3:35     ` Chunfeng Yun
2022-05-24  3:35     ` Chunfeng Yun
2022-06-10  2:27     ` Rex-BC Chen
2022-06-10  2:27       ` Rex-BC Chen
2022-06-10  2:27       ` Rex-BC Chen
2022-06-10  2:27       ` Rex-BC Chen
2022-06-10  2:27       ` Rex-BC Chen
2022-05-25 15:30   ` AngeloGioacchino Del Regno
2022-05-25 15:30     ` AngeloGioacchino Del Regno
2022-05-25 15:30     ` AngeloGioacchino Del Regno
2022-05-25 15:30     ` AngeloGioacchino Del Regno
2022-05-25 15:30     ` AngeloGioacchino Del Regno
2022-06-10  2:29     ` Rex-BC Chen
2022-06-10  2:29       ` Rex-BC Chen
2022-06-10  2:29       ` Rex-BC Chen
2022-06-10  2:29       ` Rex-BC Chen
2022-06-10  2:29       ` Rex-BC Chen
2022-06-02 13:20   ` Rob Herring
2022-06-02 13:20     ` Rob Herring
2022-06-02 13:20     ` Rob Herring
2022-06-02 13:20     ` Rob Herring
2022-06-02 13:20     ` Rob Herring
2022-05-23 10:47 ` [PATCH v10 03/21] drm/edid: Convert cea_sad helper struct to kernelDoc Guillaume Ranquet
2022-05-23 10:47   ` Guillaume Ranquet
2022-05-23 10:47   ` Guillaume Ranquet
2022-05-23 10:47   ` Guillaume Ranquet
2022-05-23 10:47   ` Guillaume Ranquet
2022-05-23 10:57   ` Matthias Brugger
2022-05-23 10:57     ` Matthias Brugger
2022-05-23 10:57     ` Matthias Brugger
2022-05-23 10:57     ` Matthias Brugger
2022-05-23 10:57     ` Matthias Brugger
2022-06-07  2:44     ` Rex-BC Chen
2022-06-07  2:44       ` Rex-BC Chen
2022-06-07  2:44       ` Rex-BC Chen
2022-06-07  2:44       ` Rex-BC Chen
2022-06-07  2:44       ` Rex-BC Chen
2022-05-25 12:01   ` AngeloGioacchino Del Regno
2022-05-25 12:01     ` AngeloGioacchino Del Regno
2022-05-25 12:01     ` AngeloGioacchino Del Regno
2022-05-25 12:01     ` AngeloGioacchino Del Regno
2022-05-25 12:01     ` AngeloGioacchino Del Regno
2022-06-07  2:45     ` Rex-BC Chen
2022-06-07  2:45       ` Rex-BC Chen
2022-06-07  2:45       ` Rex-BC Chen
2022-06-07  2:45       ` Rex-BC Chen
2022-06-07  2:45       ` Rex-BC Chen
2022-05-23 10:47 ` [PATCH v10 04/21] drm/edid: Add cea_sad helpers for freq/length Guillaume Ranquet
2022-05-23 10:47   ` Guillaume Ranquet
2022-05-23 10:47   ` Guillaume Ranquet
2022-05-23 10:47   ` Guillaume Ranquet
2022-05-23 10:47   ` Guillaume Ranquet
2022-05-25 12:26   ` AngeloGioacchino Del Regno
2022-05-25 12:26     ` AngeloGioacchino Del Regno
2022-05-25 12:26     ` AngeloGioacchino Del Regno
2022-05-25 12:26     ` AngeloGioacchino Del Regno
2022-05-25 12:26     ` AngeloGioacchino Del Regno
2022-06-10  6:50     ` Rex-BC Chen
2022-06-10  6:50       ` Rex-BC Chen
2022-06-10  6:50       ` Rex-BC Chen
2022-06-10  6:50       ` Rex-BC Chen
2022-06-10  6:50       ` Rex-BC Chen
2022-05-23 10:47 ` [PATCH v10 05/21] video/hdmi: Add audio_infoframe packing for DP Guillaume Ranquet
2022-05-23 10:47   ` Guillaume Ranquet
2022-05-23 10:47   ` Guillaume Ranquet
2022-05-23 10:47   ` Guillaume Ranquet
2022-05-23 10:47   ` Guillaume Ranquet
2022-05-25 12:32   ` AngeloGioacchino Del Regno
2022-05-25 12:32     ` AngeloGioacchino Del Regno
2022-05-25 12:32     ` AngeloGioacchino Del Regno
2022-05-25 12:32     ` AngeloGioacchino Del Regno
2022-05-25 12:32     ` AngeloGioacchino Del Regno
2022-06-07  3:10     ` Rex-BC Chen
2022-06-07  3:10       ` Rex-BC Chen
2022-06-07  3:10       ` Rex-BC Chen
2022-06-07  3:10       ` Rex-BC Chen
2022-06-07  3:10       ` Rex-BC Chen
2022-05-23 10:47 ` [PATCH v10 06/21] drm/mediatek: dpi: move dpi limits to SoC config Guillaume Ranquet
2022-05-23 10:47   ` Guillaume Ranquet
2022-05-23 10:47   ` Guillaume Ranquet
2022-05-23 10:47   ` Guillaume Ranquet
2022-05-23 10:47   ` Guillaume Ranquet
2022-05-23 10:47 ` [PATCH v10 07/21] drm/mediatek: dpi: implement a CK/DE pol toggle in " Guillaume Ranquet
2022-05-23 10:47   ` Guillaume Ranquet
2022-05-23 10:47   ` Guillaume Ranquet
2022-05-23 10:47   ` Guillaume Ranquet
2022-05-23 10:47   ` Guillaume Ranquet
2022-05-30  7:44   ` CK Hu
2022-05-30  7:44     ` CK Hu
2022-05-30  7:44     ` CK Hu
2022-05-30  7:44     ` CK Hu
2022-05-30  7:44     ` CK Hu
2022-06-07  2:54     ` Rex-BC Chen
2022-06-07  2:54       ` Rex-BC Chen
2022-06-07  2:54       ` Rex-BC Chen
2022-06-07  2:54       ` Rex-BC Chen
2022-06-07  2:54       ` Rex-BC Chen
2022-05-23 10:47 ` [PATCH v10 08/21] drm/mediatek: dpi: implement a swap_input " Guillaume Ranquet
2022-05-23 10:47   ` Guillaume Ranquet
2022-05-23 10:47   ` Guillaume Ranquet
2022-05-23 10:47   ` Guillaume Ranquet
2022-05-23 10:47   ` Guillaume Ranquet
2022-05-30  7:50   ` CK Hu
2022-05-30  7:50     ` CK Hu
2022-05-30  7:50     ` CK Hu
2022-05-30  7:50     ` CK Hu
2022-05-30  7:50     ` CK Hu
2022-06-13  3:12     ` Rex-BC Chen
2022-06-13  3:12       ` Rex-BC Chen
2022-06-13  3:12       ` Rex-BC Chen
2022-06-13  3:12       ` Rex-BC Chen
2022-06-13  3:12       ` Rex-BC Chen
2022-05-23 10:47 ` [PATCH v10 09/21] drm/mediatek: dpi: move dimension mask to " Guillaume Ranquet
2022-05-23 10:47   ` Guillaume Ranquet
2022-05-23 10:47   ` Guillaume Ranquet
2022-05-23 10:47   ` Guillaume Ranquet
2022-05-23 10:47   ` Guillaume Ranquet
2022-05-30  7:55   ` CK Hu
2022-05-30  7:55     ` CK Hu
2022-05-30  7:55     ` CK Hu
2022-05-30  7:55     ` CK Hu
2022-05-30  7:55     ` CK Hu
2022-05-23 10:47 ` [PATCH v10 10/21] drm/mediatek: dpi: move hvsize_mask " Guillaume Ranquet
2022-05-23 10:47   ` Guillaume Ranquet
2022-05-23 10:47   ` Guillaume Ranquet
2022-05-23 10:47   ` Guillaume Ranquet
2022-05-23 10:47   ` Guillaume Ranquet
2022-05-30  8:21   ` CK Hu
2022-05-30  8:21     ` CK Hu
2022-05-30  8:21     ` CK Hu
2022-05-30  8:21     ` CK Hu
2022-05-30  8:21     ` CK Hu
2022-05-23 10:47 ` [PATCH v10 11/21] drm/mediatek: dpi: move swap_shift " Guillaume Ranquet
2022-05-23 10:47   ` Guillaume Ranquet
2022-05-23 10:47   ` Guillaume Ranquet
2022-05-23 10:47   ` Guillaume Ranquet
2022-05-23 10:47   ` Guillaume Ranquet
2022-05-30  8:38   ` CK Hu
2022-05-30  8:38     ` CK Hu
2022-05-30  8:38     ` CK Hu
2022-05-30  8:38     ` CK Hu
2022-05-30  8:38     ` CK Hu
2022-06-02 11:38     ` Rex-BC Chen [this message]
2022-06-02 11:38       ` Rex-BC Chen
2022-06-02 11:38       ` Rex-BC Chen
2022-06-02 11:38       ` Rex-BC Chen
2022-06-02 11:38       ` Rex-BC Chen
2022-06-02 12:19     ` Rex-BC Chen
2022-06-02 12:19       ` Rex-BC Chen
2022-06-02 12:19       ` Rex-BC Chen
2022-06-02 12:19       ` Rex-BC Chen
2022-06-02 12:19       ` Rex-BC Chen
2022-05-23 10:47 ` [PATCH v10 12/21] drm/mediatek: dpi: move the yuv422_en_bit " Guillaume Ranquet
2022-05-23 10:47   ` Guillaume Ranquet
2022-05-23 10:47   ` Guillaume Ranquet
2022-05-23 10:47   ` Guillaume Ranquet
2022-05-23 10:47   ` Guillaume Ranquet
2022-05-30  8:47   ` CK Hu
2022-05-30  8:47     ` CK Hu
2022-05-30  8:47     ` CK Hu
2022-05-30  8:47     ` CK Hu
2022-05-30  8:47     ` CK Hu
2022-05-23 10:47 ` [PATCH v10 13/21] drm/mediatek: dpi: move the csc_enable bit " Guillaume Ranquet
2022-05-23 10:47   ` Guillaume Ranquet
2022-05-23 10:47   ` Guillaume Ranquet
2022-05-23 10:47   ` Guillaume Ranquet
2022-05-23 10:47   ` Guillaume Ranquet
2022-05-23 10:47 ` [PATCH v10 14/21] drm/mediatek: dpi: Add dpintf support Guillaume Ranquet
2022-05-23 10:47   ` Guillaume Ranquet
2022-05-23 10:47   ` Guillaume Ranquet
2022-05-23 10:47   ` Guillaume Ranquet
2022-05-23 10:47   ` Guillaume Ranquet
2022-05-25 12:58   ` AngeloGioacchino Del Regno
2022-05-25 12:58     ` AngeloGioacchino Del Regno
2022-05-25 12:58     ` AngeloGioacchino Del Regno
2022-05-25 12:58     ` AngeloGioacchino Del Regno
2022-05-25 12:58     ` AngeloGioacchino Del Regno
2022-06-13  6:10     ` Rex-BC Chen
2022-06-13  6:10       ` Rex-BC Chen
2022-06-13  6:10       ` Rex-BC Chen
2022-06-13  6:10       ` Rex-BC Chen
2022-06-13  6:10       ` Rex-BC Chen
2022-06-02  5:48   ` Christophe JAILLET
2022-06-02  5:48     ` Christophe JAILLET
2022-06-02  5:48     ` Christophe JAILLET
2022-06-02  5:48     ` Christophe JAILLET
2022-06-02  5:48     ` Christophe JAILLET
2022-06-13  6:05     ` Rex-BC Chen
2022-06-13  6:05       ` Rex-BC Chen
2022-06-13  6:05       ` Rex-BC Chen
2022-06-13  6:05       ` Rex-BC Chen
2022-06-13  6:05       ` Rex-BC Chen
2022-05-23 10:47 ` [PATCH v10 15/21] drm/mediatek: dpi: Only enable dpi after the bridge is enabled Guillaume Ranquet
2022-05-23 10:47   ` Guillaume Ranquet
2022-05-23 10:47   ` Guillaume Ranquet
2022-05-23 10:47   ` Guillaume Ranquet
2022-05-23 10:47   ` Guillaume Ranquet
2022-05-23 10:47 ` [PATCH v10 16/21] drm/meditek: dpi: Add matrix_sel helper Guillaume Ranquet
2022-05-23 10:47   ` Guillaume Ranquet
2022-05-23 10:47   ` Guillaume Ranquet
2022-05-23 10:47   ` Guillaume Ranquet
2022-05-23 10:47   ` Guillaume Ranquet
2022-05-23 10:47 ` [PATCH v10 17/21] phy: phy-mtk-dp: Add driver for DP phy Guillaume Ranquet
2022-05-23 10:47   ` Guillaume Ranquet
2022-05-23 10:47   ` Guillaume Ranquet
2022-05-23 10:47   ` Guillaume Ranquet
2022-05-23 10:47   ` Guillaume Ranquet
2022-06-08 16:31   ` Vinod Koul
2022-06-08 16:31     ` Vinod Koul
2022-06-08 16:31     ` Vinod Koul
2022-06-08 16:31     ` Vinod Koul
2022-06-08 16:31     ` Vinod Koul
2022-05-23 10:47 ` [PATCH v10 18/21] drm/mediatek: Add mt8195 Embedded DisplayPort driver Guillaume Ranquet
2022-05-23 10:47   ` Guillaume Ranquet
2022-05-23 10:47   ` Guillaume Ranquet
2022-05-23 10:47   ` Guillaume Ranquet
2022-05-23 10:47   ` Guillaume Ranquet
2022-05-25  5:47   ` CK Hu
2022-05-25  5:47     ` CK Hu
2022-05-25  5:47     ` CK Hu
2022-05-25  5:47     ` CK Hu
2022-05-25  5:47     ` CK Hu
2022-05-30  9:34   ` CK Hu
2022-05-30  9:34     ` CK Hu
2022-05-30  9:34     ` CK Hu
2022-05-30  9:34     ` CK Hu
2022-05-30  9:34     ` CK Hu
2022-05-30 10:08   ` CK Hu
2022-05-30 10:08     ` CK Hu
2022-05-30 10:08     ` CK Hu
2022-05-30 10:08     ` CK Hu
2022-05-30 10:08     ` CK Hu
2022-06-07  6:21   ` CK Hu
2022-06-07  6:21     ` CK Hu
2022-06-07  6:21     ` CK Hu
2022-06-07  6:21     ` CK Hu
2022-06-07  6:21     ` CK Hu
2022-06-07 12:24     ` Rex-BC Chen
2022-06-07 12:24       ` Rex-BC Chen
2022-06-07 12:24       ` Rex-BC Chen
2022-06-07 12:24       ` Rex-BC Chen
2022-06-07 12:24       ` Rex-BC Chen
2022-06-08  2:23       ` CK Hu
2022-06-08  2:23         ` CK Hu
2022-06-08  2:23         ` CK Hu
2022-06-08  2:23         ` CK Hu
2022-06-08  2:23         ` CK Hu
2022-06-08  8:43         ` Rex-BC Chen
2022-06-08  8:43           ` Rex-BC Chen
2022-06-08  8:43           ` Rex-BC Chen
2022-06-08  8:43           ` Rex-BC Chen
2022-06-08  8:43           ` Rex-BC Chen
2022-06-08  9:15           ` CK Hu
2022-06-08  9:15             ` CK Hu
2022-06-08  9:15             ` CK Hu
2022-06-08  9:15             ` CK Hu
2022-06-08  9:15             ` CK Hu
2022-06-08 11:52             ` Rex-BC Chen
2022-06-08 11:52               ` Rex-BC Chen
2022-06-08 11:52               ` Rex-BC Chen
2022-06-08 11:52               ` Rex-BC Chen
2022-06-08 11:52               ` Rex-BC Chen
2022-06-07  6:44   ` CK Hu
2022-06-07  6:44     ` CK Hu
2022-06-07  6:44     ` CK Hu
2022-06-07  6:44     ` CK Hu
2022-06-07  6:44     ` CK Hu
2022-06-07 12:44     ` Rex-BC Chen
2022-06-07 12:44       ` Rex-BC Chen
2022-06-07 12:44       ` Rex-BC Chen
2022-06-07 12:44       ` Rex-BC Chen
2022-06-07 12:44       ` Rex-BC Chen
2022-06-08  2:44       ` CK Hu
2022-06-08  2:44         ` CK Hu
2022-06-08  2:44         ` CK Hu
2022-06-08  2:44         ` CK Hu
2022-06-08  2:44         ` CK Hu
2022-06-08 12:54         ` Rex-BC Chen
2022-06-08 12:54           ` Rex-BC Chen
2022-06-08 12:54           ` Rex-BC Chen
2022-06-08 12:54           ` Rex-BC Chen
2022-06-08 12:54           ` Rex-BC Chen
2022-06-07  7:30   ` CK Hu
2022-06-07  7:30     ` CK Hu
2022-06-07  7:30     ` CK Hu
2022-06-07  7:30     ` CK Hu
2022-06-07  7:30     ` CK Hu
2022-06-07 12:46     ` Rex-BC Chen
2022-06-07 12:46       ` Rex-BC Chen
2022-06-07 12:46       ` Rex-BC Chen
2022-06-07 12:46       ` Rex-BC Chen
2022-06-07 12:46       ` Rex-BC Chen
2022-06-07  7:47   ` CK Hu
2022-06-07  7:47     ` CK Hu
2022-06-07  7:47     ` CK Hu
2022-06-07  7:47     ` CK Hu
2022-06-07  7:47     ` CK Hu
2022-06-08 10:26     ` Rex-BC Chen
2022-06-08 10:26       ` Rex-BC Chen
2022-06-08 10:26       ` Rex-BC Chen
2022-06-08 10:26       ` Rex-BC Chen
2022-06-08 10:26       ` Rex-BC Chen
2022-06-09  2:30       ` CK Hu
2022-06-09  2:30         ` CK Hu
2022-06-09  2:30         ` CK Hu
2022-06-09  2:30         ` CK Hu
2022-06-09  2:30         ` CK Hu
2022-06-09  7:24         ` Rex-BC Chen
2022-06-09  7:24           ` Rex-BC Chen
2022-06-09  7:24           ` Rex-BC Chen
2022-06-09  7:24           ` Rex-BC Chen
2022-06-09  7:24           ` Rex-BC Chen
2022-06-07  8:01   ` CK Hu
2022-06-07  8:01     ` CK Hu
2022-06-07  8:01     ` CK Hu
2022-06-07  8:01     ` CK Hu
2022-06-07  8:01     ` CK Hu
2022-06-09  7:18     ` Rex-BC Chen
2022-06-09  7:18       ` Rex-BC Chen
2022-06-09  7:18       ` Rex-BC Chen
2022-06-09  7:18       ` Rex-BC Chen
2022-06-09  7:18       ` Rex-BC Chen
2022-06-07  8:12   ` CK Hu
2022-06-07  8:12     ` CK Hu
2022-06-07  8:12     ` CK Hu
2022-06-07  8:12     ` CK Hu
2022-06-07  8:12     ` CK Hu
2022-06-07 12:55     ` Rex-BC Chen
2022-06-07 12:55       ` Rex-BC Chen
2022-06-07 12:55       ` Rex-BC Chen
2022-06-07 12:55       ` Rex-BC Chen
2022-06-07 12:55       ` Rex-BC Chen
2022-06-07  9:04   ` CK Hu
2022-06-07  9:04     ` CK Hu
2022-06-07  9:04     ` CK Hu
2022-06-07  9:04     ` CK Hu
2022-06-07  9:04     ` CK Hu
2022-06-09  8:00     ` Rex-BC Chen
2022-06-09  8:00       ` Rex-BC Chen
2022-06-09  8:00       ` Rex-BC Chen
2022-06-09  8:00       ` Rex-BC Chen
2022-06-09  8:00       ` Rex-BC Chen
2022-06-08  8:30   ` CK Hu
2022-06-08  8:30     ` CK Hu
2022-06-08  8:30     ` CK Hu
2022-06-08  8:30     ` CK Hu
2022-06-08  8:30     ` CK Hu
2022-06-09  8:03     ` Rex-BC Chen
2022-06-09  8:03       ` Rex-BC Chen
2022-06-09  8:03       ` Rex-BC Chen
2022-06-09  8:03       ` Rex-BC Chen
2022-06-09  8:03       ` Rex-BC Chen
2022-06-08  8:45   ` CK Hu
2022-06-08  8:45     ` CK Hu
2022-06-08  8:45     ` CK Hu
2022-06-08  8:45     ` CK Hu
2022-06-08  8:45     ` CK Hu
2022-06-08  8:54     ` Rex-BC Chen
2022-06-08  8:54       ` Rex-BC Chen
2022-06-08  8:54       ` Rex-BC Chen
2022-06-08  8:54       ` Rex-BC Chen
2022-06-08  8:54       ` Rex-BC Chen
2022-06-09  9:37   ` CK Hu
2022-06-09  9:37     ` CK Hu
2022-06-09  9:37     ` CK Hu
2022-06-09  9:37     ` CK Hu
2022-06-09  9:37     ` CK Hu
2022-06-10  2:10     ` Rex-BC Chen
2022-06-10  2:10       ` Rex-BC Chen
2022-06-10  2:10       ` Rex-BC Chen
2022-06-10  2:10       ` Rex-BC Chen
2022-06-10  2:10       ` Rex-BC Chen
2022-05-23 10:47 ` [PATCH v10 19/21] drm/mediatek: Add mt8195 External DisplayPort support Guillaume Ranquet
2022-05-23 10:47   ` Guillaume Ranquet
2022-05-23 10:47   ` Guillaume Ranquet
2022-05-23 10:47   ` Guillaume Ranquet
2022-05-23 10:47   ` Guillaume Ranquet
2022-05-25 13:04   ` AngeloGioacchino Del Regno
2022-05-25 13:04     ` AngeloGioacchino Del Regno
2022-05-25 13:04     ` AngeloGioacchino Del Regno
2022-05-25 13:04     ` AngeloGioacchino Del Regno
2022-05-25 13:04     ` AngeloGioacchino Del Regno
2022-05-23 10:47 ` [PATCH v10 20/21] drm/mediatek: add hpd debounce Guillaume Ranquet
2022-05-23 10:47   ` Guillaume Ranquet
2022-05-23 10:47   ` Guillaume Ranquet
2022-05-23 10:47   ` Guillaume Ranquet
2022-05-23 10:47   ` Guillaume Ranquet
2022-05-23 10:47 ` [PATCH v10 21/21] drm/mediatek: DP audio support for mt8195 Guillaume Ranquet
2022-05-23 10:47   ` Guillaume Ranquet
2022-05-23 10:47   ` Guillaume Ranquet
2022-05-23 10:47   ` Guillaume Ranquet
2022-05-23 10:47   ` Guillaume Ranquet
2022-06-02  3:50 ` [PATCH v10 00/21] drm/mediatek: Add mt8195 DisplayPort driver Rex-BC Chen
2022-06-02  3:50   ` Rex-BC Chen
2022-06-02  3:50   ` Rex-BC Chen
2022-06-02  3:50   ` Rex-BC Chen
2022-06-02  3:50   ` Rex-BC Chen
2022-06-02  5:31   ` Rex-BC Chen
2022-06-02  5:31     ` Rex-BC Chen
2022-06-02  5:31     ` Rex-BC Chen
2022-06-02  5:31     ` Rex-BC Chen
2022-06-02  5:31     ` Rex-BC Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=be98423304bd51959dd9334215114bd179ec1e6b.camel@mediatek.com \
    --to=rex-bc.chen@mediatek.com \
    --cc=airlied@linux.ie \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=chunfeng.yun@mediatek.com \
    --cc=chunkuang.hu@kernel.org \
    --cc=ck.hu@mediatek.com \
    --cc=daniel@ffwll.ch \
    --cc=deller@gmx.de \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=granquet@baylibre.com \
    --cc=jitao.shi@mediatek.com \
    --cc=kishon@ti.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=matthias.bgg@gmail.com \
    --cc=mripard@kernel.org \
    --cc=p.zabel@pengutronix.de \
    --cc=robh+dt@kernel.org \
    --cc=tzimmermann@suse.de \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.