From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: Rami Rosen <roszenrami@gmail.com>
Cc: Ferruh Yigit <ferruh.yigit@intel.com>,
dev@dpdk.org, john.mcnamara@intel.com, stable@dpdk.org
Subject: Re: [dpdk-stable] [PATCH] devbind: check for lspci
Date: Mon, 12 Nov 2018 09:18:14 +0000 [thread overview]
Message-ID: <be99e233-7994-8059-c2b1-31825161991c@intel.com> (raw)
In-Reply-To: <CAKoUAr=EkD34X4jXRTp=bMBkCvp79GaqtpEr9VLRfg7ztQ3pqw@mail.gmail.com>
On 10-Nov-18 11:03 AM, Rami Rosen wrote:
> HI Anatoly,
>
>> Do all other distros have lspci in package called pciutils? If not, i
>> prefer to keep it the way it is.
>
> Your original patch have:
>
> + if ret != 0:
> + print("'lspci' not found - please install 'lspci'")
>
> And I suggest to consider changing it to:
>
> >> + if ret != 0:
> >> + print("'lspci' not found - please install pciutils')
>>
>
> Sorry about my ignorance: which distro has a package named "lspci", if at all?
>
> The official project that include the lspci utility is called
> "pciutils": see: http://mj.ucw.cz/sw/pciutils/
> You can see that a package named "pciutils" is available in great many
> distros, like:
> Fedora, OpenSuSE, CentOS, RHEL, Ubuntu, Debian, Mandriva and Mageia,
> according to the following links:
>
> http://www.rpmfind.net/linux/rpm2html/search.php?query=pciutils&submit=Search+...
> https://packages.ubuntu.com/trusty/pciutils
> https://packages.debian.org/search?keywords=pciutils
> https://rpms.remirepo.net/rpmphp/zoom.php?rpm=pciutils
>
> Regards,
> Rami Rosen
>
Hi,
Thanks, that's good to know, will fix in v2.
--
Thanks,
Anatoly
next prev parent reply other threads:[~2018-11-12 9:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-07 13:56 [PATCH] devbind: check for lspci Anatoly Burakov
2018-11-07 16:01 ` [dpdk-stable] " Ferruh Yigit
2018-11-07 16:30 ` Burakov, Anatoly
2018-11-07 18:07 ` Ferruh Yigit
2018-11-08 20:38 ` Rami Rosen
2018-11-09 12:03 ` Burakov, Anatoly
2018-11-10 11:03 ` Rami Rosen
2018-11-12 9:18 ` Burakov, Anatoly [this message]
2018-11-13 16:03 ` Burakov, Anatoly
2018-11-13 16:06 ` [PATCH v2] " Anatoly Burakov
2018-11-16 16:54 ` Rami Rosen
2018-11-18 23:05 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=be99e233-7994-8059-c2b1-31825161991c@intel.com \
--to=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=john.mcnamara@intel.com \
--cc=roszenrami@gmail.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.