* [PATCH] docs/devel: fix missing antislash
@ 2021-08-09 17:31 Alexandre Iooss
2021-08-09 18:14 ` Eduardo Habkost
0 siblings, 1 reply; 3+ messages in thread
From: Alexandre Iooss @ 2021-08-09 17:31 UTC (permalink / raw)
To: open list:All patches CC here
Cc: Alexandre Iooss, Paolo Bonzini, Eduardo Habkost,
Philippe Mathieu-Daudé
Signed-off-by: Alexandre Iooss <erdnaxe@crans.org>
---
docs/devel/qom.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/docs/devel/qom.rst b/docs/devel/qom.rst
index e5fe3597cd..b9568c0fb8 100644
--- a/docs/devel/qom.rst
+++ b/docs/devel/qom.rst
@@ -309,7 +309,7 @@ This is equivalent to the following:
OBJECT_GET_CLASS(MyDeviceClass, obj, TYPE_MY_DEVICE)
#define MY_DEVICE_CLASS(void *klass) \
OBJECT_CLASS_CHECK(MyDeviceClass, klass, TYPE_MY_DEVICE)
- #define MY_DEVICE(void *obj)
+ #define MY_DEVICE(void *obj) \
OBJECT_CHECK(MyDevice, obj, TYPE_MY_DEVICE)
struct MyDeviceClass {
--
2.31.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] docs/devel: fix missing antislash
2021-08-09 17:31 [PATCH] docs/devel: fix missing antislash Alexandre Iooss
@ 2021-08-09 18:14 ` Eduardo Habkost
2021-08-10 10:12 ` Alexandre IOOSS
0 siblings, 1 reply; 3+ messages in thread
From: Eduardo Habkost @ 2021-08-09 18:14 UTC (permalink / raw)
To: Alexandre Iooss
Cc: Paolo Bonzini, open list:All patches CC here,
Philippe Mathieu-Daudé
On Mon, Aug 09, 2021 at 07:31:41PM +0200, Alexandre Iooss wrote:
> Signed-off-by: Alexandre Iooss <erdnaxe@crans.org>
> ---
> docs/devel/qom.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/docs/devel/qom.rst b/docs/devel/qom.rst
> index e5fe3597cd..b9568c0fb8 100644
> --- a/docs/devel/qom.rst
> +++ b/docs/devel/qom.rst
> @@ -309,7 +309,7 @@ This is equivalent to the following:
> OBJECT_GET_CLASS(MyDeviceClass, obj, TYPE_MY_DEVICE)
> #define MY_DEVICE_CLASS(void *klass) \
> OBJECT_CLASS_CHECK(MyDeviceClass, klass, TYPE_MY_DEVICE)
> - #define MY_DEVICE(void *obj)
> + #define MY_DEVICE(void *obj) \
> OBJECT_CHECK(MyDevice, obj, TYPE_MY_DEVICE)
Oops, nice catch!
However, the code above is already going to be deleted by:
https://lore.kernel.org/qemu-devel/20210729175554.686474-9-ehabkost@redhat.com
--
Eduardo
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] docs/devel: fix missing antislash
2021-08-09 18:14 ` Eduardo Habkost
@ 2021-08-10 10:12 ` Alexandre IOOSS
0 siblings, 0 replies; 3+ messages in thread
From: Alexandre IOOSS @ 2021-08-10 10:12 UTC (permalink / raw)
To: Eduardo Habkost
Cc: Paolo Bonzini, open list:All patches CC here,
Philippe Mathieu-Daudé
[-- Attachment #1.1: Type: text/plain, Size: 1112 bytes --]
On 8/9/21 8:14 PM, Eduardo Habkost wrote:
> On Mon, Aug 09, 2021 at 07:31:41PM +0200, Alexandre Iooss wrote:
>> Signed-off-by: Alexandre Iooss <erdnaxe@crans.org>
>> ---
>> docs/devel/qom.rst | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/docs/devel/qom.rst b/docs/devel/qom.rst
>> index e5fe3597cd..b9568c0fb8 100644
>> --- a/docs/devel/qom.rst
>> +++ b/docs/devel/qom.rst
>> @@ -309,7 +309,7 @@ This is equivalent to the following:
>> OBJECT_GET_CLASS(MyDeviceClass, obj, TYPE_MY_DEVICE)
>> #define MY_DEVICE_CLASS(void *klass) \
>> OBJECT_CLASS_CHECK(MyDeviceClass, klass, TYPE_MY_DEVICE)
>> - #define MY_DEVICE(void *obj)
>> + #define MY_DEVICE(void *obj) \
>> OBJECT_CHECK(MyDevice, obj, TYPE_MY_DEVICE)
>
> Oops, nice catch!
>
> However, the code above is already going to be deleted by:
> https://lore.kernel.org/qemu-devel/20210729175554.686474-9-ehabkost@redhat.com
>
Oh I was not aware of that new patch, it looks great while also solving
the anti-slash problem!
Thanks,
-- Alexandre
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-08-10 10:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-09 17:31 [PATCH] docs/devel: fix missing antislash Alexandre Iooss
2021-08-09 18:14 ` Eduardo Habkost
2021-08-10 10:12 ` Alexandre IOOSS
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.