From: Jens Axboe <axboe@kernel.dk>
To: Johannes Thumshirn <jthumshirn@suse.de>
Cc: Hannes Reinecke <hare@suse.de>,
Bart Van Assche <bvanassche@acm.org>,
Christoph Hellwig <hch@lst.de>, Jan Kara <jack@suse.cz>,
Linux Block Layer Mailinglist <linux-block@vger.kernel.org>,
Linux FSDEVEL Mailinglist <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH 1/2] block: bio: ensure newly added bio flags don't override BVEC_POOL_IDX
Date: Thu, 21 Mar 2019 08:25:04 -0600 [thread overview]
Message-ID: <beaecea2-13b2-e8ef-de18-b841f4fe82de@kernel.dk> (raw)
In-Reply-To: <64dce739-128b-1770-4062-9ba566ceda63@suse.de>
On 3/21/19 8:23 AM, Johannes Thumshirn wrote:
> On 21/03/2019 15:21, Jens Axboe wrote:
>> On 3/21/19 8:15 AM, Jens Axboe wrote:
>>> You also haven't solved the issue of now having an extra bit, 2/2 uses
>>> the last bit which the other patch already took...
>>
>> Here's one way - kill BIO_SEG_VALID. We should just use
>> ->bi_phys_segments to tell if it's valid or not. This patch uses -1 to
>> signify it's not.
>>
>> Totally untested...
>
>
> That sounds like an idea, I'll trow some testing at it and report back.
That'd be great, thanks. If we can do that as a prep patch for you, then
you can just use an enum and not worry about initializing since I'll just
shove BIO_PAGE_NO_REF at the end.
And this is simpler than having to shift the masks around.
--
Jens Axboe
next prev parent reply other threads:[~2019-03-21 14:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-21 12:30 [PATCH 0/2] add flag for tracking bio allocation Johannes Thumshirn
2019-03-21 12:30 ` [PATCH 1/2] block: bio: ensure newly added bio flags don't override BVEC_POOL_IDX Johannes Thumshirn
2019-03-21 13:18 ` Hannes Reinecke
2019-03-21 13:22 ` Johannes Thumshirn
2019-03-21 14:15 ` Jens Axboe
2019-03-21 14:21 ` Jens Axboe
2019-03-21 14:23 ` Johannes Thumshirn
2019-03-21 14:25 ` Jens Axboe [this message]
2019-03-21 15:54 ` Hannes Reinecke
2019-03-22 10:24 ` Johannes Thumshirn
2019-03-21 12:30 ` [PATCH 2/2] bio: introduce BIO_ALLOCED flag and check it in bio_free Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=beaecea2-13b2-e8ef-de18-b841f4fe82de@kernel.dk \
--to=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=jthumshirn@suse.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.