From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23E5BC433E0 for ; Thu, 16 Jul 2020 07:49:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F0293206C1 for ; Thu, 16 Jul 2020 07:49:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=walle.cc header.i=@walle.cc header.b="bdKZJZ56" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726556AbgGPHt2 (ORCPT ); Thu, 16 Jul 2020 03:49:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42148 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725831AbgGPHt2 (ORCPT ); Thu, 16 Jul 2020 03:49:28 -0400 Received: from ssl.serverraum.org (ssl.serverraum.org [IPv6:2a01:4f8:151:8464::1:2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E06FEC061755; Thu, 16 Jul 2020 00:49:27 -0700 (PDT) Received: from ssl.serverraum.org (web.serverraum.org [172.16.0.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ssl.serverraum.org (Postfix) with ESMTPSA id 8D48622ED8; Thu, 16 Jul 2020 09:49:24 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=walle.cc; s=mail2016061301; t=1594885765; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pWBr+/btBiE5Q9vVGPEpJuj78sM+TfheCGwdYlLfv10=; b=bdKZJZ56SYA/gpVU/tzL8+QSrck8/I5DVSK86+eoQLrGVqQjGeoYMB2KIjTGrCKk4wPayU yf2mzJzDdUXZQ2UdlaoRm1gO6I/XqK7yPcePojI1UXyBQb37x4JI0gjbJQ1TSrZfj8Ys5F Cj9hS4wG9wvxe4svOPk41MVBiYGTLPw= MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 16 Jul 2020 09:49:24 +0200 From: Michael Walle To: Vladimir Oltean Cc: Russell King - ARM Linux admin , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, "David S . Miller" , Jakub Kicinski , Andrew Lunn , Alex Marginean , Claudiu Manoil , Heiko Thiery , Ioana Ciornei , Microchip Linux Driver Support Subject: Re: [PATCH net-next v6 1/4] net: phy: add USXGMII link partner ability constants In-Reply-To: <20200715224449.hrqblfteshuknxon@skbuf> References: <20200709213526.21972-1-michael@walle.cc> <20200709213526.21972-2-michael@walle.cc> <20200713182314.GW1551@shell.armlinux.org.uk> <546718f3f76862d285aeb82cb02767c4@walle.cc> <20200715224449.hrqblfteshuknxon@skbuf> User-Agent: Roundcube Webmail/1.4.7 Message-ID: X-Sender: michael@walle.cc Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 2020-07-16 00:44, schrieb Vladimir Oltean: > On Wed, Jul 15, 2020 at 10:33:23PM +0200, Michael Walle wrote: >> Am 2020-07-13 20:37, schrieb Michael Walle: >> > Am 2020-07-13 20:23, schrieb Russell King - ARM Linux admin: >> > > On Thu, Jul 09, 2020 at 11:35:23PM +0200, Michael Walle wrote: >> > > > The constants are taken from the USXGMII Singleport Copper Interface >> > > > specification. The naming are based on the SGMII ones, but with >> > > > an MDIO_ >> > > > prefix. >> > > > >> > > > Signed-off-by: Michael Walle >> > > > --- >> > > > include/uapi/linux/mdio.h | 26 ++++++++++++++++++++++++++ >> > > > 1 file changed, 26 insertions(+) >> > > > >> > > > diff --git a/include/uapi/linux/mdio.h b/include/uapi/linux/mdio.h >> > > > index 4bcb41c71b8c..784723072578 100644 >> > > > --- a/include/uapi/linux/mdio.h >> > > > +++ b/include/uapi/linux/mdio.h >> > > > @@ -324,4 +324,30 @@ static inline __u16 mdio_phy_id_c45(int >> > > > prtad, int devad) >> > > > return MDIO_PHY_ID_C45 | (prtad << 5) | devad; >> > > > } >> > > > >> > > > +/* UsxgmiiChannelInfo[15:0] for USXGMII in-band auto-negotiation.*/ >> > > > +#define MDIO_LPA_USXGMII_EEE_CLK_STP 0x0080 /* EEE clock stop >> > > > supported */ >> > > > +#define MDIO_LPA_USXGMII_EEE 0x0100 /* EEE supported */ >> > > > +#define MDIO_LPA_USXGMII_SPD_MASK 0x0e00 /* USXGMII speed mask */ >> > > > +#define MDIO_LPA_USXGMII_FULL_DUPLEX 0x1000 /* USXGMII full >> > > > duplex */ >> > > > +#define MDIO_LPA_USXGMII_DPX_SPD_MASK 0x1e00 /* USXGMII duplex >> > > > and speed bits */ >> > > > +#define MDIO_LPA_USXGMII_10 0x0000 /* 10Mbps */ >> > > > +#define MDIO_LPA_USXGMII_10HALF 0x0000 /* 10Mbps half-duplex */ >> > > > +#define MDIO_LPA_USXGMII_10FULL 0x1000 /* 10Mbps full-duplex */ >> > > > +#define MDIO_LPA_USXGMII_100 0x0200 /* 100Mbps */ >> > > > +#define MDIO_LPA_USXGMII_100HALF 0x0200 /* 100Mbps half-duplex */ >> > > > +#define MDIO_LPA_USXGMII_100FULL 0x1200 /* 100Mbps full-duplex */ >> > > > +#define MDIO_LPA_USXGMII_1000 0x0400 /* 1000Mbps */ >> > > > +#define MDIO_LPA_USXGMII_1000HALF 0x0400 /* 1000Mbps half-duplex */ >> > > > +#define MDIO_LPA_USXGMII_1000FULL 0x1400 /* 1000Mbps full-duplex */ >> > > > +#define MDIO_LPA_USXGMII_10G 0x0600 /* 10Gbps */ >> > > > +#define MDIO_LPA_USXGMII_10GHALF 0x0600 /* 10Gbps half-duplex */ >> > > > +#define MDIO_LPA_USXGMII_10GFULL 0x1600 /* 10Gbps full-duplex */ >> > > > +#define MDIO_LPA_USXGMII_2500 0x0800 /* 2500Mbps */ >> > > > +#define MDIO_LPA_USXGMII_2500HALF 0x0800 /* 2500Mbps half-duplex */ >> > > > +#define MDIO_LPA_USXGMII_2500FULL 0x1800 /* 2500Mbps full-duplex */ >> > > > +#define MDIO_LPA_USXGMII_5000 0x0a00 /* 5000Mbps */ >> > > > +#define MDIO_LPA_USXGMII_5000HALF 0x0a00 /* 5000Mbps half-duplex */ >> > > > +#define MDIO_LPA_USXGMII_5000FULL 0x1a00 /* 5000Mbps full-duplex */ >> > > > +#define MDIO_LPA_USXGMII_LINK 0x8000 /* PHY link with >> > > > copper-side partner */ >> > > >> > > btw, the only thing which is missing from this is bit 0. >> > >> > TBH, I didn't know how to name it. Any suggestions? >> >> NXP calls it ABIL0, in xilinx docs its called USXGMII [1]. In the >> USXGMII >> spec, its "set to 1 (0 is SGMII)" which I don't understand because its >> also 1 for SGMII, right? At least as described in the >> tx_configReg[15:0] in >> the SGMII spec. >> >> #define MDIO_USXGMII_USXGMII 0x0001 ? >> >> -michael >> >> [1] >> https://www.xilinx.com/support/documentation/ip_documentation/usxgmii/v1_0/pg251-usxgmii.pdf > > The explanation in the spec is quite cryptic, I've taken that to mean > "corresponds to bit 0 in SGMII". Hence the reason why, in the code I've > introduced in Felix, this is simply used as ADVERTISE_SGMII. I have no > problem in creating an alias to ADVERTISE_SGMII named > MDIO_LPA_USXGMII_SGMII. That being said, I don't see, right now, a > practical situation where you might want to parse bit 0 from LPA, it's > just like in Forrest Gump: "life is like a box of chocolates, you never > know what you're gonna get". Adding it now to the UAPI might very well > be a non-issue. what about #define MDIO_USXGMII_ADVERTISE 0x0001 /* must always be set */ Russell, do you agree? Then I'd send a new version with your "Reviewed-by:". -michael