Re: [PATCH] mtd: spi-nor-ids: Add Winbond W25Q128JW ID

[<Tudor.Ambarus@microchip.com>]

On 3/9/22 05:18, Marek Vasut wrote:

Hi!

> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> Add ID for Winbond W25Q128JW device. This is a 128 Mbit QSPI NOR.
> Tested on W25Q128JWPIM part.
> 
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Horatiu Vultur <horatiu.vultur@microchip.com>
> Cc: Jagan Teki <jagan@amarulasolutions.com>
> Cc: Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com>
> Cc: Stefan Roese <sr@denx.de>
> Cc: Vignesh R <vigneshr@ti.com>
> ---
>  drivers/mtd/spi/spi-nor-ids.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/mtd/spi/spi-nor-ids.c b/drivers/mtd/spi/spi-nor-ids.c
> index b551ebd75ef..e2d09fc747d 100644
> --- a/drivers/mtd/spi/spi-nor-ids.c
> +++ b/drivers/mtd/spi/spi-nor-ids.c
> @@ -345,6 +345,11 @@ const struct flash_info spi_nor_ids[] = {
>                         SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
>                         SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
>         },
> +       {
> +               INFO("w25q128jw", 0xef8018, 0, 64 * 1024, 256,

I'm glad I can discuss with you about the name of these winbond flashes,
you can help with an advice. In linux we name this flash "w25q128jwm",
but maybe we should change it.

Winbond names this flash "W25Q128JW_DTR", you can find the name on the
top right of each page from [1].

What I propose:
1/ according to [1] W25Q128JW_IM/JM is W25Q128JW_DTR, let's use "-dtr"
   for the M flavor.
2/ according to [2] W25Q128JW has two flavors: W25Q128JW-IQ/JQ and
   W25Q128JW-IM/JM*. Since W25Q128JW_IM/JM is called W25Q128JW_DTR, let's
   use just "W25Q128JW" for W25Q128JW-IQ/JQ, as winbond uses too.

Looking at [3], I see that W25Q128JV and W25Q128FV use the same flash ID,
I wonder what's the difference between them. I made a proposal in linux on
how to handle flash collisions, a v5 will follow.

Cheers,
ta
[1] https://www.winbond.com/resource-files/W25Q128JW_DTR%20RevF1%2005212021.pdf
[2] https://www.winbond.com/resource-files/W25Q128JW_RevG_07292021%20Plus.pdf
[3] https://www.winbond.com/hq/product/code-storage-flash-memory/serial-nor-flash/?__locale=en&selected=128Mb#Density

> +                       SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
> +                       SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
> +       },
>         {
>                 INFO("w25q256fw", 0xef6019, 0, 64 * 1024, 512,
>                         SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
> --
> 2.34.1
>