From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935223AbdAJPCv (ORCPT ); Tue, 10 Jan 2017 10:02:51 -0500 Received: from mx2.suse.de ([195.135.220.15]:49088 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932881AbdAJPCs (ORCPT ); Tue, 10 Jan 2017 10:02:48 -0500 Subject: Re: [PATCH 1/2] xen/netfront: set default upper limit of tx/rx queues to 8 To: Boris Ostrovsky , linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, netdev@vger.kernel.org References: <20170110133252.5346-1-jgross@suse.com> <20170110133252.5346-2-jgross@suse.com> <3ae4da4f-6a6a-db95-67a3-c0fba5524df1@oracle.com> Cc: wei.liu2@citrix.com, paul.durrant@citrix.com From: Juergen Gross Message-ID: Date: Tue, 10 Jan 2017 16:02:44 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <3ae4da4f-6a6a-db95-67a3-c0fba5524df1@oracle.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/01/17 15:53, Boris Ostrovsky wrote: > On 01/10/2017 08:32 AM, Juergen Gross wrote: >> The default for the number of tx/rx queues of one interface is the >> number of vcpus of the system today. As each queue pair reserves 512 >> grant pages this default consumes a ridiculous number of grants for >> large guests. >> >> Limit the queue number to 8 as default. This value can be modified >> via a module parameter if required. >> >> Signed-off-by: Juergen Gross >> --- >> drivers/net/xen-netfront.c | 6 ++++-- >> 1 file changed, 4 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c >> index a479cd9..490c865 100644 >> --- a/drivers/net/xen-netfront.c >> +++ b/drivers/net/xen-netfront.c >> @@ -57,6 +57,7 @@ >> #include >> >> /* Module parameters */ >> +#define MAX_QUEUES_DEFAULT 8 >> static unsigned int xennet_max_queues; >> module_param_named(max_queues, xennet_max_queues, uint, 0644); >> MODULE_PARM_DESC(max_queues, >> @@ -2164,11 +2165,12 @@ static int __init netif_init(void) >> >> pr_info("Initialising Xen virtual ethernet driver\n"); >> >> - /* Allow as many queues as there are CPUs if user has not >> + /* Allow as many queues as there are CPUs inut max. 8 if user has not > > Based on comment change in the second patch: s/inut/but/ ? Also, comment > style in both patches. Typo: yes Style: no. checkpatch tells me that the net directory doesn't follow common kernel style. > > Other than that, for both: > > Reviewed-by: Boris Ostrovsky Thanks, Juergen