All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Christian König" <ckoenig.leichtzumerken@gmail.com>
To: "Deng, Emily" <Emily.Deng@amd.com>,
	"Liu, Shaoyun" <Shaoyun.Liu@amd.com>,
	 "Luo, Zhigang" <Zhigang.Luo@amd.com>,
	"amd-gfx@lists.freedesktop.org" <amd-gfx@lists.freedesktop.org>
Subject: Re: [PATCH 1/5] drm/amdgpu: remove sriov vf checking from getting fb location
Date: Fri, 4 Jun 2021 13:14:13 +0200	[thread overview]
Message-ID: <befc7f07-613a-d1bd-434a-516035552a79@gmail.com> (raw)
In-Reply-To: <PH0PR12MB54171568B27151FC487210928F3B9@PH0PR12MB5417.namprd12.prod.outlook.com>

I was just about to question the same thing.

It looks really good to me to have that cleaned up, but if this breaks 
with older versions of the hypervisor then it is a bit questionable change.

Regards,
Christian.

Am 04.06.21 um 03:13 schrieb Deng, Emily:
> Do we need to consider backward compatibility?
>
>
> Best wishes
> Emily Deng
>
>
>> -----Original Message-----
>> From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> On Behalf Of Liu,
>> Shaoyun
>> Sent: Thursday, June 3, 2021 11:10 PM
>> To: Luo, Zhigang <Zhigang.Luo@amd.com>; amd-gfx@lists.freedesktop.org
>> Cc: Luo, Zhigang <Zhigang.Luo@amd.com>
>> Subject: RE: [PATCH 1/5] drm/amdgpu: remove sriov vf checking from getting fb
>> location
>>
>> [AMD Official Use Only]
>>
>> Looks ok to me .
>>
>> Reviewed-By : Shaoyun.liu <shaoyunl@amd.com>
>>
>> -----Original Message-----
>> From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> On Behalf Of Zhigang
>> Luo
>> Sent: Thursday, June 3, 2021 10:13 AM
>> To: amd-gfx@lists.freedesktop.org
>> Cc: Luo, Zhigang <Zhigang.Luo@amd.com>
>> Subject: [PATCH 1/5] drm/amdgpu: remove sriov vf checking from getting fb
>> location
>>
>> host driver programmed fb location registers for vf, no need to check anymore.
>>
>> Signed-off-by: Zhigang Luo <zhigang.luo@amd.com>
>> ---
>> drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 5 +----
>> 1 file changed, 1 insertion(+), 4 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
>> b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
>> index ceb3968d8326..1c2d9fde9021 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
>> @@ -1292,10 +1292,7 @@ static int gmc_v9_0_late_init(void *handle)  static
>> void gmc_v9_0_vram_gtt_location(struct amdgpu_device *adev,
>> 					struct amdgpu_gmc *mc)
>> {
>> -	u64 base = 0;
>> -
>> -	if (!amdgpu_sriov_vf(adev))
>> -		base = adev->mmhub.funcs->get_fb_location(adev);
>> +	u64 base = adev->mmhub.funcs->get_fb_location(adev);
>>
>> 	/* add the xgmi offset of the physical node */
>> 	base += adev->gmc.xgmi.physical_node_id * adev-
>>> gmc.xgmi.node_segment_size;
>> --
>> 2.17.1
>>
>> _______________________________________________
>> amd-gfx mailing list
>> amd-gfx@lists.freedesktop.org
>> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.fre
>> edesktop.org%2Fmailman%2Flistinfo%2Famd-
>> gfx&amp;data=04%7C01%7CEmily.Deng%40amd.com%7Cd41e78b1a3af4f08ff
>> d108d926a1a2d8%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C63
>> 7583297946242271%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAi
>> LCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=Nsz
>> ZyRZHCxj%2FIJ1hYoSrkv3LpTmF9FbchpNMtQ2GE5M%3D&amp;reserved=0
>> _______________________________________________
>> amd-gfx mailing list
>> amd-gfx@lists.freedesktop.org
>> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.fre
>> edesktop.org%2Fmailman%2Flistinfo%2Famd-
>> gfx&amp;data=04%7C01%7CEmily.Deng%40amd.com%7Cd41e78b1a3af4f08ff
>> d108d926a1a2d8%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C63
>> 7583297946242271%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAi
>> LCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=Nsz
>> ZyRZHCxj%2FIJ1hYoSrkv3LpTmF9FbchpNMtQ2GE5M%3D&amp;reserved=0
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

  reply	other threads:[~2021-06-04 11:14 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-03 14:13 [PATCH 1/5] drm/amdgpu: remove sriov vf checking from getting fb location Zhigang Luo
2021-06-03 14:13 ` [PATCH 2/5] drm/amdgpu: remove sriov vf gfxhub fb location programming Zhigang Luo
2021-06-03 15:10   ` Liu, Shaoyun
2021-06-03 15:22     ` Luo, Zhigang
2021-06-03 14:13 ` [PATCH 3/5] drm/amdgpu: remove sriov vf mmhub system aperture and " Zhigang Luo
2021-06-03 15:11   ` Liu, Shaoyun
2021-06-03 14:13 ` [PATCH 4/5] drm/amdgpu: add psp microcode init for arcturus and aldebaran sriov vf Zhigang Luo
2021-06-03 15:12   ` Liu, Shaoyun
2021-06-03 15:31     ` Luo, Zhigang
2021-06-07 13:51       ` Zhang, Hawking
2021-06-07 13:59         ` Luo, Zhigang
2021-06-03 14:13 ` [PATCH 5/5] drm/amdgpu: allocate psp fw private buffer from VRAM for " Zhigang Luo
2021-06-03 15:14   ` Liu, Shaoyun
2021-06-03 15:47     ` Luo, Zhigang
2021-06-03 16:43       ` Liu, Shaoyun
2021-06-03 15:09 ` [PATCH 1/5] drm/amdgpu: remove sriov vf checking from getting fb location Liu, Shaoyun
2021-06-04  1:13   ` Deng, Emily
2021-06-04 11:14     ` Christian König [this message]
2021-06-04 13:23       ` Luo, Zhigang
2021-06-04 13:46         ` Christian König
2021-06-04 14:06           ` Luo, Zhigang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=befc7f07-613a-d1bd-434a-516035552a79@gmail.com \
    --to=ckoenig.leichtzumerken@gmail.com \
    --cc=Emily.Deng@amd.com \
    --cc=Shaoyun.Liu@amd.com \
    --cc=Zhigang.Luo@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.