From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Qi Zhang <qi.z.zhang@intel.com>,
bruce.richardson@intel.com, keith.wiles@intel.com,
konstantin.ananyev@intel.com
Cc: dev@dpdk.org, wenzhuo.lu@intel.com, bernard.iremonger@intel.com
Subject: Re: [PATCH v2 1/3] app/testpmd: code refactory for macswap
Date: Tue, 11 Dec 2018 15:48:19 +0000 [thread overview]
Message-ID: <bf00424f-be24-76c6-09df-e474ea33639c@intel.com> (raw)
In-Reply-To: <20181211055511.32284-2-qi.z.zhang@intel.com>
On 12/11/2018 5:55 AM, Qi Zhang wrote:
> Move macswap workload to dedicate function, so we can further enable
> platform specific optimized version.
>
> Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
<...>
> +}
> +
> +#endif /* _BPF_CMD_H_ */
Comment is remaining from copy-pate, there are a few more in the patchset.
<...>
> +static inline uint64_t
> +ol_flags_init(uint64_t tx_offload)
> +{
> + uint64_t ol_flags = 0;
> +
> + ol_flags |= (tx_offload & DEV_TX_OFFLOAD_VLAN_INSERT) ?
> + PKT_TX_VLAN : 0;
> + ol_flags |= (tx_offload & DEV_TX_OFFLOAD_QINQ_INSERT) ?
> + PKT_TX_QINQ : 0;
> + ol_flags |= (tx_offload & DEV_TX_OFFLOAD_MACSEC_INSERT) ?
> + PKT_TX_MACSEC : 0;
> +
> + return ol_flags;
> +}
> +
> +static inline void
> +vlan_qinq_set(struct rte_mbuf *pkts[], uint16_t nb,
> + uint64_t ol_flags, uint16_t vlan, uint16_t outer_vlan)
> +{
> + int i;
> +
> + if (ol_flags & PKT_TX_VLAN)
> + for (i = 0; i < nb; i++)
> + pkts[i]->vlan_tci = vlan;
> + if (ol_flags & PKT_TX_QINQ)
> + for (i = 0; i < nb; i++)
> + pkts[i]->vlan_tci_outer = outer_vlan;
> +}
> +
> +static inline void
> +mbuf_field_set(struct rte_mbuf *mb, uint64_t ol_flags)
> +{
> + mb->ol_flags &= IND_ATTACHED_MBUF | EXT_ATTACHED_MBUF;
> + mb->ol_flags |= ol_flags;
> + mb->l2_len = sizeof(struct ether_hdr);
> + mb->l3_len = sizeof(struct ipv4_hdr);
'vlan_qinq_set()' goes through all packets in burst already, why not merge
'vlan_qinq_set' and 'mbuf_field_set' as before but only add 'ol_flags' checks?
next prev parent reply other threads:[~2018-12-11 15:48 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-22 17:26 [PATCH 0/3] improve MAC swap performance Qi Zhang
2018-11-22 17:26 ` [PATCH 1/3] app/testpmd: code refactory for macswap Qi Zhang
2018-11-22 17:26 ` [PATCH 2/3] app/testpmd: improve MAC swap performance for x86 Qi Zhang
2018-11-22 17:26 ` [PATCH 3/3] app/testpmd: further " Qi Zhang
2018-11-22 17:38 ` [PATCH v2 0/3] improve MAC swap performance Qi Zhang
2018-11-22 17:38 ` [PATCH v2 1/3] app/testpmd: code refactory for macswap Qi Zhang
2018-12-10 17:44 ` Ferruh Yigit
2018-12-11 4:02 ` Zhang, Qi Z
2018-11-22 17:38 ` [PATCH v2 2/3] app/testpmd: improve MAC swap performance for x86 Qi Zhang
2018-12-10 17:44 ` Ferruh Yigit
2018-11-22 17:38 ` [PATCH v2 3/3] app/testpmd: further " Qi Zhang
2018-12-11 5:55 ` [PATCH v2 0/3] improve MAC swap performance Qi Zhang
2018-12-11 5:55 ` [PATCH v2 1/3] app/testpmd: code refactory for macswap Qi Zhang
2018-12-11 15:48 ` Ferruh Yigit [this message]
2018-12-14 11:14 ` Iremonger, Bernard
2018-12-14 11:21 ` Zhang, Qi Z
2018-12-11 5:55 ` [PATCH v2 2/3] app/testpmd: improve MAC swap performance for x86 Qi Zhang
2018-12-13 19:50 ` [EXT] " Jerin Jacob Kollanukkaran
2018-12-14 11:21 ` Iremonger, Bernard
2018-12-14 11:36 ` Zhang, Qi Z
2018-12-11 5:55 ` [PATCH v2 3/3] app/testpmd: further " Qi Zhang
2018-12-16 0:58 ` [PATCH v3 0/3] improve MAC swap performance Qi Zhang
2018-12-16 0:58 ` [PATCH v3 1/3] app/testpmd: code refactory for macswap Qi Zhang
2018-12-18 11:06 ` Iremonger, Bernard
2018-12-16 0:58 ` [PATCH v3 2/3] app/testpmd: improve MAC swap performance for x86 Qi Zhang
2018-12-18 11:07 ` Iremonger, Bernard
2018-12-16 0:58 ` [PATCH v3 3/3] app/testpmd: further " Qi Zhang
2018-12-18 11:09 ` Iremonger, Bernard
2018-12-18 0:15 ` [PATCH v3 0/3] improve MAC swap performance Ferruh Yigit
2018-12-18 16:29 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bf00424f-be24-76c6-09df-e474ea33639c@intel.com \
--to=ferruh.yigit@intel.com \
--cc=bernard.iremonger@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=keith.wiles@intel.com \
--cc=konstantin.ananyev@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.