From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Varghese, Vipin" <vipin.varghese@intel.com>,
"Wiles, Keith" <keith.wiles@intel.com>
Cc: "pascal.mazon@6wind.com" <pascal.mazon@6wind.com>,
"Wang, Zhihong" <zhihong.wang@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [PATCH] net/tap: fix the vdev data sharing for tun
Date: Tue, 22 May 2018 10:50:46 +0100 [thread overview]
Message-ID: <bf0ba726-e894-3742-dd98-7780462e44fd@intel.com> (raw)
In-Reply-To: <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D1EB94C@BGSMSX101.gar.corp.intel.com>
On 5/15/2018 1:56 PM, Varghese, Vipin wrote:
> HI Keith,
>
> Thanks for the input, please find my answer inline to email therad
>
> <Snipped>
>
>>> + /* TODO: request info from primary to set up Rx and Tx */
>>
>> What is the rule (if we have one) about having TODO, FIXME, … like comments in
>> the code? Maybe remove the todo and create a enhancement request for later.
>>
>
> I am not aware of the 'To Do' planned. This came in as part of logic block from previous commit for all PMD to support Secondary
Specially when there is a work not planned for this, agreed to drop todo, can
you please send a new version without that note please?
>
> <Snipped>
>
>>
>> Regards,
>> Keith
>
next prev parent reply other threads:[~2018-05-22 9:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-12 6:37 [PATCH] net/tap: fix the vdev data sharing for tun Vipin Varghese
2018-05-15 12:35 ` Wiles, Keith
2018-05-15 12:56 ` Varghese, Vipin
2018-05-22 9:50 ` Ferruh Yigit [this message]
2018-05-22 11:01 ` [PATCH v2] " Vipin Varghese
2018-05-22 13:40 ` Wiles, Keith
2018-05-22 22:26 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bf0ba726-e894-3742-dd98-7780462e44fd@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=keith.wiles@intel.com \
--cc=pascal.mazon@6wind.com \
--cc=vipin.varghese@intel.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.