All of lore.kernel.org
 help / color / mirror / Atom feed
From: Trond Myklebust <trondmy@hammerspace.com>
To: "daire@dneg.com" <daire@dneg.com>,
	"chuck.lever@oracle.com" <chuck.lever@oracle.com>
Cc: "linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>,
	"bfields@redhat.com" <bfields@redhat.com>
Subject: Re: [PATCH] SUNRPC: Use TCP_CORK to optimise send performance on the server
Date: Sun, 14 Feb 2021 16:24:21 +0000	[thread overview]
Message-ID: <bf0d34e25ef39dd90ade63178b829da7c0c2452f.camel@hammerspace.com> (raw)
In-Reply-To: <285652682.9476664.1613312016960.JavaMail.zimbra@dneg.com>

On Sun, 2021-02-14 at 14:13 +0000, Daire Byrne wrote:
> 
> ----- On 13 Feb, 2021, at 23:30, Chuck Lever
> chuck.lever@oracle.com wrote:
> 
> > > I don't have a performance system to measure the improvement
> > > accurately.
> > 
> > Then let's have Daire try it out, if possible.
> 
> I'm happy to test it out on one of our 2 x 40G NFS servers with 100 x
> 1G clients (but it's trickier to patch the clients too atm).
> 
> Just so I'm clear, this is in addition to Chuck's "Handle TCP socket
> sends with kernel_sendpage() again" patch from bz #209439 (which I
> think is now in 5.11 rc)? Or you want to see what this patch looks
> like on it's own without that (e.g. v5.10)?
> 

This patch is independent of which socket mechanism we're using: it
should work with sendmsg(), sendpage(), and even writev(). So feel free
to test whichever combination makes most sense to you.

-- 
Trond Myklebust
Linux NFS client maintainer, Hammerspace
trond.myklebust@hammerspace.com



  reply	other threads:[~2021-02-14 16:25 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-13 20:25 [PATCH] SUNRPC: Use TCP_CORK to optimise send performance on the server trondmy
2021-02-13 21:53 ` Chuck Lever
2021-02-13 22:10   ` Trond Myklebust
2021-02-13 23:30     ` Chuck Lever
2021-02-14 14:13       ` Daire Byrne
2021-02-14 16:24         ` Trond Myklebust [this message]
2021-02-14 16:59         ` Chuck Lever
2021-02-15 14:08           ` Daire Byrne
2021-02-15 18:22             ` Chuck Lever
2021-02-14 16:21       ` Trond Myklebust
2021-02-14 17:27         ` Chuck Lever
2021-02-14 17:41           ` Trond Myklebust
2021-02-14 17:58             ` Chuck Lever
2021-02-14 18:18               ` Trond Myklebust
2021-02-14 19:43                 ` Chuck Lever
2021-02-16 16:27 ` Chuck Lever
2021-02-16 17:10   ` Trond Myklebust
2021-02-16 17:12     ` Chuck Lever

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bf0d34e25ef39dd90ade63178b829da7c0c2452f.camel@hammerspace.com \
    --to=trondmy@hammerspace.com \
    --cc=bfields@redhat.com \
    --cc=chuck.lever@oracle.com \
    --cc=daire@dneg.com \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.