From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84780C43603 for ; Tue, 10 Dec 2019 07:15:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6046E20663 for ; Tue, 10 Dec 2019 07:15:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727143AbfLJHPZ (ORCPT ); Tue, 10 Dec 2019 02:15:25 -0500 Received: from mx2.suse.de ([195.135.220.15]:49468 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727137AbfLJHPZ (ORCPT ); Tue, 10 Dec 2019 02:15:25 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 66DA6AC9A; Tue, 10 Dec 2019 07:15:23 +0000 (UTC) Subject: Re: [PATCH] xen/blkfront: Adjust indentation in xlvbd_alloc_gendisk To: Nathan Chancellor , Boris Ostrovsky , Konrad Rzeszutek Wilk , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Jens Axboe Cc: Stefano Stabellini , xen-devel@lists.xenproject.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com References: <20191209201444.33243-1-natechancellor@gmail.com> From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Message-ID: Date: Tue, 10 Dec 2019 08:15:22 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.1 MIME-Version: 1.0 In-Reply-To: <20191209201444.33243-1-natechancellor@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On 09.12.19 21:14, Nathan Chancellor wrote: > Clang warns: > > ../drivers/block/xen-blkfront.c:1117:4: warning: misleading indentation; > statement is not part of the previous 'if' [-Wmisleading-indentation] > nr_parts = PARTS_PER_DISK; > ^ > ../drivers/block/xen-blkfront.c:1115:3: note: previous statement is here > if (err) > ^ > > This is because there is a space at the beginning of this line; remove > it so that the indentation is consistent according to the Linux kernel > coding style and clang no longer warns. > > While we are here, the previous line has some trailing whitespace; clean > that up as well. > > Fixes: c80a420995e7 ("xen-blkfront: handle Xen major numbers other than XENVBD") > Link: https://github.com/ClangBuiltLinux/linux/issues/791 > Signed-off-by: Nathan Chancellor Reviewed-by: Juergen Gross Juergen From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A922C43603 for ; Tue, 10 Dec 2019 07:15:52 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 61F8720663 for ; Tue, 10 Dec 2019 07:15:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 61F8720663 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1ieZjy-0005qP-MV; Tue, 10 Dec 2019 07:15:26 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1ieZjw-0005ps-U2 for xen-devel@lists.xenproject.org; Tue, 10 Dec 2019 07:15:24 +0000 X-Inumbo-ID: d5452d76-1b1c-11ea-88fa-12813bfff9fa Received: from mx1.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id d5452d76-1b1c-11ea-88fa-12813bfff9fa; Tue, 10 Dec 2019 07:15:24 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 66DA6AC9A; Tue, 10 Dec 2019 07:15:23 +0000 (UTC) To: Nathan Chancellor , Boris Ostrovsky , Konrad Rzeszutek Wilk , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Jens Axboe References: <20191209201444.33243-1-natechancellor@gmail.com> From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Message-ID: Date: Tue, 10 Dec 2019 08:15:22 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.1 MIME-Version: 1.0 In-Reply-To: <20191209201444.33243-1-natechancellor@gmail.com> Content-Language: en-US Subject: Re: [Xen-devel] [PATCH] xen/blkfront: Adjust indentation in xlvbd_alloc_gendisk X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: linux-block@vger.kernel.org, xen-devel@lists.xenproject.org, clang-built-linux@googlegroups.com, linux-kernel@vger.kernel.org, Stefano Stabellini Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" T24gMDkuMTIuMTkgMjE6MTQsIE5hdGhhbiBDaGFuY2VsbG9yIHdyb3RlOgo+IENsYW5nIHdhcm5z Ogo+IAo+IC4uL2RyaXZlcnMvYmxvY2sveGVuLWJsa2Zyb250LmM6MTExNzo0OiB3YXJuaW5nOiBt aXNsZWFkaW5nIGluZGVudGF0aW9uOwo+IHN0YXRlbWVudCBpcyBub3QgcGFydCBvZiB0aGUgcHJl dmlvdXMgJ2lmJyBbLVdtaXNsZWFkaW5nLWluZGVudGF0aW9uXQo+ICAgICAgICAgICAgICAgICAg bnJfcGFydHMgPSBQQVJUU19QRVJfRElTSzsKPiAgICAgICAgICAgICAgICAgIF4KPiAuLi9kcml2 ZXJzL2Jsb2NrL3hlbi1ibGtmcm9udC5jOjExMTU6Mzogbm90ZTogcHJldmlvdXMgc3RhdGVtZW50 IGlzIGhlcmUKPiAgICAgICAgICAgICAgICAgIGlmIChlcnIpCj4gICAgICAgICAgICAgICAgICBe Cj4gCj4gVGhpcyBpcyBiZWNhdXNlIHRoZXJlIGlzIGEgc3BhY2UgYXQgdGhlIGJlZ2lubmluZyBv ZiB0aGlzIGxpbmU7IHJlbW92ZQo+IGl0IHNvIHRoYXQgdGhlIGluZGVudGF0aW9uIGlzIGNvbnNp c3RlbnQgYWNjb3JkaW5nIHRvIHRoZSBMaW51eCBrZXJuZWwKPiBjb2Rpbmcgc3R5bGUgYW5kIGNs YW5nIG5vIGxvbmdlciB3YXJucy4KPiAKPiBXaGlsZSB3ZSBhcmUgaGVyZSwgdGhlIHByZXZpb3Vz IGxpbmUgaGFzIHNvbWUgdHJhaWxpbmcgd2hpdGVzcGFjZTsgY2xlYW4KPiB0aGF0IHVwIGFzIHdl bGwuCj4gCj4gRml4ZXM6IGM4MGE0MjA5OTVlNyAoInhlbi1ibGtmcm9udDogaGFuZGxlIFhlbiBt YWpvciBudW1iZXJzIG90aGVyIHRoYW4gWEVOVkJEIikKPiBMaW5rOiBodHRwczovL2dpdGh1Yi5j b20vQ2xhbmdCdWlsdExpbnV4L2xpbnV4L2lzc3Vlcy83OTEKPiBTaWduZWQtb2ZmLWJ5OiBOYXRo YW4gQ2hhbmNlbGxvciA8bmF0ZWNoYW5jZWxsb3JAZ21haWwuY29tPgoKUmV2aWV3ZWQtYnk6IEp1 ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT4KCgpKdWVyZ2VuCgpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpYZW4tZGV2ZWwgbWFpbGluZyBsaXN0Clhl bi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZwpodHRwczovL2xpc3RzLnhlbnByb2plY3Qub3Jn L21haWxtYW4vbGlzdGluZm8veGVuLWRldmVs