From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89325C49361 for ; Sat, 19 Jun 2021 13:07:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 708ED6113E for ; Sat, 19 Jun 2021 13:07:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234279AbhFSNJN (ORCPT ); Sat, 19 Jun 2021 09:09:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34624 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234109AbhFSNJM (ORCPT ); Sat, 19 Jun 2021 09:09:12 -0400 Received: from puleglot.ru (puleglot.ru [IPv6:2a01:4f8:1c0c:58e8::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1E4D0C061574; Sat, 19 Jun 2021 06:07:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tsoy.me; s=mymail; h=Sender:Content-Transfer-Encoding:MIME-Version:Content-Type: References:In-Reply-To:Date:Cc:To:From:Subject:Message-ID:Reply-To:Content-ID :Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To: Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe :List-Post:List-Owner:List-Archive; bh=OsnWsRjwnHPvLI6iAW6jBpN6mbJOj8Z4vbPIXcuZ2g8=; b=UqnuNDzUWHD7usUJe33RmQSv/Q ZgqHAxd9IcFaXlM8Z7Wu9fKhivX/F3SKNy1L2a/aKHfy9mNfwwRSArzvDGVWo8eLjRhjH8yFGkU9R 9NEFtK4+9AtdKg+ILurevpelURhELJ18uEHGLZe1JRckVaP2QR64MSLn77gt4dO+V0jc=; Received: from [2a00:1370:8125:af50::b41] by puleglot.ru with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1luagX-0003Vu-PK; Sat, 19 Jun 2021 16:06:53 +0300 Message-ID: Subject: Re: [PATCH 5.10 35/38] rtnetlink: Fix missing error code in rtnl_bridge_notify() From: Alexander Tsoy To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Abaci Robot , Jiapeng Chong , "David S. Miller" , Sasha Levin Date: Sat, 19 Jun 2021 16:06:50 +0300 In-Reply-To: References: <20210616152835.407925718@linuxfoundation.org> <20210616152836.507544876@linuxfoundation.org> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.40.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: puleglot@puleglot.ru Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org В Сб, 19/06/2021 в 08:45 +0200, Greg Kroah-Hartman пишет: > On Sat, Jun 19, 2021 at 02:58:28AM +0300, Alexander Tsoy wrote: > > В Ср, 16/06/2021 в 17:33 +0200, Greg Kroah-Hartman пишет: > > > From: Jiapeng Chong > > > > > > [ Upstream commit a8db57c1d285c758adc7fb43d6e2bad2554106e1 ] > > > > > > The error code is missing in this code scenario, add the error code > > > '-EINVAL' to the return value 'err'. > > > > > > Eliminate the follow smatch warning: > > > > > > net/core/rtnetlink.c:4834 rtnl_bridge_notify() warn: missing error > > > code > > > 'err'. > > > > This patch breaks systemd-resolved. It is 100% reproducible on two of > > my systems, but there are also systems where I cannot reproduce it. > > The > > problem manifests itself as SERVFAIL on every DNS query. > > > > Just reverting this patch from 5.10.45 fixes the problem for me. > > Is Linus's tree also broken for you?  It should be reverted there > first. Looks like this patch was reverted in Linus's tree: d2e381c4963663bca6f30c3b996fa4dbafe8fcb5 (rtnetlink: Fix regression in bridge VLAN configuration) Also after some investigation I think my problem was actually with NetworkManager as systemd-networkd + systemd-resolved works fine. $ grep ^dns /etc/NetworkManager/NetworkManager.conf dns=systemd-resolved with this patch: $ resolvectl ... Link 4 (eno1) Current Scopes: none Protocols: +DefaultRoute +LLMNR -mDNS -DNSOverTLS DNSSEC=no/unsupported DNS Servers: 192.168.1.1 fd9f:5696:250c::1 DNS Domain: lan with this patch reverted: $ resolvectl ... Link 4 (eno1) Current Scopes: DNS LLMNR/IPv4 LLMNR/IPv6 Protocols: +DefaultRoute +LLMNR -mDNS -DNSOverTLS DNSSEC=no/unsupported Current DNS Server: 192.168.1.1 DNS Servers: 192.168.1.1 fd9f:5696:250c::1 DNS Domain: lan