From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66A80C388F2 for ; Fri, 6 Nov 2020 19:17:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 06B1A2151B for ; Fri, 6 Nov 2020 19:17:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="R23kxW5f" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728106AbgKFTRb (ORCPT ); Fri, 6 Nov 2020 14:17:31 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:37841 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728070AbgKFTRb (ORCPT ); Fri, 6 Nov 2020 14:17:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1604690249; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eIrgu+Zyfi99z5T1RDNmY/iinJQcbzFcfmaOeQwzR0w=; b=R23kxW5f1eAYygLr59mkGwNhV3aKIQs9zz8Ntb6UwolUicaPe0/3zDnGzjHkFkbmnBYcLX 54oapzSn0MvtoFBiqoRupMnSs7wLAax0nSMlS0gM4ClRNdNN5B4DRKbTea2pY6ysF3rhp7 9Sy2vi99cjf2NQEmblbisAuT0XWEIgU= Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-254-N7F8JmraON2jvBcdfRU-Qw-1; Fri, 06 Nov 2020 14:17:27 -0500 X-MC-Unique: N7F8JmraON2jvBcdfRU-Qw-1 Received: by mail-qt1-f198.google.com with SMTP id i20so1623018qtr.0 for ; Fri, 06 Nov 2020 11:17:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:reply-to:to:cc:date :in-reply-to:references:organization:user-agent:mime-version :content-transfer-encoding; bh=eIrgu+Zyfi99z5T1RDNmY/iinJQcbzFcfmaOeQwzR0w=; b=oQijgUUBBy0OLLJzRV8eQXbGIlOWcpI3kyYrJ9EX7Q8DCMaFKyAmMSqzRnUhZYWBsd JKddF54V8pDbLQnTLdX8kfAlixexnFN7y4e30cVW6vC4WVEnlD54CqdqPaCgEJuZoEym 0RtuFdXSJcU9+oplNtD2c74RnDGztnRLat2q06oZ7fSLs0lbYRq7LbbKG+DkBwrBgpCk h4xOvh9Z23TWagFFinXJN+Ud0Yujn2oTqNVNJ8yRUpxomjsz1lEPtMJXKCsaSRfKnAT0 KOd7rSCpWtO7sMGXTyVVWwii8I0Q+CsEqeaPNkz0pnWLqV/x4/sGjWwVDCF7mrOa0zSl 97wg== X-Gm-Message-State: AOAM5312Avuu1Nl4f5GdmXcyOGnKtm5MpNr5yrYIMlvcHN4FS8F6A9Fi fb+Pve+jIl1EcR8Q2Awbs4eX5yhyN9FotdNDfwFwuvdRyDHxz7brkfPL7e9vxRpDoDbb5f55F3Z +Zqt+Pjwppgj5kmtnOEDUeycS X-Received: by 2002:a0c:84c1:: with SMTP id m59mr3080547qva.0.1604690247187; Fri, 06 Nov 2020 11:17:27 -0800 (PST) X-Google-Smtp-Source: ABdhPJz0Tp1ae2fEu/BtdbdNT13KKCZ7ePgv4+WNb1yd6T2gltfK4e8cslY/HKALsQAKJ93xDWTV2Q== X-Received: by 2002:a0c:84c1:: with SMTP id m59mr3080531qva.0.1604690246966; Fri, 06 Nov 2020 11:17:26 -0800 (PST) Received: from Whitewolf.lyude.net (pool-108-49-102-102.bstnma.fios.verizon.net. [108.49.102.102]) by smtp.gmail.com with ESMTPSA id u24sm1163603qtb.33.2020.11.06.11.17.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Nov 2020 11:17:26 -0800 (PST) Message-ID: Subject: Re: [PATCH 14/19] gpu: drm: selftests: test-drm_dp_mst_helper: Place 'struct drm_dp_sideband_msg_req_body' onto the heap From: Lyude Paul Reply-To: lyude@redhat.com To: Lee Jones Cc: linux-kernel@vger.kernel.org, David Airlie , Daniel Vetter , David Francis , dri-devel@lists.freedesktop.org Date: Fri, 06 Nov 2020 14:17:25 -0500 In-Reply-To: <20201105144517.1826692-15-lee.jones@linaro.org> References: <20201105144517.1826692-1-lee.jones@linaro.org> <20201105144517.1826692-15-lee.jones@linaro.org> Organization: Red Hat Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.38.1 (3.38.1-1.fc33) MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2020-11-05 at 14:45 +0000, Lee Jones wrote: > The stack is too full. > > Fixes the following W=1 kernel build warning(s): > >  drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c: In function > ‘sideband_msg_req_encode_decode’: >  drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c:161:1: warning: the frame > size of 1176 bytes is larger than 1024 bytes [-Wframe-larger-than=] > > Cc: David Airlie > Cc: Daniel Vetter > Cc: Lyude Paul > Cc: David Francis > Cc: dri-devel@lists.freedesktop.org > Signed-off-by: Lee Jones > --- >  .../drm/selftests/test-drm_dp_mst_helper.c    | 29 ++++++++++++------- >  1 file changed, 18 insertions(+), 11 deletions(-) > > diff --git a/drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c > b/drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c > index 1d696ec001cff..0a539456f6864 100644 > --- a/drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c > +++ b/drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c > @@ -120,44 +120,51 @@ sideband_msg_req_equal(const struct > drm_dp_sideband_msg_req_body *in, >  static bool >  sideband_msg_req_encode_decode(struct drm_dp_sideband_msg_req_body *in) >  { > -       struct drm_dp_sideband_msg_req_body out = {0}; > +       struct drm_dp_sideband_msg_req_body *out; >         struct drm_printer p = drm_err_printer(PREFIX_STR); >         struct drm_dp_sideband_msg_tx txmsg; >         int i, ret; > +       bool result = true; > + > +       out = kzalloc(sizeof(*out), GFP_KERNEL); > You're missing a NULL check here >   >         drm_dp_encode_sideband_req(in, &txmsg); > -       ret = drm_dp_decode_sideband_req(&txmsg, &out); > +       ret = drm_dp_decode_sideband_req(&txmsg, out); >         if (ret < 0) { >                 drm_printf(&p, "Failed to decode sideband request: %d\n", >                            ret); > -               return false; > +               result = false; > +               goto out; >         } >   > -       if (!sideband_msg_req_equal(in, &out)) { > +       if (!sideband_msg_req_equal(in, out)) { >                 drm_printf(&p, "Encode/decode failed, expected:\n"); >                 drm_dp_dump_sideband_msg_req_body(in, 1, &p); >                 drm_printf(&p, "Got:\n"); > -               drm_dp_dump_sideband_msg_req_body(&out, 1, &p); > -               return false; > +               drm_dp_dump_sideband_msg_req_body(out, 1, &p); > +               result = false; > +               goto out; >         } >   >         switch (in->req_type) { >         case DP_REMOTE_DPCD_WRITE: > -               kfree(out.u.dpcd_write.bytes); > +               kfree(out->u.dpcd_write.bytes); >                 break; >         case DP_REMOTE_I2C_READ: > -               for (i = 0; i < out.u.i2c_read.num_transactions; i++) > -                       kfree(out.u.i2c_read.transactions[i].bytes); > +               for (i = 0; i < out->u.i2c_read.num_transactions; i++) > +                       kfree(out->u.i2c_read.transactions[i].bytes); >                 break; >         case DP_REMOTE_I2C_WRITE: > -               kfree(out.u.i2c_write.bytes); > +               kfree(out->u.i2c_write.bytes); >                 break; >         } >   >         /* Clear everything but the req_type for the input */ >         memset(&in->u, 0, sizeof(in->u)); >   > -       return true; > +out: > +       kfree(out); > +       return result; >  } >   >  int igt_dp_mst_sideband_msg_req_decode(void *unused) -- Sincerely, Lyude Paul (she/her) Software Engineer at Red Hat Note: I deal with a lot of emails and have a lot of bugs on my plate. If you've asked me a question, are waiting for a review/merge on a patch, etc. and I haven't responded in a while, please feel free to send me another email to check on my status. I don't bite! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 741D5C2D0A3 for ; Fri, 6 Nov 2020 19:17:32 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F08472151B for ; Fri, 6 Nov 2020 19:17:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="R23kxW5f" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F08472151B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2CF2F6EB03; Fri, 6 Nov 2020 19:17:31 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id 662326EB03 for ; Fri, 6 Nov 2020 19:17:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1604690249; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eIrgu+Zyfi99z5T1RDNmY/iinJQcbzFcfmaOeQwzR0w=; b=R23kxW5f1eAYygLr59mkGwNhV3aKIQs9zz8Ntb6UwolUicaPe0/3zDnGzjHkFkbmnBYcLX 54oapzSn0MvtoFBiqoRupMnSs7wLAax0nSMlS0gM4ClRNdNN5B4DRKbTea2pY6ysF3rhp7 9Sy2vi99cjf2NQEmblbisAuT0XWEIgU= Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-375-9EFYX521OhOUNYvJODMt2A-1; Fri, 06 Nov 2020 14:17:27 -0500 X-MC-Unique: 9EFYX521OhOUNYvJODMt2A-1 Received: by mail-qt1-f200.google.com with SMTP id l67so1601879qte.6 for ; Fri, 06 Nov 2020 11:17:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:reply-to:to:cc:date :in-reply-to:references:organization:user-agent:mime-version :content-transfer-encoding; bh=eIrgu+Zyfi99z5T1RDNmY/iinJQcbzFcfmaOeQwzR0w=; b=ac+VdZyzVC00GmMneRmYhzMr0DLDnFVa0TLRM4HVnuZ5cWFMuaB8T7LOeP447c1G1X f2PztT7lMC68Qt8kJvBbMSKW+bSMYAgC+euIozzIh7qSVa1nzTdU72oZCVo+1o+HYw8D csVofunFXxOwrs6jOAiJ1xs0hm9cTHh0NU+dJye5csv5flLBv0YkIYUGGFwBBP35t+jq FEJ8e3Liw9IE1JbEGOaNwUe45OgLSvqDg+gu5IgRS9n579VlBa0c+EVhBjidLk1bOxfB BjRPiAY7GHu7Jr/Tvg0hUbns2ja/w+rruk1eipySnBAKdfDX2nCORpxxtKA8MkMGMDiY 0CZw== X-Gm-Message-State: AOAM533M1lAwvt1Mo5wmq3vK2wBE8AjGctK6l2EZgw+RRwTvg60l/nCQ JbZoD2aICLqMANQSsz2efNk9pe7/kqRv4vwZgysszHBrPOoeARIZyZK4b582wNuKsvAfPlzVkbc +F5e4NZaY8C3C9Wd1rMr+mO912SFE X-Received: by 2002:a0c:84c1:: with SMTP id m59mr3080546qva.0.1604690247187; Fri, 06 Nov 2020 11:17:27 -0800 (PST) X-Google-Smtp-Source: ABdhPJz0Tp1ae2fEu/BtdbdNT13KKCZ7ePgv4+WNb1yd6T2gltfK4e8cslY/HKALsQAKJ93xDWTV2Q== X-Received: by 2002:a0c:84c1:: with SMTP id m59mr3080531qva.0.1604690246966; Fri, 06 Nov 2020 11:17:26 -0800 (PST) Received: from Whitewolf.lyude.net (pool-108-49-102-102.bstnma.fios.verizon.net. [108.49.102.102]) by smtp.gmail.com with ESMTPSA id u24sm1163603qtb.33.2020.11.06.11.17.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Nov 2020 11:17:26 -0800 (PST) Message-ID: Subject: Re: [PATCH 14/19] gpu: drm: selftests: test-drm_dp_mst_helper: Place 'struct drm_dp_sideband_msg_req_body' onto the heap From: Lyude Paul To: Lee Jones Date: Fri, 06 Nov 2020 14:17:25 -0500 In-Reply-To: <20201105144517.1826692-15-lee.jones@linaro.org> References: <20201105144517.1826692-1-lee.jones@linaro.org> <20201105144517.1826692-15-lee.jones@linaro.org> Organization: Red Hat User-Agent: Evolution 3.38.1 (3.38.1-1.fc33) MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lyude@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: lyude@redhat.com Cc: David Airlie , David Francis , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gVGh1LCAyMDIwLTExLTA1IGF0IDE0OjQ1ICswMDAwLCBMZWUgSm9uZXMgd3JvdGU6Cj4gVGhl IHN0YWNrIGlzIHRvbyBmdWxsLgo+IAo+IEZpeGVzIHRoZSBmb2xsb3dpbmcgVz0xIGtlcm5lbCBi dWlsZCB3YXJuaW5nKHMpOgo+IAo+IMKgZHJpdmVycy9ncHUvZHJtL3NlbGZ0ZXN0cy90ZXN0LWRy bV9kcF9tc3RfaGVscGVyLmM6IEluIGZ1bmN0aW9uCj4g4oCYc2lkZWJhbmRfbXNnX3JlcV9lbmNv ZGVfZGVjb2Rl4oCZOgo+IMKgZHJpdmVycy9ncHUvZHJtL3NlbGZ0ZXN0cy90ZXN0LWRybV9kcF9t c3RfaGVscGVyLmM6MTYxOjE6IHdhcm5pbmc6IHRoZSBmcmFtZQo+IHNpemUgb2YgMTE3NiBieXRl cyBpcyBsYXJnZXIgdGhhbiAxMDI0IGJ5dGVzIFstV2ZyYW1lLWxhcmdlci10aGFuPV0KPiAKPiBD YzogRGF2aWQgQWlybGllIDxhaXJsaWVkQGxpbnV4LmllPgo+IENjOiBEYW5pZWwgVmV0dGVyIDxk YW5pZWxAZmZ3bGwuY2g+Cj4gQ2M6IEx5dWRlIFBhdWwgPGx5dWRlQHJlZGhhdC5jb20+Cj4gQ2M6 IERhdmlkIEZyYW5jaXMgPERhdmlkLkZyYW5jaXNAYW1kLmNvbT4KPiBDYzogZHJpLWRldmVsQGxp c3RzLmZyZWVkZXNrdG9wLm9yZwo+IFNpZ25lZC1vZmYtYnk6IExlZSBKb25lcyA8bGVlLmpvbmVz QGxpbmFyby5vcmc+Cj4gLS0tCj4gwqAuLi4vZHJtL3NlbGZ0ZXN0cy90ZXN0LWRybV9kcF9tc3Rf aGVscGVyLmPCoMKgwqAgfCAyOSArKysrKysrKysrKystLS0tLS0tCj4gwqAxIGZpbGUgY2hhbmdl ZCwgMTggaW5zZXJ0aW9ucygrKSwgMTEgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2Ry aXZlcnMvZ3B1L2RybS9zZWxmdGVzdHMvdGVzdC1kcm1fZHBfbXN0X2hlbHBlci5jCj4gYi9kcml2 ZXJzL2dwdS9kcm0vc2VsZnRlc3RzL3Rlc3QtZHJtX2RwX21zdF9oZWxwZXIuYwo+IGluZGV4IDFk Njk2ZWMwMDFjZmYuLjBhNTM5NDU2ZjY4NjQgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJt L3NlbGZ0ZXN0cy90ZXN0LWRybV9kcF9tc3RfaGVscGVyLmMKPiArKysgYi9kcml2ZXJzL2dwdS9k cm0vc2VsZnRlc3RzL3Rlc3QtZHJtX2RwX21zdF9oZWxwZXIuYwo+IEBAIC0xMjAsNDQgKzEyMCw1 MSBAQCBzaWRlYmFuZF9tc2dfcmVxX2VxdWFsKGNvbnN0IHN0cnVjdAo+IGRybV9kcF9zaWRlYmFu ZF9tc2dfcmVxX2JvZHkgKmluLAo+IMKgc3RhdGljIGJvb2wKPiDCoHNpZGViYW5kX21zZ19yZXFf ZW5jb2RlX2RlY29kZShzdHJ1Y3QgZHJtX2RwX3NpZGViYW5kX21zZ19yZXFfYm9keSAqaW4pCj4g wqB7Cj4gLcKgwqDCoMKgwqDCoMKgc3RydWN0IGRybV9kcF9zaWRlYmFuZF9tc2dfcmVxX2JvZHkg b3V0ID0gezB9Owo+ICvCoMKgwqDCoMKgwqDCoHN0cnVjdCBkcm1fZHBfc2lkZWJhbmRfbXNnX3Jl cV9ib2R5ICpvdXQ7Cj4gwqDCoMKgwqDCoMKgwqDCoHN0cnVjdCBkcm1fcHJpbnRlciBwID0gZHJt X2Vycl9wcmludGVyKFBSRUZJWF9TVFIpOwo+IMKgwqDCoMKgwqDCoMKgwqBzdHJ1Y3QgZHJtX2Rw X3NpZGViYW5kX21zZ190eCB0eG1zZzsKPiDCoMKgwqDCoMKgwqDCoMKgaW50IGksIHJldDsKPiAr wqDCoMKgwqDCoMKgwqBib29sIHJlc3VsdCA9IHRydWU7Cj4gKwo+ICvCoMKgwqDCoMKgwqDCoG91 dCA9IGt6YWxsb2Moc2l6ZW9mKCpvdXQpLCBHRlBfS0VSTkVMKTsKPiAKCllvdSdyZSBtaXNzaW5n IGEgTlVMTCBjaGVjayBoZXJlCgo+IMKgCj4gwqDCoMKgwqDCoMKgwqDCoGRybV9kcF9lbmNvZGVf c2lkZWJhbmRfcmVxKGluLCAmdHhtc2cpOwo+IC3CoMKgwqDCoMKgwqDCoHJldCA9IGRybV9kcF9k ZWNvZGVfc2lkZWJhbmRfcmVxKCZ0eG1zZywgJm91dCk7Cj4gK8KgwqDCoMKgwqDCoMKgcmV0ID0g ZHJtX2RwX2RlY29kZV9zaWRlYmFuZF9yZXEoJnR4bXNnLCBvdXQpOwo+IMKgwqDCoMKgwqDCoMKg wqBpZiAocmV0IDwgMCkgewo+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgZHJtX3By aW50ZigmcCwgIkZhaWxlZCB0byBkZWNvZGUgc2lkZWJhbmQgcmVxdWVzdDogJWRcbiIsCj4gwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCByZXQpOwo+ IC3CoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqByZXR1cm4gZmFsc2U7Cj4gK8KgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoHJlc3VsdCA9IGZhbHNlOwo+ICvCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqBnb3RvIG91dDsKPiDCoMKgwqDCoMKgwqDCoMKgfQo+IMKgCj4gLcKgwqDC oMKgwqDCoMKgaWYgKCFzaWRlYmFuZF9tc2dfcmVxX2VxdWFsKGluLCAmb3V0KSkgewo+ICvCoMKg wqDCoMKgwqDCoGlmICghc2lkZWJhbmRfbXNnX3JlcV9lcXVhbChpbiwgb3V0KSkgewo+IMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgZHJtX3ByaW50ZigmcCwgIkVuY29kZS9kZWNvZGUg ZmFpbGVkLCBleHBlY3RlZDpcbiIpOwo+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg ZHJtX2RwX2R1bXBfc2lkZWJhbmRfbXNnX3JlcV9ib2R5KGluLCAxLCAmcCk7Cj4gwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqBkcm1fcHJpbnRmKCZwLCAiR290OlxuIik7Cj4gLcKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoGRybV9kcF9kdW1wX3NpZGViYW5kX21zZ19yZXFfYm9k eSgmb3V0LCAxLCAmcCk7Cj4gLcKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoHJldHVybiBm YWxzZTsKPiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgZHJtX2RwX2R1bXBfc2lkZWJh bmRfbXNnX3JlcV9ib2R5KG91dCwgMSwgJnApOwo+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqByZXN1bHQgPSBmYWxzZTsKPiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgZ290 byBvdXQ7Cj4gwqDCoMKgwqDCoMKgwqDCoH0KPiDCoAo+IMKgwqDCoMKgwqDCoMKgwqBzd2l0Y2gg KGluLT5yZXFfdHlwZSkgewo+IMKgwqDCoMKgwqDCoMKgwqBjYXNlIERQX1JFTU9URV9EUENEX1dS SVRFOgo+IC3CoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqBrZnJlZShvdXQudS5kcGNkX3dy aXRlLmJ5dGVzKTsKPiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKga2ZyZWUob3V0LT51 LmRwY2Rfd3JpdGUuYnl0ZXMpOwo+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgYnJl YWs7Cj4gwqDCoMKgwqDCoMKgwqDCoGNhc2UgRFBfUkVNT1RFX0kyQ19SRUFEOgo+IC3CoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqBmb3IgKGkgPSAwOyBpIDwgb3V0LnUuaTJjX3JlYWQubnVt X3RyYW5zYWN0aW9uczsgaSsrKQo+IC3CoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKga2ZyZWUob3V0LnUuaTJjX3JlYWQudHJhbnNhY3Rpb25zW2ldLmJ5dGVzKTsK PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgZm9yIChpID0gMDsgaSA8IG91dC0+dS5p MmNfcmVhZC5udW1fdHJhbnNhY3Rpb25zOyBpKyspCj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqBrZnJlZShvdXQtPnUuaTJjX3JlYWQudHJhbnNhY3Rpb25z W2ldLmJ5dGVzKTsKPiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoGJyZWFrOwo+IMKg wqDCoMKgwqDCoMKgwqBjYXNlIERQX1JFTU9URV9JMkNfV1JJVEU6Cj4gLcKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoGtmcmVlKG91dC51LmkyY193cml0ZS5ieXRlcyk7Cj4gK8KgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoGtmcmVlKG91dC0+dS5pMmNfd3JpdGUuYnl0ZXMpOwo+IMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgYnJlYWs7Cj4gwqDCoMKgwqDCoMKgwqDCoH0K PiDCoAo+IMKgwqDCoMKgwqDCoMKgwqAvKiBDbGVhciBldmVyeXRoaW5nIGJ1dCB0aGUgcmVxX3R5 cGUgZm9yIHRoZSBpbnB1dCAqLwo+IMKgwqDCoMKgwqDCoMKgwqBtZW1zZXQoJmluLT51LCAwLCBz aXplb2YoaW4tPnUpKTsKPiDCoAo+IC3CoMKgwqDCoMKgwqDCoHJldHVybiB0cnVlOwo+ICtvdXQ6 Cj4gK8KgwqDCoMKgwqDCoMKga2ZyZWUob3V0KTsKPiArwqDCoMKgwqDCoMKgwqByZXR1cm4gcmVz dWx0Owo+IMKgfQo+IMKgCj4gwqBpbnQgaWd0X2RwX21zdF9zaWRlYmFuZF9tc2dfcmVxX2RlY29k ZSh2b2lkICp1bnVzZWQpCgotLSAKU2luY2VyZWx5LAogICBMeXVkZSBQYXVsIChzaGUvaGVyKQog ICBTb2Z0d2FyZSBFbmdpbmVlciBhdCBSZWQgSGF0CiAgIApOb3RlOiBJIGRlYWwgd2l0aCBhIGxv dCBvZiBlbWFpbHMgYW5kIGhhdmUgYSBsb3Qgb2YgYnVncyBvbiBteSBwbGF0ZS4gSWYgeW91J3Zl CmFza2VkIG1lIGEgcXVlc3Rpb24sIGFyZSB3YWl0aW5nIGZvciBhIHJldmlldy9tZXJnZSBvbiBh IHBhdGNoLCBldGMuIGFuZCBJCmhhdmVuJ3QgcmVzcG9uZGVkIGluIGEgd2hpbGUsIHBsZWFzZSBm ZWVsIGZyZWUgdG8gc2VuZCBtZSBhbm90aGVyIGVtYWlsIHRvIGNoZWNrCm9uIG15IHN0YXR1cy4g SSBkb24ndCBiaXRlIQoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Au b3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRl dmVsCg==