* [linux-next:master 6351/6976] drivers/scsi/qedi/qedi_fw.c:1039:45: sparse: sparse: incorrect type in assignment (different base types)
@ 2021-06-03 17:10 ` kernel test robot
0 siblings, 0 replies; 6+ messages in thread
From: kernel test robot @ 2021-06-03 17:10 UTC (permalink / raw)
To: Mike Christie
Cc: kbuild-all, Linux Memory Management List, Martin K. Petersen,
Manish Rangankar
[-- Attachment #1: Type: text/plain, Size: 23388 bytes --]
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: 3ebdbe7aa5dd825d609c3433c35c13b440a61c52
commit: ed1b86ba0fba3d586cd53057551a95197b0a37ad [6351/6976] scsi: qedi: Wake up if cmd_cleanup_req is set
config: arc-allyesconfig (attached as .config)
compiler: arceb-elf-gcc (GCC) 9.3.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# apt-get install sparse
# sparse version: v0.6.3-341-g8af24329-dirty
# https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=ed1b86ba0fba3d586cd53057551a95197b0a37ad
git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
git fetch --no-tags linux-next master
git checkout ed1b86ba0fba3d586cd53057551a95197b0a37ad
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' W=1 ARCH=arc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
sparse warnings: (new ones prefixed by >>)
drivers/scsi/qedi/qedi_fw.c:285:29: sparse: sparse: restricted __le16 degrades to integer
drivers/scsi/qedi/qedi_fw.c:287:28: sparse: sparse: incorrect type in assignment (different base types) @@ expected restricted __be16 [usertype] tsih @@ got restricted __le16 [usertype] tsih @@
drivers/scsi/qedi/qedi_fw.c:287:28: sparse: expected restricted __be16 [usertype] tsih
drivers/scsi/qedi/qedi_fw.c:287:28: sparse: got restricted __le16 [usertype] tsih
drivers/scsi/qedi/qedi_fw.c:288:32: sparse: sparse: cast from restricted __le32
drivers/scsi/qedi/qedi_fw.c:289:35: sparse: sparse: cast from restricted __le32
drivers/scsi/qedi/qedi_fw.c:290:35: sparse: sparse: cast from restricted __le32
drivers/scsi/qedi/qedi_fw.c:293:37: sparse: sparse: restricted __le32 degrades to integer
drivers/scsi/qedi/qedi_fw.c:331:13: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned short [usertype] idx @@ got restricted __le16 [usertype] rqe_opaque @@
drivers/scsi/qedi/qedi_fw.c:331:13: sparse: expected unsigned short [usertype] idx
drivers/scsi/qedi/qedi_fw.c:331:13: sparse: got restricted __le16 [usertype] rqe_opaque
drivers/scsi/qedi/qedi_fw.c:366:13: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned short [usertype] idx @@ got restricted __le16 [usertype] rqe_opaque @@
drivers/scsi/qedi/qedi_fw.c:366:13: sparse: expected unsigned short [usertype] idx
drivers/scsi/qedi/qedi_fw.c:366:13: sparse: got restricted __le16 [usertype] rqe_opaque
drivers/scsi/qedi/qedi_fw.c:384:41: sparse: sparse: incorrect type in assignment (different base types) @@ expected restricted __le16 [usertype] opaque @@ got restricted __le32 [usertype] @@
drivers/scsi/qedi/qedi_fw.c:384:41: sparse: expected restricted __le16 [usertype] opaque
drivers/scsi/qedi/qedi_fw.c:384:41: sparse: got restricted __le32 [usertype]
drivers/scsi/qedi/qedi_fw.c:427:29: sparse: sparse: restricted __le32 degrades to integer
drivers/scsi/qedi/qedi_fw.c:434:26: sparse: sparse: cast from restricted __le32
drivers/scsi/qedi/qedi_fw.c:435:26: sparse: sparse: cast from restricted __le32
drivers/scsi/qedi/qedi_fw.c:436:23: sparse: sparse: cast from restricted __le32
drivers/scsi/qedi/qedi_fw.c:437:20: sparse: sparse: cast from restricted __le32
drivers/scsi/qedi/qedi_fw.c:453:28: sparse: sparse: restricted __le16 degrades to integer
drivers/scsi/qedi/qedi_fw.c:497:32: sparse: sparse: restricted __le32 degrades to integer
drivers/scsi/qedi/qedi_fw.c:513:18: sparse: sparse: cast from restricted __le32
drivers/scsi/qedi/qedi_fw.c:513:16: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned int @@ got restricted __be32 [usertype] @@
drivers/scsi/qedi/qedi_fw.c:513:16: sparse: expected unsigned int
drivers/scsi/qedi/qedi_fw.c:513:16: sparse: got restricted __be32 [usertype]
drivers/scsi/qedi/qedi_fw.c:514:18: sparse: sparse: cast from restricted __le32
drivers/scsi/qedi/qedi_fw.c:514:16: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned int @@ got restricted __be32 [usertype] @@
drivers/scsi/qedi/qedi_fw.c:514:16: sparse: expected unsigned int
drivers/scsi/qedi/qedi_fw.c:514:16: sparse: got restricted __be32 [usertype]
drivers/scsi/qedi/qedi_fw.c:516:31: sparse: sparse: cast from restricted __le32
drivers/scsi/qedi/qedi_fw.c:517:31: sparse: sparse: cast from restricted __le32
drivers/scsi/qedi/qedi_fw.c:518:28: sparse: sparse: cast from restricted __le32
drivers/scsi/qedi/qedi_fw.c:523:28: sparse: sparse: cast from restricted __le16
drivers/scsi/qedi/qedi_fw.c:524:28: sparse: sparse: cast from restricted __le16
drivers/scsi/qedi/qedi_fw.c:525:28: sparse: sparse: cast from restricted __le16
drivers/scsi/qedi/qedi_fw.c:548:29: sparse: sparse: restricted __le32 degrades to integer
drivers/scsi/qedi/qedi_fw.c:563:9: sparse: sparse: restricted __le32 degrades to integer
drivers/scsi/qedi/qedi_fw.c:563:9: sparse: sparse: restricted __le32 degrades to integer
drivers/scsi/qedi/qedi_fw.c:563:9: sparse: sparse: restricted __le32 degrades to integer
drivers/scsi/qedi/qedi_fw.c:565:26: sparse: sparse: cast from restricted __le32
drivers/scsi/qedi/qedi_fw.c:566:26: sparse: sparse: cast from restricted __le32
drivers/scsi/qedi/qedi_fw.c:567:23: sparse: sparse: cast from restricted __le32
drivers/scsi/qedi/qedi_fw.c:590:20: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned int [usertype] iscsi_cid @@ got restricted __le16 [usertype] conn_id @@
drivers/scsi/qedi/qedi_fw.c:590:20: sparse: expected unsigned int [usertype] iscsi_cid
drivers/scsi/qedi/qedi_fw.c:590:20: sparse: got restricted __le16 [usertype] conn_id
drivers/scsi/qedi/qedi_fw.c:630:26: sparse: sparse: cast from restricted __le32
drivers/scsi/qedi/qedi_fw.c:631:26: sparse: sparse: cast from restricted __le32
drivers/scsi/qedi/qedi_fw.c:632:20: sparse: sparse: restricted __le16 degrades to integer
drivers/scsi/qedi/qedi_fw.c:636:31: sparse: sparse: cast from restricted __le32
drivers/scsi/qedi/qedi_fw.c:639:38: sparse: sparse: restricted __le32 degrades to integer
drivers/scsi/qedi/qedi_fw.c:741:28: sparse: sparse: incorrect type in initializer (different base types) @@ expected unsigned int [usertype] proto_itt @@ got restricted __le16 [usertype] itid @@
drivers/scsi/qedi/qedi_fw.c:741:28: sparse: expected unsigned int [usertype] proto_itt
drivers/scsi/qedi/qedi_fw.c:741:28: sparse: got restricted __le16 [usertype] itid
drivers/scsi/qedi/qedi_fw.c:751:19: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned int [usertype] iscsi_cid @@ got restricted __le16 [usertype] conn_id @@
drivers/scsi/qedi/qedi_fw.c:751:19: sparse: expected unsigned int [usertype] iscsi_cid
drivers/scsi/qedi/qedi_fw.c:751:19: sparse: got restricted __le16 [usertype] conn_id
drivers/scsi/qedi/qedi_fw.c:802:9: sparse: sparse: cast to restricted itt_t
drivers/scsi/qedi/qedi_fw.c:864:20: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned int [usertype] iscsi_cid @@ got restricted __le16 [usertype] conn_id @@
drivers/scsi/qedi/qedi_fw.c:864:20: sparse: expected unsigned int [usertype] iscsi_cid
drivers/scsi/qedi/qedi_fw.c:864:20: sparse: got restricted __le16 [usertype] conn_id
drivers/scsi/qedi/qedi_fw.c:895:50: sparse: sparse: cast from restricted itt_t
drivers/scsi/qedi/qedi_fw.c:895:40: sparse: sparse: restricted __le16 degrades to integer
drivers/scsi/qedi/qedi_fw.c:900:48: sparse: sparse: restricted __le32 degrades to integer
drivers/scsi/qedi/qedi_fw.c:899:49: sparse: sparse: incorrect type in assignment (different base types) @@ expected restricted __le16 [usertype] itid @@ got unsigned int @@
drivers/scsi/qedi/qedi_fw.c:899:49: sparse: expected restricted __le16 [usertype] itid
drivers/scsi/qedi/qedi_fw.c:899:49: sparse: got unsigned int
drivers/scsi/qedi/qedi_fw.c:948:23: sparse: sparse: incorrect type in assignment (different base types) @@ expected restricted __le16 [assigned] [usertype] sq_prod @@ got unsigned short [usertype] fw_sq_prod_idx @@
drivers/scsi/qedi/qedi_fw.c:948:23: sparse: expected restricted __le16 [assigned] [usertype] sq_prod
drivers/scsi/qedi/qedi_fw.c:948:23: sparse: got unsigned short [usertype] fw_sq_prod_idx
drivers/scsi/qedi/qedi_fw.c:1021:40: sparse: sparse: incorrect type in assignment (different base types) @@ expected restricted __le32 [addressable] [assigned] [usertype] isid_tabc @@ got unsigned int @@
drivers/scsi/qedi/qedi_fw.c:1021:40: sparse: expected restricted __le32 [addressable] [assigned] [usertype] isid_tabc
drivers/scsi/qedi/qedi_fw.c:1021:40: sparse: got unsigned int
drivers/scsi/qedi/qedi_fw.c:1022:37: sparse: sparse: incorrect type in assignment (different base types) @@ expected restricted __le16 [addressable] [assigned] [usertype] isid_d @@ got unsigned short @@
drivers/scsi/qedi/qedi_fw.c:1022:37: sparse: expected restricted __le16 [addressable] [assigned] [usertype] isid_d
drivers/scsi/qedi/qedi_fw.c:1022:37: sparse: got unsigned short
drivers/scsi/qedi/qedi_fw.c:1024:35: sparse: sparse: incorrect type in assignment (different base types) @@ expected restricted __le16 [addressable] [assigned] [usertype] tsih @@ got restricted __be16 [usertype] tsih @@
drivers/scsi/qedi/qedi_fw.c:1024:35: sparse: expected restricted __le16 [addressable] [assigned] [usertype] tsih
drivers/scsi/qedi/qedi_fw.c:1024:35: sparse: got restricted __be16 [usertype] tsih
drivers/scsi/qedi/qedi_fw.c:1025:47: sparse: sparse: incorrect type in assignment (different base types) @@ expected restricted __le32 [addressable] [assigned] [usertype] hdr_second_dword @@ got int @@
drivers/scsi/qedi/qedi_fw.c:1025:47: sparse: expected restricted __le32 [addressable] [assigned] [usertype] hdr_second_dword
drivers/scsi/qedi/qedi_fw.c:1025:47: sparse: got int
drivers/scsi/qedi/qedi_fw.c:1028:36: sparse: sparse: cast to restricted itt_t
drivers/scsi/qedi/qedi_fw.c:1028:34: sparse: sparse: incorrect type in assignment (different base types) @@ expected restricted __le32 [addressable] [assigned] [usertype] itt @@ got unsigned int [usertype] @@
drivers/scsi/qedi/qedi_fw.c:1028:34: sparse: expected restricted __le32 [addressable] [assigned] [usertype] itt
drivers/scsi/qedi/qedi_fw.c:1028:34: sparse: got unsigned int [usertype]
drivers/scsi/qedi/qedi_fw.c:1029:34: sparse: sparse: incorrect type in assignment (different base types) @@ expected restricted __le16 [addressable] [assigned] [usertype] cid @@ got unsigned int [usertype] iscsi_conn_id @@
drivers/scsi/qedi/qedi_fw.c:1029:34: sparse: expected restricted __le16 [addressable] [assigned] [usertype] cid
drivers/scsi/qedi/qedi_fw.c:1029:34: sparse: got unsigned int [usertype] iscsi_conn_id
drivers/scsi/qedi/qedi_fw.c:1030:37: sparse: sparse: incorrect type in assignment (different base types) @@ expected restricted __le32 [addressable] [assigned] [usertype] cmd_sn @@ got unsigned int [usertype] @@
drivers/scsi/qedi/qedi_fw.c:1030:37: sparse: expected restricted __le32 [addressable] [assigned] [usertype] cmd_sn
drivers/scsi/qedi/qedi_fw.c:1030:37: sparse: got unsigned int [usertype]
drivers/scsi/qedi/qedi_fw.c:1031:42: sparse: sparse: incorrect type in assignment (different base types) @@ expected restricted __le32 [addressable] [assigned] [usertype] exp_stat_sn @@ got unsigned int [usertype] @@
drivers/scsi/qedi/qedi_fw.c:1031:42: sparse: expected restricted __le32 [addressable] [assigned] [usertype] exp_stat_sn
drivers/scsi/qedi/qedi_fw.c:1031:42: sparse: got unsigned int [usertype]
drivers/scsi/qedi/qedi_fw.c:1037:45: sparse: sparse: incorrect type in assignment (different base types) @@ expected restricted __le32 [addressable] [assigned] [usertype] lo @@ got unsigned int [usertype] @@
drivers/scsi/qedi/qedi_fw.c:1037:45: sparse: expected restricted __le32 [addressable] [assigned] [usertype] lo
drivers/scsi/qedi/qedi_fw.c:1037:45: sparse: got unsigned int [usertype]
>> drivers/scsi/qedi/qedi_fw.c:1039:45: sparse: sparse: incorrect type in assignment (different base types) @@ expected restricted __le32 [addressable] [assigned] [usertype] hi @@ got unsigned int [usertype] @@
drivers/scsi/qedi/qedi_fw.c:1039:45: sparse: expected restricted __le32 [addressable] [assigned] [usertype] hi
drivers/scsi/qedi/qedi_fw.c:1039:45: sparse: got unsigned int [usertype]
drivers/scsi/qedi/qedi_fw.c:1046:45: sparse: sparse: incorrect type in assignment (different base types) @@ expected restricted __le32 [addressable] [assigned] [usertype] lo @@ got unsigned int [usertype] @@
drivers/scsi/qedi/qedi_fw.c:1046:45: sparse: expected restricted __le32 [addressable] [assigned] [usertype] lo
drivers/scsi/qedi/qedi_fw.c:1046:45: sparse: got unsigned int [usertype]
drivers/scsi/qedi/qedi_fw.c:1048:45: sparse: sparse: incorrect type in assignment (different base types) @@ expected restricted __le32 [addressable] [assigned] [usertype] hi @@ got unsigned int [usertype] @@
drivers/scsi/qedi/qedi_fw.c:1048:45: sparse: expected restricted __le32 [addressable] [assigned] [usertype] hi
drivers/scsi/qedi/qedi_fw.c:1048:45: sparse: got unsigned int [usertype]
drivers/scsi/qedi/qedi_fw.c:1050:46: sparse: sparse: too many warnings
vim +1039 drivers/scsi/qedi/qedi_fw.c
be086e7c53f1fa Mintz, Yuval 2017-03-11 978
ace7f46ba5fde7 Manish Rangankar 2016-12-01 979 int qedi_send_iscsi_login(struct qedi_conn *qedi_conn,
ace7f46ba5fde7 Manish Rangankar 2016-12-01 980 struct iscsi_task *task)
ace7f46ba5fde7 Manish Rangankar 2016-12-01 981 {
be086e7c53f1fa Mintz, Yuval 2017-03-11 982 struct iscsi_login_req_hdr login_req_pdu_header;
be086e7c53f1fa Mintz, Yuval 2017-03-11 983 struct scsi_sgl_task_params tx_sgl_task_params;
be086e7c53f1fa Mintz, Yuval 2017-03-11 984 struct scsi_sgl_task_params rx_sgl_task_params;
be086e7c53f1fa Mintz, Yuval 2017-03-11 985 struct iscsi_task_params task_params;
21dd79e82f00b2 Tomer Tayar 2017-12-27 986 struct e4_iscsi_task_context *fw_task_ctx;
be086e7c53f1fa Mintz, Yuval 2017-03-11 987 struct qedi_ctx *qedi = qedi_conn->qedi;
ace7f46ba5fde7 Manish Rangankar 2016-12-01 988 struct iscsi_login_req *login_hdr;
be086e7c53f1fa Mintz, Yuval 2017-03-11 989 struct scsi_sge *resp_sge = NULL;
ace7f46ba5fde7 Manish Rangankar 2016-12-01 990 struct qedi_cmd *qedi_cmd;
be086e7c53f1fa Mintz, Yuval 2017-03-11 991 struct qedi_endpoint *ep;
ace7f46ba5fde7 Manish Rangankar 2016-12-01 992 s16 tid = 0;
be086e7c53f1fa Mintz, Yuval 2017-03-11 993 u16 sq_idx = 0;
be086e7c53f1fa Mintz, Yuval 2017-03-11 994 int rval = 0;
ace7f46ba5fde7 Manish Rangankar 2016-12-01 995
be086e7c53f1fa Mintz, Yuval 2017-03-11 996 resp_sge = (struct scsi_sge *)qedi_conn->gen_pdu.resp_bd_tbl;
ace7f46ba5fde7 Manish Rangankar 2016-12-01 997 qedi_cmd = (struct qedi_cmd *)task->dd_data;
be086e7c53f1fa Mintz, Yuval 2017-03-11 998 ep = qedi_conn->ep;
ace7f46ba5fde7 Manish Rangankar 2016-12-01 999 login_hdr = (struct iscsi_login_req *)task->hdr;
ace7f46ba5fde7 Manish Rangankar 2016-12-01 1000
ace7f46ba5fde7 Manish Rangankar 2016-12-01 1001 tid = qedi_get_task_idx(qedi);
ace7f46ba5fde7 Manish Rangankar 2016-12-01 1002 if (tid == -1)
ace7f46ba5fde7 Manish Rangankar 2016-12-01 1003 return -ENOMEM;
ace7f46ba5fde7 Manish Rangankar 2016-12-01 1004
be086e7c53f1fa Mintz, Yuval 2017-03-11 1005 fw_task_ctx =
21dd79e82f00b2 Tomer Tayar 2017-12-27 1006 (struct e4_iscsi_task_context *)qedi_get_task_mem(&qedi->tasks,
21dd79e82f00b2 Tomer Tayar 2017-12-27 1007 tid);
21dd79e82f00b2 Tomer Tayar 2017-12-27 1008 memset(fw_task_ctx, 0, sizeof(struct e4_iscsi_task_context));
ace7f46ba5fde7 Manish Rangankar 2016-12-01 1009
ace7f46ba5fde7 Manish Rangankar 2016-12-01 1010 qedi_cmd->task_id = tid;
ace7f46ba5fde7 Manish Rangankar 2016-12-01 1011
be086e7c53f1fa Mintz, Yuval 2017-03-11 1012 memset(&task_params, 0, sizeof(task_params));
be086e7c53f1fa Mintz, Yuval 2017-03-11 1013 memset(&login_req_pdu_header, 0, sizeof(login_req_pdu_header));
be086e7c53f1fa Mintz, Yuval 2017-03-11 1014 memset(&tx_sgl_task_params, 0, sizeof(tx_sgl_task_params));
be086e7c53f1fa Mintz, Yuval 2017-03-11 1015 memset(&rx_sgl_task_params, 0, sizeof(rx_sgl_task_params));
be086e7c53f1fa Mintz, Yuval 2017-03-11 1016 /* Update header info */
be086e7c53f1fa Mintz, Yuval 2017-03-11 1017 login_req_pdu_header.opcode = login_hdr->opcode;
be086e7c53f1fa Mintz, Yuval 2017-03-11 1018 login_req_pdu_header.version_min = login_hdr->min_version;
be086e7c53f1fa Mintz, Yuval 2017-03-11 1019 login_req_pdu_header.version_max = login_hdr->max_version;
be086e7c53f1fa Mintz, Yuval 2017-03-11 1020 login_req_pdu_header.flags_attr = login_hdr->flags;
be086e7c53f1fa Mintz, Yuval 2017-03-11 1021 login_req_pdu_header.isid_tabc = swab32p((u32 *)login_hdr->isid);
be086e7c53f1fa Mintz, Yuval 2017-03-11 1022 login_req_pdu_header.isid_d = swab16p((u16 *)&login_hdr->isid[4]);
be086e7c53f1fa Mintz, Yuval 2017-03-11 1023
be086e7c53f1fa Mintz, Yuval 2017-03-11 1024 login_req_pdu_header.tsih = login_hdr->tsih;
be086e7c53f1fa Mintz, Yuval 2017-03-11 1025 login_req_pdu_header.hdr_second_dword = ntoh24(login_hdr->dlength);
be086e7c53f1fa Mintz, Yuval 2017-03-11 1026
ace7f46ba5fde7 Manish Rangankar 2016-12-01 1027 qedi_update_itt_map(qedi, tid, task->itt, qedi_cmd);
be086e7c53f1fa Mintz, Yuval 2017-03-11 1028 login_req_pdu_header.itt = qedi_set_itt(tid, get_itt(task->itt));
be086e7c53f1fa Mintz, Yuval 2017-03-11 1029 login_req_pdu_header.cid = qedi_conn->iscsi_conn_id;
be086e7c53f1fa Mintz, Yuval 2017-03-11 1030 login_req_pdu_header.cmd_sn = be32_to_cpu(login_hdr->cmdsn);
be086e7c53f1fa Mintz, Yuval 2017-03-11 1031 login_req_pdu_header.exp_stat_sn = be32_to_cpu(login_hdr->exp_statsn);
be086e7c53f1fa Mintz, Yuval 2017-03-11 1032 login_req_pdu_header.exp_stat_sn = 0;
be086e7c53f1fa Mintz, Yuval 2017-03-11 1033
be086e7c53f1fa Mintz, Yuval 2017-03-11 1034 /* Fill tx AHS and rx buffer */
be086e7c53f1fa Mintz, Yuval 2017-03-11 1035 tx_sgl_task_params.sgl =
be086e7c53f1fa Mintz, Yuval 2017-03-11 1036 (struct scsi_sge *)qedi_conn->gen_pdu.req_bd_tbl;
be086e7c53f1fa Mintz, Yuval 2017-03-11 1037 tx_sgl_task_params.sgl_phys_addr.lo =
be086e7c53f1fa Mintz, Yuval 2017-03-11 1038 (u32)(qedi_conn->gen_pdu.req_dma_addr);
be086e7c53f1fa Mintz, Yuval 2017-03-11 @1039 tx_sgl_task_params.sgl_phys_addr.hi =
ace7f46ba5fde7 Manish Rangankar 2016-12-01 1040 (u32)((u64)qedi_conn->gen_pdu.req_dma_addr >> 32);
be086e7c53f1fa Mintz, Yuval 2017-03-11 1041 tx_sgl_task_params.total_buffer_size = ntoh24(login_hdr->dlength);
be086e7c53f1fa Mintz, Yuval 2017-03-11 1042 tx_sgl_task_params.num_sges = 1;
be086e7c53f1fa Mintz, Yuval 2017-03-11 1043
be086e7c53f1fa Mintz, Yuval 2017-03-11 1044 rx_sgl_task_params.sgl =
be086e7c53f1fa Mintz, Yuval 2017-03-11 1045 (struct scsi_sge *)qedi_conn->gen_pdu.resp_bd_tbl;
be086e7c53f1fa Mintz, Yuval 2017-03-11 1046 rx_sgl_task_params.sgl_phys_addr.lo =
be086e7c53f1fa Mintz, Yuval 2017-03-11 1047 (u32)(qedi_conn->gen_pdu.resp_dma_addr);
be086e7c53f1fa Mintz, Yuval 2017-03-11 1048 rx_sgl_task_params.sgl_phys_addr.hi =
be086e7c53f1fa Mintz, Yuval 2017-03-11 1049 (u32)((u64)qedi_conn->gen_pdu.resp_dma_addr >> 32);
be086e7c53f1fa Mintz, Yuval 2017-03-11 1050 rx_sgl_task_params.total_buffer_size = resp_sge->sge_len;
be086e7c53f1fa Mintz, Yuval 2017-03-11 1051 rx_sgl_task_params.num_sges = 1;
be086e7c53f1fa Mintz, Yuval 2017-03-11 1052
be086e7c53f1fa Mintz, Yuval 2017-03-11 1053 /* Fill fw input params */
be086e7c53f1fa Mintz, Yuval 2017-03-11 1054 task_params.context = fw_task_ctx;
be086e7c53f1fa Mintz, Yuval 2017-03-11 1055 task_params.conn_icid = (u16)qedi_conn->iscsi_conn_id;
be086e7c53f1fa Mintz, Yuval 2017-03-11 1056 task_params.itid = tid;
be086e7c53f1fa Mintz, Yuval 2017-03-11 1057 task_params.cq_rss_number = 0;
be086e7c53f1fa Mintz, Yuval 2017-03-11 1058 task_params.tx_io_size = ntoh24(login_hdr->dlength);
be086e7c53f1fa Mintz, Yuval 2017-03-11 1059 task_params.rx_io_size = resp_sge->sge_len;
be086e7c53f1fa Mintz, Yuval 2017-03-11 1060
be086e7c53f1fa Mintz, Yuval 2017-03-11 1061 sq_idx = qedi_get_wqe_idx(qedi_conn);
be086e7c53f1fa Mintz, Yuval 2017-03-11 1062 task_params.sqe = &ep->sq[sq_idx];
be086e7c53f1fa Mintz, Yuval 2017-03-11 1063
be086e7c53f1fa Mintz, Yuval 2017-03-11 1064 memset(task_params.sqe, 0, sizeof(struct iscsi_wqe));
be086e7c53f1fa Mintz, Yuval 2017-03-11 1065 rval = init_initiator_login_request_task(&task_params,
be086e7c53f1fa Mintz, Yuval 2017-03-11 1066 &login_req_pdu_header,
be086e7c53f1fa Mintz, Yuval 2017-03-11 1067 &tx_sgl_task_params,
be086e7c53f1fa Mintz, Yuval 2017-03-11 1068 &rx_sgl_task_params);
be086e7c53f1fa Mintz, Yuval 2017-03-11 1069 if (rval)
be086e7c53f1fa Mintz, Yuval 2017-03-11 1070 return -1;
ace7f46ba5fde7 Manish Rangankar 2016-12-01 1071
ace7f46ba5fde7 Manish Rangankar 2016-12-01 1072 spin_lock(&qedi_conn->list_lock);
ace7f46ba5fde7 Manish Rangankar 2016-12-01 1073 list_add_tail(&qedi_cmd->io_cmd, &qedi_conn->active_cmd_list);
ace7f46ba5fde7 Manish Rangankar 2016-12-01 1074 qedi_cmd->io_cmd_in_list = true;
ace7f46ba5fde7 Manish Rangankar 2016-12-01 1075 qedi_conn->active_cmd_count++;
ace7f46ba5fde7 Manish Rangankar 2016-12-01 1076 spin_unlock(&qedi_conn->list_lock);
ace7f46ba5fde7 Manish Rangankar 2016-12-01 1077
ace7f46ba5fde7 Manish Rangankar 2016-12-01 1078 qedi_ring_doorbell(qedi_conn);
ace7f46ba5fde7 Manish Rangankar 2016-12-01 1079 return 0;
ace7f46ba5fde7 Manish Rangankar 2016-12-01 1080 }
ace7f46ba5fde7 Manish Rangankar 2016-12-01 1081
:::::: The code at line 1039 was first introduced by commit
:::::: be086e7c53f1fac51eed14523b28f2214b548dd2 qed*: Utilize Firmware 8.15.3.0
:::::: TO: Mintz, Yuval <Yuval.Mintz@cavium.com>
:::::: CC: David S. Miller <davem@davemloft.net>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 68144 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* [linux-next:master 6351/6976] drivers/scsi/qedi/qedi_fw.c:1039:45: sparse: sparse: incorrect type in assignment (different base types)
@ 2021-06-03 17:10 ` kernel test robot
0 siblings, 0 replies; 6+ messages in thread
From: kernel test robot @ 2021-06-03 17:10 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 23639 bytes --]
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: 3ebdbe7aa5dd825d609c3433c35c13b440a61c52
commit: ed1b86ba0fba3d586cd53057551a95197b0a37ad [6351/6976] scsi: qedi: Wake up if cmd_cleanup_req is set
config: arc-allyesconfig (attached as .config)
compiler: arceb-elf-gcc (GCC) 9.3.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# apt-get install sparse
# sparse version: v0.6.3-341-g8af24329-dirty
# https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=ed1b86ba0fba3d586cd53057551a95197b0a37ad
git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
git fetch --no-tags linux-next master
git checkout ed1b86ba0fba3d586cd53057551a95197b0a37ad
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' W=1 ARCH=arc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
sparse warnings: (new ones prefixed by >>)
drivers/scsi/qedi/qedi_fw.c:285:29: sparse: sparse: restricted __le16 degrades to integer
drivers/scsi/qedi/qedi_fw.c:287:28: sparse: sparse: incorrect type in assignment (different base types) @@ expected restricted __be16 [usertype] tsih @@ got restricted __le16 [usertype] tsih @@
drivers/scsi/qedi/qedi_fw.c:287:28: sparse: expected restricted __be16 [usertype] tsih
drivers/scsi/qedi/qedi_fw.c:287:28: sparse: got restricted __le16 [usertype] tsih
drivers/scsi/qedi/qedi_fw.c:288:32: sparse: sparse: cast from restricted __le32
drivers/scsi/qedi/qedi_fw.c:289:35: sparse: sparse: cast from restricted __le32
drivers/scsi/qedi/qedi_fw.c:290:35: sparse: sparse: cast from restricted __le32
drivers/scsi/qedi/qedi_fw.c:293:37: sparse: sparse: restricted __le32 degrades to integer
drivers/scsi/qedi/qedi_fw.c:331:13: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned short [usertype] idx @@ got restricted __le16 [usertype] rqe_opaque @@
drivers/scsi/qedi/qedi_fw.c:331:13: sparse: expected unsigned short [usertype] idx
drivers/scsi/qedi/qedi_fw.c:331:13: sparse: got restricted __le16 [usertype] rqe_opaque
drivers/scsi/qedi/qedi_fw.c:366:13: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned short [usertype] idx @@ got restricted __le16 [usertype] rqe_opaque @@
drivers/scsi/qedi/qedi_fw.c:366:13: sparse: expected unsigned short [usertype] idx
drivers/scsi/qedi/qedi_fw.c:366:13: sparse: got restricted __le16 [usertype] rqe_opaque
drivers/scsi/qedi/qedi_fw.c:384:41: sparse: sparse: incorrect type in assignment (different base types) @@ expected restricted __le16 [usertype] opaque @@ got restricted __le32 [usertype] @@
drivers/scsi/qedi/qedi_fw.c:384:41: sparse: expected restricted __le16 [usertype] opaque
drivers/scsi/qedi/qedi_fw.c:384:41: sparse: got restricted __le32 [usertype]
drivers/scsi/qedi/qedi_fw.c:427:29: sparse: sparse: restricted __le32 degrades to integer
drivers/scsi/qedi/qedi_fw.c:434:26: sparse: sparse: cast from restricted __le32
drivers/scsi/qedi/qedi_fw.c:435:26: sparse: sparse: cast from restricted __le32
drivers/scsi/qedi/qedi_fw.c:436:23: sparse: sparse: cast from restricted __le32
drivers/scsi/qedi/qedi_fw.c:437:20: sparse: sparse: cast from restricted __le32
drivers/scsi/qedi/qedi_fw.c:453:28: sparse: sparse: restricted __le16 degrades to integer
drivers/scsi/qedi/qedi_fw.c:497:32: sparse: sparse: restricted __le32 degrades to integer
drivers/scsi/qedi/qedi_fw.c:513:18: sparse: sparse: cast from restricted __le32
drivers/scsi/qedi/qedi_fw.c:513:16: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned int @@ got restricted __be32 [usertype] @@
drivers/scsi/qedi/qedi_fw.c:513:16: sparse: expected unsigned int
drivers/scsi/qedi/qedi_fw.c:513:16: sparse: got restricted __be32 [usertype]
drivers/scsi/qedi/qedi_fw.c:514:18: sparse: sparse: cast from restricted __le32
drivers/scsi/qedi/qedi_fw.c:514:16: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned int @@ got restricted __be32 [usertype] @@
drivers/scsi/qedi/qedi_fw.c:514:16: sparse: expected unsigned int
drivers/scsi/qedi/qedi_fw.c:514:16: sparse: got restricted __be32 [usertype]
drivers/scsi/qedi/qedi_fw.c:516:31: sparse: sparse: cast from restricted __le32
drivers/scsi/qedi/qedi_fw.c:517:31: sparse: sparse: cast from restricted __le32
drivers/scsi/qedi/qedi_fw.c:518:28: sparse: sparse: cast from restricted __le32
drivers/scsi/qedi/qedi_fw.c:523:28: sparse: sparse: cast from restricted __le16
drivers/scsi/qedi/qedi_fw.c:524:28: sparse: sparse: cast from restricted __le16
drivers/scsi/qedi/qedi_fw.c:525:28: sparse: sparse: cast from restricted __le16
drivers/scsi/qedi/qedi_fw.c:548:29: sparse: sparse: restricted __le32 degrades to integer
drivers/scsi/qedi/qedi_fw.c:563:9: sparse: sparse: restricted __le32 degrades to integer
drivers/scsi/qedi/qedi_fw.c:563:9: sparse: sparse: restricted __le32 degrades to integer
drivers/scsi/qedi/qedi_fw.c:563:9: sparse: sparse: restricted __le32 degrades to integer
drivers/scsi/qedi/qedi_fw.c:565:26: sparse: sparse: cast from restricted __le32
drivers/scsi/qedi/qedi_fw.c:566:26: sparse: sparse: cast from restricted __le32
drivers/scsi/qedi/qedi_fw.c:567:23: sparse: sparse: cast from restricted __le32
drivers/scsi/qedi/qedi_fw.c:590:20: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned int [usertype] iscsi_cid @@ got restricted __le16 [usertype] conn_id @@
drivers/scsi/qedi/qedi_fw.c:590:20: sparse: expected unsigned int [usertype] iscsi_cid
drivers/scsi/qedi/qedi_fw.c:590:20: sparse: got restricted __le16 [usertype] conn_id
drivers/scsi/qedi/qedi_fw.c:630:26: sparse: sparse: cast from restricted __le32
drivers/scsi/qedi/qedi_fw.c:631:26: sparse: sparse: cast from restricted __le32
drivers/scsi/qedi/qedi_fw.c:632:20: sparse: sparse: restricted __le16 degrades to integer
drivers/scsi/qedi/qedi_fw.c:636:31: sparse: sparse: cast from restricted __le32
drivers/scsi/qedi/qedi_fw.c:639:38: sparse: sparse: restricted __le32 degrades to integer
drivers/scsi/qedi/qedi_fw.c:741:28: sparse: sparse: incorrect type in initializer (different base types) @@ expected unsigned int [usertype] proto_itt @@ got restricted __le16 [usertype] itid @@
drivers/scsi/qedi/qedi_fw.c:741:28: sparse: expected unsigned int [usertype] proto_itt
drivers/scsi/qedi/qedi_fw.c:741:28: sparse: got restricted __le16 [usertype] itid
drivers/scsi/qedi/qedi_fw.c:751:19: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned int [usertype] iscsi_cid @@ got restricted __le16 [usertype] conn_id @@
drivers/scsi/qedi/qedi_fw.c:751:19: sparse: expected unsigned int [usertype] iscsi_cid
drivers/scsi/qedi/qedi_fw.c:751:19: sparse: got restricted __le16 [usertype] conn_id
drivers/scsi/qedi/qedi_fw.c:802:9: sparse: sparse: cast to restricted itt_t
drivers/scsi/qedi/qedi_fw.c:864:20: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned int [usertype] iscsi_cid @@ got restricted __le16 [usertype] conn_id @@
drivers/scsi/qedi/qedi_fw.c:864:20: sparse: expected unsigned int [usertype] iscsi_cid
drivers/scsi/qedi/qedi_fw.c:864:20: sparse: got restricted __le16 [usertype] conn_id
drivers/scsi/qedi/qedi_fw.c:895:50: sparse: sparse: cast from restricted itt_t
drivers/scsi/qedi/qedi_fw.c:895:40: sparse: sparse: restricted __le16 degrades to integer
drivers/scsi/qedi/qedi_fw.c:900:48: sparse: sparse: restricted __le32 degrades to integer
drivers/scsi/qedi/qedi_fw.c:899:49: sparse: sparse: incorrect type in assignment (different base types) @@ expected restricted __le16 [usertype] itid @@ got unsigned int @@
drivers/scsi/qedi/qedi_fw.c:899:49: sparse: expected restricted __le16 [usertype] itid
drivers/scsi/qedi/qedi_fw.c:899:49: sparse: got unsigned int
drivers/scsi/qedi/qedi_fw.c:948:23: sparse: sparse: incorrect type in assignment (different base types) @@ expected restricted __le16 [assigned] [usertype] sq_prod @@ got unsigned short [usertype] fw_sq_prod_idx @@
drivers/scsi/qedi/qedi_fw.c:948:23: sparse: expected restricted __le16 [assigned] [usertype] sq_prod
drivers/scsi/qedi/qedi_fw.c:948:23: sparse: got unsigned short [usertype] fw_sq_prod_idx
drivers/scsi/qedi/qedi_fw.c:1021:40: sparse: sparse: incorrect type in assignment (different base types) @@ expected restricted __le32 [addressable] [assigned] [usertype] isid_tabc @@ got unsigned int @@
drivers/scsi/qedi/qedi_fw.c:1021:40: sparse: expected restricted __le32 [addressable] [assigned] [usertype] isid_tabc
drivers/scsi/qedi/qedi_fw.c:1021:40: sparse: got unsigned int
drivers/scsi/qedi/qedi_fw.c:1022:37: sparse: sparse: incorrect type in assignment (different base types) @@ expected restricted __le16 [addressable] [assigned] [usertype] isid_d @@ got unsigned short @@
drivers/scsi/qedi/qedi_fw.c:1022:37: sparse: expected restricted __le16 [addressable] [assigned] [usertype] isid_d
drivers/scsi/qedi/qedi_fw.c:1022:37: sparse: got unsigned short
drivers/scsi/qedi/qedi_fw.c:1024:35: sparse: sparse: incorrect type in assignment (different base types) @@ expected restricted __le16 [addressable] [assigned] [usertype] tsih @@ got restricted __be16 [usertype] tsih @@
drivers/scsi/qedi/qedi_fw.c:1024:35: sparse: expected restricted __le16 [addressable] [assigned] [usertype] tsih
drivers/scsi/qedi/qedi_fw.c:1024:35: sparse: got restricted __be16 [usertype] tsih
drivers/scsi/qedi/qedi_fw.c:1025:47: sparse: sparse: incorrect type in assignment (different base types) @@ expected restricted __le32 [addressable] [assigned] [usertype] hdr_second_dword @@ got int @@
drivers/scsi/qedi/qedi_fw.c:1025:47: sparse: expected restricted __le32 [addressable] [assigned] [usertype] hdr_second_dword
drivers/scsi/qedi/qedi_fw.c:1025:47: sparse: got int
drivers/scsi/qedi/qedi_fw.c:1028:36: sparse: sparse: cast to restricted itt_t
drivers/scsi/qedi/qedi_fw.c:1028:34: sparse: sparse: incorrect type in assignment (different base types) @@ expected restricted __le32 [addressable] [assigned] [usertype] itt @@ got unsigned int [usertype] @@
drivers/scsi/qedi/qedi_fw.c:1028:34: sparse: expected restricted __le32 [addressable] [assigned] [usertype] itt
drivers/scsi/qedi/qedi_fw.c:1028:34: sparse: got unsigned int [usertype]
drivers/scsi/qedi/qedi_fw.c:1029:34: sparse: sparse: incorrect type in assignment (different base types) @@ expected restricted __le16 [addressable] [assigned] [usertype] cid @@ got unsigned int [usertype] iscsi_conn_id @@
drivers/scsi/qedi/qedi_fw.c:1029:34: sparse: expected restricted __le16 [addressable] [assigned] [usertype] cid
drivers/scsi/qedi/qedi_fw.c:1029:34: sparse: got unsigned int [usertype] iscsi_conn_id
drivers/scsi/qedi/qedi_fw.c:1030:37: sparse: sparse: incorrect type in assignment (different base types) @@ expected restricted __le32 [addressable] [assigned] [usertype] cmd_sn @@ got unsigned int [usertype] @@
drivers/scsi/qedi/qedi_fw.c:1030:37: sparse: expected restricted __le32 [addressable] [assigned] [usertype] cmd_sn
drivers/scsi/qedi/qedi_fw.c:1030:37: sparse: got unsigned int [usertype]
drivers/scsi/qedi/qedi_fw.c:1031:42: sparse: sparse: incorrect type in assignment (different base types) @@ expected restricted __le32 [addressable] [assigned] [usertype] exp_stat_sn @@ got unsigned int [usertype] @@
drivers/scsi/qedi/qedi_fw.c:1031:42: sparse: expected restricted __le32 [addressable] [assigned] [usertype] exp_stat_sn
drivers/scsi/qedi/qedi_fw.c:1031:42: sparse: got unsigned int [usertype]
drivers/scsi/qedi/qedi_fw.c:1037:45: sparse: sparse: incorrect type in assignment (different base types) @@ expected restricted __le32 [addressable] [assigned] [usertype] lo @@ got unsigned int [usertype] @@
drivers/scsi/qedi/qedi_fw.c:1037:45: sparse: expected restricted __le32 [addressable] [assigned] [usertype] lo
drivers/scsi/qedi/qedi_fw.c:1037:45: sparse: got unsigned int [usertype]
>> drivers/scsi/qedi/qedi_fw.c:1039:45: sparse: sparse: incorrect type in assignment (different base types) @@ expected restricted __le32 [addressable] [assigned] [usertype] hi @@ got unsigned int [usertype] @@
drivers/scsi/qedi/qedi_fw.c:1039:45: sparse: expected restricted __le32 [addressable] [assigned] [usertype] hi
drivers/scsi/qedi/qedi_fw.c:1039:45: sparse: got unsigned int [usertype]
drivers/scsi/qedi/qedi_fw.c:1046:45: sparse: sparse: incorrect type in assignment (different base types) @@ expected restricted __le32 [addressable] [assigned] [usertype] lo @@ got unsigned int [usertype] @@
drivers/scsi/qedi/qedi_fw.c:1046:45: sparse: expected restricted __le32 [addressable] [assigned] [usertype] lo
drivers/scsi/qedi/qedi_fw.c:1046:45: sparse: got unsigned int [usertype]
drivers/scsi/qedi/qedi_fw.c:1048:45: sparse: sparse: incorrect type in assignment (different base types) @@ expected restricted __le32 [addressable] [assigned] [usertype] hi @@ got unsigned int [usertype] @@
drivers/scsi/qedi/qedi_fw.c:1048:45: sparse: expected restricted __le32 [addressable] [assigned] [usertype] hi
drivers/scsi/qedi/qedi_fw.c:1048:45: sparse: got unsigned int [usertype]
drivers/scsi/qedi/qedi_fw.c:1050:46: sparse: sparse: too many warnings
vim +1039 drivers/scsi/qedi/qedi_fw.c
be086e7c53f1fa Mintz, Yuval 2017-03-11 978
ace7f46ba5fde7 Manish Rangankar 2016-12-01 979 int qedi_send_iscsi_login(struct qedi_conn *qedi_conn,
ace7f46ba5fde7 Manish Rangankar 2016-12-01 980 struct iscsi_task *task)
ace7f46ba5fde7 Manish Rangankar 2016-12-01 981 {
be086e7c53f1fa Mintz, Yuval 2017-03-11 982 struct iscsi_login_req_hdr login_req_pdu_header;
be086e7c53f1fa Mintz, Yuval 2017-03-11 983 struct scsi_sgl_task_params tx_sgl_task_params;
be086e7c53f1fa Mintz, Yuval 2017-03-11 984 struct scsi_sgl_task_params rx_sgl_task_params;
be086e7c53f1fa Mintz, Yuval 2017-03-11 985 struct iscsi_task_params task_params;
21dd79e82f00b2 Tomer Tayar 2017-12-27 986 struct e4_iscsi_task_context *fw_task_ctx;
be086e7c53f1fa Mintz, Yuval 2017-03-11 987 struct qedi_ctx *qedi = qedi_conn->qedi;
ace7f46ba5fde7 Manish Rangankar 2016-12-01 988 struct iscsi_login_req *login_hdr;
be086e7c53f1fa Mintz, Yuval 2017-03-11 989 struct scsi_sge *resp_sge = NULL;
ace7f46ba5fde7 Manish Rangankar 2016-12-01 990 struct qedi_cmd *qedi_cmd;
be086e7c53f1fa Mintz, Yuval 2017-03-11 991 struct qedi_endpoint *ep;
ace7f46ba5fde7 Manish Rangankar 2016-12-01 992 s16 tid = 0;
be086e7c53f1fa Mintz, Yuval 2017-03-11 993 u16 sq_idx = 0;
be086e7c53f1fa Mintz, Yuval 2017-03-11 994 int rval = 0;
ace7f46ba5fde7 Manish Rangankar 2016-12-01 995
be086e7c53f1fa Mintz, Yuval 2017-03-11 996 resp_sge = (struct scsi_sge *)qedi_conn->gen_pdu.resp_bd_tbl;
ace7f46ba5fde7 Manish Rangankar 2016-12-01 997 qedi_cmd = (struct qedi_cmd *)task->dd_data;
be086e7c53f1fa Mintz, Yuval 2017-03-11 998 ep = qedi_conn->ep;
ace7f46ba5fde7 Manish Rangankar 2016-12-01 999 login_hdr = (struct iscsi_login_req *)task->hdr;
ace7f46ba5fde7 Manish Rangankar 2016-12-01 1000
ace7f46ba5fde7 Manish Rangankar 2016-12-01 1001 tid = qedi_get_task_idx(qedi);
ace7f46ba5fde7 Manish Rangankar 2016-12-01 1002 if (tid == -1)
ace7f46ba5fde7 Manish Rangankar 2016-12-01 1003 return -ENOMEM;
ace7f46ba5fde7 Manish Rangankar 2016-12-01 1004
be086e7c53f1fa Mintz, Yuval 2017-03-11 1005 fw_task_ctx =
21dd79e82f00b2 Tomer Tayar 2017-12-27 1006 (struct e4_iscsi_task_context *)qedi_get_task_mem(&qedi->tasks,
21dd79e82f00b2 Tomer Tayar 2017-12-27 1007 tid);
21dd79e82f00b2 Tomer Tayar 2017-12-27 1008 memset(fw_task_ctx, 0, sizeof(struct e4_iscsi_task_context));
ace7f46ba5fde7 Manish Rangankar 2016-12-01 1009
ace7f46ba5fde7 Manish Rangankar 2016-12-01 1010 qedi_cmd->task_id = tid;
ace7f46ba5fde7 Manish Rangankar 2016-12-01 1011
be086e7c53f1fa Mintz, Yuval 2017-03-11 1012 memset(&task_params, 0, sizeof(task_params));
be086e7c53f1fa Mintz, Yuval 2017-03-11 1013 memset(&login_req_pdu_header, 0, sizeof(login_req_pdu_header));
be086e7c53f1fa Mintz, Yuval 2017-03-11 1014 memset(&tx_sgl_task_params, 0, sizeof(tx_sgl_task_params));
be086e7c53f1fa Mintz, Yuval 2017-03-11 1015 memset(&rx_sgl_task_params, 0, sizeof(rx_sgl_task_params));
be086e7c53f1fa Mintz, Yuval 2017-03-11 1016 /* Update header info */
be086e7c53f1fa Mintz, Yuval 2017-03-11 1017 login_req_pdu_header.opcode = login_hdr->opcode;
be086e7c53f1fa Mintz, Yuval 2017-03-11 1018 login_req_pdu_header.version_min = login_hdr->min_version;
be086e7c53f1fa Mintz, Yuval 2017-03-11 1019 login_req_pdu_header.version_max = login_hdr->max_version;
be086e7c53f1fa Mintz, Yuval 2017-03-11 1020 login_req_pdu_header.flags_attr = login_hdr->flags;
be086e7c53f1fa Mintz, Yuval 2017-03-11 1021 login_req_pdu_header.isid_tabc = swab32p((u32 *)login_hdr->isid);
be086e7c53f1fa Mintz, Yuval 2017-03-11 1022 login_req_pdu_header.isid_d = swab16p((u16 *)&login_hdr->isid[4]);
be086e7c53f1fa Mintz, Yuval 2017-03-11 1023
be086e7c53f1fa Mintz, Yuval 2017-03-11 1024 login_req_pdu_header.tsih = login_hdr->tsih;
be086e7c53f1fa Mintz, Yuval 2017-03-11 1025 login_req_pdu_header.hdr_second_dword = ntoh24(login_hdr->dlength);
be086e7c53f1fa Mintz, Yuval 2017-03-11 1026
ace7f46ba5fde7 Manish Rangankar 2016-12-01 1027 qedi_update_itt_map(qedi, tid, task->itt, qedi_cmd);
be086e7c53f1fa Mintz, Yuval 2017-03-11 1028 login_req_pdu_header.itt = qedi_set_itt(tid, get_itt(task->itt));
be086e7c53f1fa Mintz, Yuval 2017-03-11 1029 login_req_pdu_header.cid = qedi_conn->iscsi_conn_id;
be086e7c53f1fa Mintz, Yuval 2017-03-11 1030 login_req_pdu_header.cmd_sn = be32_to_cpu(login_hdr->cmdsn);
be086e7c53f1fa Mintz, Yuval 2017-03-11 1031 login_req_pdu_header.exp_stat_sn = be32_to_cpu(login_hdr->exp_statsn);
be086e7c53f1fa Mintz, Yuval 2017-03-11 1032 login_req_pdu_header.exp_stat_sn = 0;
be086e7c53f1fa Mintz, Yuval 2017-03-11 1033
be086e7c53f1fa Mintz, Yuval 2017-03-11 1034 /* Fill tx AHS and rx buffer */
be086e7c53f1fa Mintz, Yuval 2017-03-11 1035 tx_sgl_task_params.sgl =
be086e7c53f1fa Mintz, Yuval 2017-03-11 1036 (struct scsi_sge *)qedi_conn->gen_pdu.req_bd_tbl;
be086e7c53f1fa Mintz, Yuval 2017-03-11 1037 tx_sgl_task_params.sgl_phys_addr.lo =
be086e7c53f1fa Mintz, Yuval 2017-03-11 1038 (u32)(qedi_conn->gen_pdu.req_dma_addr);
be086e7c53f1fa Mintz, Yuval 2017-03-11 @1039 tx_sgl_task_params.sgl_phys_addr.hi =
ace7f46ba5fde7 Manish Rangankar 2016-12-01 1040 (u32)((u64)qedi_conn->gen_pdu.req_dma_addr >> 32);
be086e7c53f1fa Mintz, Yuval 2017-03-11 1041 tx_sgl_task_params.total_buffer_size = ntoh24(login_hdr->dlength);
be086e7c53f1fa Mintz, Yuval 2017-03-11 1042 tx_sgl_task_params.num_sges = 1;
be086e7c53f1fa Mintz, Yuval 2017-03-11 1043
be086e7c53f1fa Mintz, Yuval 2017-03-11 1044 rx_sgl_task_params.sgl =
be086e7c53f1fa Mintz, Yuval 2017-03-11 1045 (struct scsi_sge *)qedi_conn->gen_pdu.resp_bd_tbl;
be086e7c53f1fa Mintz, Yuval 2017-03-11 1046 rx_sgl_task_params.sgl_phys_addr.lo =
be086e7c53f1fa Mintz, Yuval 2017-03-11 1047 (u32)(qedi_conn->gen_pdu.resp_dma_addr);
be086e7c53f1fa Mintz, Yuval 2017-03-11 1048 rx_sgl_task_params.sgl_phys_addr.hi =
be086e7c53f1fa Mintz, Yuval 2017-03-11 1049 (u32)((u64)qedi_conn->gen_pdu.resp_dma_addr >> 32);
be086e7c53f1fa Mintz, Yuval 2017-03-11 1050 rx_sgl_task_params.total_buffer_size = resp_sge->sge_len;
be086e7c53f1fa Mintz, Yuval 2017-03-11 1051 rx_sgl_task_params.num_sges = 1;
be086e7c53f1fa Mintz, Yuval 2017-03-11 1052
be086e7c53f1fa Mintz, Yuval 2017-03-11 1053 /* Fill fw input params */
be086e7c53f1fa Mintz, Yuval 2017-03-11 1054 task_params.context = fw_task_ctx;
be086e7c53f1fa Mintz, Yuval 2017-03-11 1055 task_params.conn_icid = (u16)qedi_conn->iscsi_conn_id;
be086e7c53f1fa Mintz, Yuval 2017-03-11 1056 task_params.itid = tid;
be086e7c53f1fa Mintz, Yuval 2017-03-11 1057 task_params.cq_rss_number = 0;
be086e7c53f1fa Mintz, Yuval 2017-03-11 1058 task_params.tx_io_size = ntoh24(login_hdr->dlength);
be086e7c53f1fa Mintz, Yuval 2017-03-11 1059 task_params.rx_io_size = resp_sge->sge_len;
be086e7c53f1fa Mintz, Yuval 2017-03-11 1060
be086e7c53f1fa Mintz, Yuval 2017-03-11 1061 sq_idx = qedi_get_wqe_idx(qedi_conn);
be086e7c53f1fa Mintz, Yuval 2017-03-11 1062 task_params.sqe = &ep->sq[sq_idx];
be086e7c53f1fa Mintz, Yuval 2017-03-11 1063
be086e7c53f1fa Mintz, Yuval 2017-03-11 1064 memset(task_params.sqe, 0, sizeof(struct iscsi_wqe));
be086e7c53f1fa Mintz, Yuval 2017-03-11 1065 rval = init_initiator_login_request_task(&task_params,
be086e7c53f1fa Mintz, Yuval 2017-03-11 1066 &login_req_pdu_header,
be086e7c53f1fa Mintz, Yuval 2017-03-11 1067 &tx_sgl_task_params,
be086e7c53f1fa Mintz, Yuval 2017-03-11 1068 &rx_sgl_task_params);
be086e7c53f1fa Mintz, Yuval 2017-03-11 1069 if (rval)
be086e7c53f1fa Mintz, Yuval 2017-03-11 1070 return -1;
ace7f46ba5fde7 Manish Rangankar 2016-12-01 1071
ace7f46ba5fde7 Manish Rangankar 2016-12-01 1072 spin_lock(&qedi_conn->list_lock);
ace7f46ba5fde7 Manish Rangankar 2016-12-01 1073 list_add_tail(&qedi_cmd->io_cmd, &qedi_conn->active_cmd_list);
ace7f46ba5fde7 Manish Rangankar 2016-12-01 1074 qedi_cmd->io_cmd_in_list = true;
ace7f46ba5fde7 Manish Rangankar 2016-12-01 1075 qedi_conn->active_cmd_count++;
ace7f46ba5fde7 Manish Rangankar 2016-12-01 1076 spin_unlock(&qedi_conn->list_lock);
ace7f46ba5fde7 Manish Rangankar 2016-12-01 1077
ace7f46ba5fde7 Manish Rangankar 2016-12-01 1078 qedi_ring_doorbell(qedi_conn);
ace7f46ba5fde7 Manish Rangankar 2016-12-01 1079 return 0;
ace7f46ba5fde7 Manish Rangankar 2016-12-01 1080 }
ace7f46ba5fde7 Manish Rangankar 2016-12-01 1081
:::::: The code at line 1039 was first introduced by commit
:::::: be086e7c53f1fac51eed14523b28f2214b548dd2 qed*: Utilize Firmware 8.15.3.0
:::::: TO: Mintz, Yuval <Yuval.Mintz@cavium.com>
:::::: CC: David S. Miller <davem@davemloft.net>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 68144 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [linux-next:master 6351/6976] drivers/scsi/qedi/qedi_fw.c:1039:45: sparse: sparse: incorrect type in assignment (different base types)
2021-06-03 17:10 ` kernel test robot
@ 2021-06-03 20:18 ` Mike Christie
-1 siblings, 0 replies; 6+ messages in thread
From: Mike Christie @ 2021-06-03 20:18 UTC (permalink / raw)
To: kernel test robot
Cc: kbuild-all, Linux Memory Management List, Martin K. Petersen,
Manish Rangankar
On 6/3/21 12:10 PM, kernel test robot wrote:
> tree: https://urldefense.com/v3/__https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git__;!!GqivPVa7Brio!L-QQ6Mx-OZszOnFdN5lLFW-jo2vsB4dfH_ouv1FJdtmad2ZuSk4O5BrtZy-la7gW8-n1$ master
> head: 3ebdbe7aa5dd825d609c3433c35c13b440a61c52
> commit: ed1b86ba0fba3d586cd53057551a95197b0a37ad [6351/6976] scsi: qedi: Wake up if cmd_cleanup_req is set
I don't think this patch caused the issue being reported. It only touched
qedi_process_cmd_cleanup_resp but the new warning is in qedi_send_iscsi_login. Tt
also didn't add any new warnings in qedi_process_cmd_cleanup_resp:
> drivers/scsi/qedi/qedi_fw.c:741:28: sparse: sparse: incorrect type in initializer (different base types) @@ expected unsigned int [usertype] proto_itt @@ got restricted __le16 [usertype] itid @@
> drivers/scsi/qedi/qedi_fw.c:741:28: sparse: expected unsigned int [usertype] proto_itt
> drivers/scsi/qedi/qedi_fw.c:741:28: sparse: got restricted __le16 [usertype] itid
> drivers/scsi/qedi/qedi_fw.c:751:19: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned int [usertype] iscsi_cid @@ got restricted __le16 [usertype] conn_id @@
> drivers/scsi/qedi/qedi_fw.c:751:19: sparse: expected unsigned int [usertype] iscsi_cid
> drivers/scsi/qedi/qedi_fw.c:751:19: sparse: got restricted __le16 [usertype] conn_id
> drivers/scsi/qedi/qedi_fw.c:802:9: sparse: sparse: cast to restricted itt_t
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [linux-next:master 6351/6976] drivers/scsi/qedi/qedi_fw.c:1039:45: sparse: sparse: incorrect type in assignment (different base types)
@ 2021-06-03 20:18 ` Mike Christie
0 siblings, 0 replies; 6+ messages in thread
From: Mike Christie @ 2021-06-03 20:18 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 1521 bytes --]
On 6/3/21 12:10 PM, kernel test robot wrote:
> tree: https://urldefense.com/v3/__https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git__;!!GqivPVa7Brio!L-QQ6Mx-OZszOnFdN5lLFW-jo2vsB4dfH_ouv1FJdtmad2ZuSk4O5BrtZy-la7gW8-n1$ master
> head: 3ebdbe7aa5dd825d609c3433c35c13b440a61c52
> commit: ed1b86ba0fba3d586cd53057551a95197b0a37ad [6351/6976] scsi: qedi: Wake up if cmd_cleanup_req is set
I don't think this patch caused the issue being reported. It only touched
qedi_process_cmd_cleanup_resp but the new warning is in qedi_send_iscsi_login. Tt
also didn't add any new warnings in qedi_process_cmd_cleanup_resp:
> drivers/scsi/qedi/qedi_fw.c:741:28: sparse: sparse: incorrect type in initializer (different base types) @@ expected unsigned int [usertype] proto_itt @@ got restricted __le16 [usertype] itid @@
> drivers/scsi/qedi/qedi_fw.c:741:28: sparse: expected unsigned int [usertype] proto_itt
> drivers/scsi/qedi/qedi_fw.c:741:28: sparse: got restricted __le16 [usertype] itid
> drivers/scsi/qedi/qedi_fw.c:751:19: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned int [usertype] iscsi_cid @@ got restricted __le16 [usertype] conn_id @@
> drivers/scsi/qedi/qedi_fw.c:751:19: sparse: expected unsigned int [usertype] iscsi_cid
> drivers/scsi/qedi/qedi_fw.c:751:19: sparse: got restricted __le16 [usertype] conn_id
> drivers/scsi/qedi/qedi_fw.c:802:9: sparse: sparse: cast to restricted itt_t
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [kbuild-all] Re: [linux-next:master 6351/6976] drivers/scsi/qedi/qedi_fw.c:1039:45: sparse: sparse: incorrect type in assignment (different base types)
2021-06-03 20:18 ` Mike Christie
@ 2021-06-07 9:49 ` Rong Chen
-1 siblings, 0 replies; 6+ messages in thread
From: Rong Chen @ 2021-06-07 9:49 UTC (permalink / raw)
To: Mike Christie, kernel test robot
Cc: kbuild-all, Linux Memory Management List, Martin K. Petersen,
Manish Rangankar
On 6/4/21 4:18 AM, Mike Christie wrote:
> On 6/3/21 12:10 PM, kernel test robot wrote:
>> tree: https://urldefense.com/v3/__https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git__;!!GqivPVa7Brio!L-QQ6Mx-OZszOnFdN5lLFW-jo2vsB4dfH_ouv1FJdtmad2ZuSk4O5BrtZy-la7gW8-n1$ master
>> head: 3ebdbe7aa5dd825d609c3433c35c13b440a61c52
>> commit: ed1b86ba0fba3d586cd53057551a95197b0a37ad [6351/6976] scsi: qedi: Wake up if cmd_cleanup_req is set
> I don't think this patch caused the issue being reported. It only touched
> qedi_process_cmd_cleanup_resp but the new warning is in qedi_send_iscsi_login. Tt
> also didn't add any new warnings in qedi_process_cmd_cleanup_resp:
Hi Mike,
Sorry for the inconvenience, it's a false positive, we'll double check
such issue next time.
Best Regards,
Rong Chen
>
>> drivers/scsi/qedi/qedi_fw.c:741:28: sparse: sparse: incorrect type in initializer (different base types) @@ expected unsigned int [usertype] proto_itt @@ got restricted __le16 [usertype] itid @@
>> drivers/scsi/qedi/qedi_fw.c:741:28: sparse: expected unsigned int [usertype] proto_itt
>> drivers/scsi/qedi/qedi_fw.c:741:28: sparse: got restricted __le16 [usertype] itid
>> drivers/scsi/qedi/qedi_fw.c:751:19: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned int [usertype] iscsi_cid @@ got restricted __le16 [usertype] conn_id @@
>> drivers/scsi/qedi/qedi_fw.c:751:19: sparse: expected unsigned int [usertype] iscsi_cid
>> drivers/scsi/qedi/qedi_fw.c:751:19: sparse: got restricted __le16 [usertype] conn_id
>> drivers/scsi/qedi/qedi_fw.c:802:9: sparse: sparse: cast to restricted itt_t
> _______________________________________________
> kbuild-all mailing list -- kbuild-all@lists.01.org
> To unsubscribe send an email to kbuild-all-leave@lists.01.org
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [linux-next:master 6351/6976] drivers/scsi/qedi/qedi_fw.c:1039:45: sparse: sparse: incorrect type in assignment (different base types)
@ 2021-06-07 9:49 ` Rong Chen
0 siblings, 0 replies; 6+ messages in thread
From: Rong Chen @ 2021-06-07 9:49 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 1906 bytes --]
On 6/4/21 4:18 AM, Mike Christie wrote:
> On 6/3/21 12:10 PM, kernel test robot wrote:
>> tree: https://urldefense.com/v3/__https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git__;!!GqivPVa7Brio!L-QQ6Mx-OZszOnFdN5lLFW-jo2vsB4dfH_ouv1FJdtmad2ZuSk4O5BrtZy-la7gW8-n1$ master
>> head: 3ebdbe7aa5dd825d609c3433c35c13b440a61c52
>> commit: ed1b86ba0fba3d586cd53057551a95197b0a37ad [6351/6976] scsi: qedi: Wake up if cmd_cleanup_req is set
> I don't think this patch caused the issue being reported. It only touched
> qedi_process_cmd_cleanup_resp but the new warning is in qedi_send_iscsi_login. Tt
> also didn't add any new warnings in qedi_process_cmd_cleanup_resp:
Hi Mike,
Sorry for the inconvenience, it's a false positive, we'll double check
such issue next time.
Best Regards,
Rong Chen
>
>> drivers/scsi/qedi/qedi_fw.c:741:28: sparse: sparse: incorrect type in initializer (different base types) @@ expected unsigned int [usertype] proto_itt @@ got restricted __le16 [usertype] itid @@
>> drivers/scsi/qedi/qedi_fw.c:741:28: sparse: expected unsigned int [usertype] proto_itt
>> drivers/scsi/qedi/qedi_fw.c:741:28: sparse: got restricted __le16 [usertype] itid
>> drivers/scsi/qedi/qedi_fw.c:751:19: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned int [usertype] iscsi_cid @@ got restricted __le16 [usertype] conn_id @@
>> drivers/scsi/qedi/qedi_fw.c:751:19: sparse: expected unsigned int [usertype] iscsi_cid
>> drivers/scsi/qedi/qedi_fw.c:751:19: sparse: got restricted __le16 [usertype] conn_id
>> drivers/scsi/qedi/qedi_fw.c:802:9: sparse: sparse: cast to restricted itt_t
> _______________________________________________
> kbuild-all mailing list -- kbuild-all(a)lists.01.org
> To unsubscribe send an email to kbuild-all-leave(a)lists.01.org
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-06-07 9:49 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-03 17:10 [linux-next:master 6351/6976] drivers/scsi/qedi/qedi_fw.c:1039:45: sparse: sparse: incorrect type in assignment (different base types) kernel test robot
2021-06-03 17:10 ` kernel test robot
2021-06-03 20:18 ` Mike Christie
2021-06-03 20:18 ` Mike Christie
2021-06-07 9:49 ` [kbuild-all] " Rong Chen
2021-06-07 9:49 ` Rong Chen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.