From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA902C432BE for ; Thu, 2 Sep 2021 06:12:45 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8BAF961041 for ; Thu, 2 Sep 2021 06:12:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 8BAF961041 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=amsat.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:56148 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mLfxs-0004vf-Q4 for qemu-devel@archiver.kernel.org; Thu, 02 Sep 2021 02:12:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43368) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mLfwg-0003Ju-4F; Thu, 02 Sep 2021 02:11:30 -0400 Received: from mail-wm1-x333.google.com ([2a00:1450:4864:20::333]:33392) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mLfwb-0007lr-Cj; Thu, 02 Sep 2021 02:11:29 -0400 Received: by mail-wm1-x333.google.com with SMTP id 192-20020a1c04c9000000b002f7a4ab0a49so468548wme.0; Wed, 01 Sep 2021 23:11:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:subject:from:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=SwS2yU3eNtA/0jXdXLasMfEAQTNQV8yAzA0XBOzs7/Q=; b=jYWLyjla0fJGuaN9opTfmg8V0lznnrsAkxC4i58ORnrQXSeYI9ZSqm+nUOfp89fLpU +AKArW8Wjpk0/ao0kXBE2GyU8KcH8D62DZ08YATj+iw9dnuGSH8wl/94s9fXPJUvX9hD mMMAGBV706pL9/tDLnkzfxUhBwGH59JjgF/+RkiBPTiqfYe/nN9BKDHQ8iaqBdGOWiNq z1yE7hM3/B+62xwCR+h+iH+zy0cQrje5BsQxsiwFao9iBsYiu15hG8S5t/Jxq92cJFu5 OYX7Vu2xIzMPtjqTxR52kriCbhwbEoaXKt7QMPTY24MdtXz/dU3gl3kfbqJxPvF6/NPu ITqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:from:to:cc:references:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=SwS2yU3eNtA/0jXdXLasMfEAQTNQV8yAzA0XBOzs7/Q=; b=NTBWWS4/Ofn6o84ah5Tt1BQeWnw0yyedQ5zVWmk1NBlvaQDLOvv8vbdH3cjKBP6UwG 1TmJAnVcIxJqbKSEaHY5R9Ys/sfYUStcBV7IDi/ZfC3DgjsC9NAUvwGDDPZKuyWgjdjB RWhXkybMsCxqXERaYMlTUxk2sxUgD+SXwlK12/8M6o5eMyhZKJNop7d0yXPagoIe1/rw iYUmhwcIPgWcxKiRc1a8W3impUKmNGDxsqnpuH3JfiF/+m4bGDp7O8ULeKH2SdEWxzj/ 89O//fmf/xt37mciGNuNf/YC6p2L4uXezctwHYDoTyXIIsUOXnnwDaxEsEc8dklxnUDU 6KHA== X-Gm-Message-State: AOAM533MsC34oUp3UXVg5ba5gE0i/v+HELtH6gtdEtUgIq3I+iG46qBS Mz4tzqM+PS6sadWO1APxPiNbRHl2U/8= X-Google-Smtp-Source: ABdhPJz/gnIAYv8+u2bhr+bC3RgLH8xuAD1maFur1gQc3qrlBsAodHcEq7W+NRnQIyblL8Z1JMtRqA== X-Received: by 2002:a05:600c:3656:: with SMTP id y22mr1367187wmq.58.1630563083397; Wed, 01 Sep 2021 23:11:23 -0700 (PDT) Received: from [192.168.1.36] (163.red-83-52-55.dynamicip.rima-tde.net. [83.52.55.163]) by smtp.gmail.com with ESMTPSA id p13sm824173wro.8.2021.09.01.23.11.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Sep 2021 23:11:22 -0700 (PDT) Subject: Re: [PATCH v2 5/5] hw/char: cadence_uart: Ignore access when unclocked or in reset for uart_{read, write}() From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= To: Bin Meng , Damien Hedde , "Edgar E . Iglesias" , Alistair Francis , Peter Maydell References: <20210901032724.23256-1-bmeng.cn@gmail.com> <20210901032724.23256-6-bmeng.cn@gmail.com> <869636f3-6e6a-d5d3-e377-1634f8165aa4@amsat.org> Message-ID: Date: Thu, 2 Sep 2021 08:11:21 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <869636f3-6e6a-d5d3-e377-1634f8165aa4@amsat.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::333; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-x333.google.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.25, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, NICE_REPLY_A=-1.029, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-arm@nongnu.org, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 9/2/21 8:09 AM, Philippe Mathieu-Daudé wrote: > On 9/1/21 5:27 AM, Bin Meng wrote: >> Read or write to uart registers when unclocked or in reset should be >> ignored. Add the check there, and as a result of this, the check in >> uart_write_tx_fifo() is now unnecessary. >> >> Signed-off-by: Bin Meng >> >> --- >> >> Changes in v2: >> - new patch: hw/char: cadence_uart: Ignore access when unclocked or in reset for uart_{read,write}() >> >> hw/char/cadence_uart.c | 15 ++++++++++----- >> 1 file changed, 10 insertions(+), 5 deletions(-) > > Reviewed-by: Philippe Mathieu-Daudé Just realized it is simpler to implement MemoryRegionOps::accepts().