From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sudeep Holla Subject: Re: [PATCH] arm64: tegra: Add CPU and PSCI nodes for NVIDIA Tegra210 platforms Date: Tue, 28 Mar 2017 15:55:02 +0100 Message-ID: References: <1490701718-16571-1-git-send-email-jonathanh@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1490701718-16571-1-git-send-email-jonathanh@nvidia.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Jon Hunter , Thierry Reding , Stephen Warren Cc: devicetree@vger.kernel.org, Vagrant Cascadian , Sudeep Holla , linux-tegra@vger.kernel.org, Martin Michlmayr , linux-arm-kernel@lists.infradead.org List-Id: linux-tegra@vger.kernel.org On 28/03/17 12:48, Jon Hunter wrote: > Add the CPU and PSCI nodes for the NVIDIA Tegra210 platforms so that > all CPUs can be enabled on boot. This assumes that the PSCI firmware > has been loaded during the initial bootstrap on the device before the > kernel starts (which is typically the case for these platforms). The > PSCI firmware version is set to v0.2 which aligns with the current > shipping version for Tegra. > > Reported-by: Martin Michlmayr > Signed-off-by: Jon Hunter > --- > arch/arm64/boot/dts/nvidia/tegra210-p2180.dtsi | 23 +++++++++++++++++++++++ > arch/arm64/boot/dts/nvidia/tegra210-p2530.dtsi | 24 ++++++++++++++++++++++++ > 2 files changed, 47 insertions(+) > > diff --git a/arch/arm64/boot/dts/nvidia/tegra210-p2180.dtsi b/arch/arm64/boot/dts/nvidia/tegra210-p2180.dtsi > index 906fb836d241..de1696c28140 100644 > --- a/arch/arm64/boot/dts/nvidia/tegra210-p2180.dtsi > +++ b/arch/arm64/boot/dts/nvidia/tegra210-p2180.dtsi > @@ -296,6 +296,29 @@ > }; > }; > > + cpus { > + cpu@0 { > + enable-method = "psci"; Is some firmware expected to populate other required properties ? If yes, why not populate everything in the firmware ? If no, how does it even boot secondaries without the "reg" property that usually contains MPIDR. -- Regards, Sudeep From mboxrd@z Thu Jan 1 00:00:00 1970 From: sudeep.holla@arm.com (Sudeep Holla) Date: Tue, 28 Mar 2017 15:55:02 +0100 Subject: [PATCH] arm64: tegra: Add CPU and PSCI nodes for NVIDIA Tegra210 platforms In-Reply-To: <1490701718-16571-1-git-send-email-jonathanh@nvidia.com> References: <1490701718-16571-1-git-send-email-jonathanh@nvidia.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 28/03/17 12:48, Jon Hunter wrote: > Add the CPU and PSCI nodes for the NVIDIA Tegra210 platforms so that > all CPUs can be enabled on boot. This assumes that the PSCI firmware > has been loaded during the initial bootstrap on the device before the > kernel starts (which is typically the case for these platforms). The > PSCI firmware version is set to v0.2 which aligns with the current > shipping version for Tegra. > > Reported-by: Martin Michlmayr > Signed-off-by: Jon Hunter > --- > arch/arm64/boot/dts/nvidia/tegra210-p2180.dtsi | 23 +++++++++++++++++++++++ > arch/arm64/boot/dts/nvidia/tegra210-p2530.dtsi | 24 ++++++++++++++++++++++++ > 2 files changed, 47 insertions(+) > > diff --git a/arch/arm64/boot/dts/nvidia/tegra210-p2180.dtsi b/arch/arm64/boot/dts/nvidia/tegra210-p2180.dtsi > index 906fb836d241..de1696c28140 100644 > --- a/arch/arm64/boot/dts/nvidia/tegra210-p2180.dtsi > +++ b/arch/arm64/boot/dts/nvidia/tegra210-p2180.dtsi > @@ -296,6 +296,29 @@ > }; > }; > > + cpus { > + cpu at 0 { > + enable-method = "psci"; Is some firmware expected to populate other required properties ? If yes, why not populate everything in the firmware ? If no, how does it even boot secondaries without the "reg" property that usually contains MPIDR. -- Regards, Sudeep