From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3815C433B4 for ; Tue, 11 May 2021 15:45:13 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 481AF61260 for ; Tue, 11 May 2021 15:45:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 481AF61260 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:52320 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lgUZM-0007W4-2G for qemu-devel@archiver.kernel.org; Tue, 11 May 2021 11:45:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34776) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lgUVB-0001dO-M2 for qemu-devel@nongnu.org; Tue, 11 May 2021 11:40:58 -0400 Received: from mail-oi1-x232.google.com ([2607:f8b0:4864:20::232]:45643) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lgUV8-00033C-Jn for qemu-devel@nongnu.org; Tue, 11 May 2021 11:40:53 -0400 Received: by mail-oi1-x232.google.com with SMTP id n184so19368419oia.12 for ; Tue, 11 May 2021 08:40:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=GjmP8ROM6jP1J2MLXt3zFMStlYNvzSp5sjSiLAcEdf8=; b=lz+HGdih86UyWzw/z3KN/SU7q2jBJx8bhyY4ZSV2cxoeFzrRtUudK/gNC19++Ph6Qk T9ZWmVz8aFHk86YAdbPTJSvI7FVtkI/Fy/nJwGL4UOCbyQTLZ5+08/aW//RHG2bg5NP7 24jUaZPIavkHkENgWmAEj653TL+8pw4y+HJGHC/0GgNuzKNgApBs2Vcfg7vsFz7Df5ye cTSFnCVtQm3iRYPdiiVEy0gWZkrqv0aackCf/wi8vqtf9PHXaFTup3mqzDFoUEU1sKkY 9HtKrESfffOsjRhZ4UY9gqsl9GAjVdtezeTc7BxNu1vE3YrJZXw4Y4l8AkrPiQ2KE7Mf pGIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=GjmP8ROM6jP1J2MLXt3zFMStlYNvzSp5sjSiLAcEdf8=; b=To0EyhnhLWn/4KHhuE/0v9/CzgmkeZJ5a2Xf2sQCAQhIsYnjnL1txVpKHzFKXLYkQi H7sFPH3D6d9zlOKkvPaAokVxC9IGzFuTdyUnujNNVDJwHKUekiDhMfudXMm9O85ygjwB xSyKgzH0CJ6BdxA9/ymidzrYKxLLJ6/XLVqgyqrXpaJjFX+jDfW0vL8iA6ns/A+k6kOH rrRTREhEjk0u3S5xfZWe6OtGxV50rNkaN/QXCbXd3v/Lrb4pgdqE2yiPe1YmfJeYzL45 mjDHV2NTiCemmwxEeqEqwypO8GIeDK/uPYeQ7Ry/j2RdGUaPuWl/ZxtpxeOgCwNzOWmC 51wQ== X-Gm-Message-State: AOAM532/SO4emRS+AWow16ej6gQhx8To6MGh6GnDXIxnbgWcIGm8tJ++ +FD1h8X7MLaYnFg71/JYMbU+dA== X-Google-Smtp-Source: ABdhPJxqxOODQ7OUHwsLJYl5u45LKYhS0P51sNeshjHniUDrmQrzsm13URgkqSCzI6T4n3f8Mh0jJA== X-Received: by 2002:aca:ba09:: with SMTP id k9mr22249923oif.178.1620747648522; Tue, 11 May 2021 08:40:48 -0700 (PDT) Received: from [192.168.180.118] (163.189-204-200.bestelclientes.com.mx. [189.204.200.163]) by smtp.gmail.com with ESMTPSA id n98sm3863445ota.24.2021.05.11.08.40.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 11 May 2021 08:40:48 -0700 (PDT) Subject: Re: [PATCH v6 06/82] target/arm: Implement SVE2 saturating/rounding bitwise shift left (predicated) To: Peter Maydell References: <20210430202610.1136687-1-richard.henderson@linaro.org> <20210430202610.1136687-7-richard.henderson@linaro.org> From: Richard Henderson Message-ID: Date: Tue, 11 May 2021 10:40:45 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::232; envelope-from=richard.henderson@linaro.org; helo=mail-oi1-x232.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-arm , QEMU Developers Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 5/11/21 3:43 AM, Peter Maydell wrote: >> +#define do_sqshl_d(n, m) \ >> + ({ uint32_t discard; do_sqrshl_d(n, m, false, &discard); }) > Why pass in &discard rather than just NULL ? (Similarly below.) sat != NULL means enable saturation. Discard the results because unlike NEON, there is no architectural SVE flag to indicate that saturation has occurred. r~