From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MSGID_FROM_MTA_HEADER,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D6CAC11F68 for ; Fri, 2 Jul 2021 08:37:03 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B5A67613BC for ; Fri, 2 Jul 2021 08:37:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B5A67613BC Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=prevas.dk Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 3D69080C68; Fri, 2 Jul 2021 10:37:00 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=reject dis=none) header.from=prevas.dk Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=prevas.dk header.i=@prevas.dk header.b="RVNZN8aE"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id C086880F3A; Fri, 2 Jul 2021 10:36:58 +0200 (CEST) Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-am5eur03on0728.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe08::728]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 1580B80224 for ; Fri, 2 Jul 2021 10:36:56 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=reject dis=none) header.from=prevas.dk Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=rasmus.villemoes@prevas.dk ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cvVTczHX6wjAp46Ip7uA9bg4/fwmEuhmMpmQWEy2eUZpla373S+3eUB5Wpbsaiv8xjuivrYLQG9H02OJRdpnOhMyN3KHifpmzW1gEJvYUYQTgKVJPB8qXKA0H5d5o6s0g5slclXl579XZxJwV22yGgM49HZtd6+N7U/ZMw+Ho9SK6f8rKwLvzhUOspOm2xjSOiwQiocpGtuehYhQT298YH+YYFSTQkqpGTFB1QpNq7y5EpuxFj9ijIa2CB/mbALZ6JoypcX0cml2EfKYz4gojlY0hHTl7fItMrrLqNdlASpWAQqn4fqG3YFdJH36B7TMucJN4o/m6M5ZhLnvFsmLVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yRFUhCQpMFPGPnD6ZAWyk62w5Aj4ej1hs3VDCu+5iKM=; b=mb2i0vu9JuO0IdGggZKHPoP95KxNywP2dBcMsGcHgpwB/irQIEZ8rtQMBfZ54odqww6jYsSrfJ9rYZu4ljacqWp9S/rgzaqzQqN9vCBu3bz7ndcm3R4DM4a1Bb5/8KHAk0cJDNVHDjKnaW6JhcQT9/cGwIFxegnpf7lKD0+8ohbideLJp0TFRXYnKFGzZCJ+vpiOoGtgJq7iAnB30CGSbR2wmh6fCZjisSNt8DBYszGuhIpW/7pIWNOqUTMqtcIizz2caNtqNN8216t2mQhGWoiBtenyDqqrM5TUphbHvgNTVa/EJJTpl01Abo9HayXkEwt6aiye8hF3JEPNYYRsCQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=prevas.dk; dmarc=pass action=none header.from=prevas.dk; dkim=pass header.d=prevas.dk; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=prevas.dk; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yRFUhCQpMFPGPnD6ZAWyk62w5Aj4ej1hs3VDCu+5iKM=; b=RVNZN8aEqi3tYUyXvHlEMfHJ1k+pk2w2dps6QpqiEQgi0akO1fnqZSneINDc8GwIMI5n0FAkDhY9qHy1UnD59cbjXxG23uTPlWwFqwBRaWsK6lEjkb08nGk1bbP10MjbL2a4o5rRMulzV4j8O5IDkmkmLlajJt/YgbDzvWh0i0E= Authentication-Results: runtimeterror.com; dkim=none (message not signed) header.d=none;runtimeterror.com; dmarc=none action=none header.from=prevas.dk; Received: from AM0PR10MB1874.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:208:3f::10) by AM9PR10MB4370.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:26e::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.27; Fri, 2 Jul 2021 08:36:54 +0000 Received: from AM0PR10MB1874.EURPRD10.PROD.OUTLOOK.COM ([fe80::fc83:36a5:db02:3dbb]) by AM0PR10MB1874.EURPRD10.PROD.OUTLOOK.COM ([fe80::fc83:36a5:db02:3dbb%7]) with mapi id 15.20.4287.029; Fri, 2 Jul 2021 08:36:54 +0000 Subject: Re: [RFC PATCH 03/28] cli: lil: Replace strclone with strdup To: Sean Anderson , u-boot@lists.denx.de, Tom Rini Cc: =?UTF-8?Q?Marek_Beh=c3=ban?= , Wolfgang Denk , Simon Glass , Roland Gaudig , Heinrich Schuchardt , Kostas Michalopoulos References: <20210701061611.957918-1-seanga2@gmail.com> <20210701061611.957918-4-seanga2@gmail.com> From: Rasmus Villemoes Message-ID: Date: Fri, 2 Jul 2021 10:36:52 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 In-Reply-To: <20210701061611.957918-4-seanga2@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [80.208.64.110] X-ClientProxiedBy: BE0P281CA0012.DEUP281.PROD.OUTLOOK.COM (2603:10a6:b10:a::22) To AM0PR10MB1874.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:208:3f::10) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.1.149] (80.208.64.110) by BE0P281CA0012.DEUP281.PROD.OUTLOOK.COM (2603:10a6:b10:a::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4308.8 via Frontend Transport; Fri, 2 Jul 2021 08:36:53 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5d8ff4c5-8334-4d28-1b30-08d93d348bad X-MS-TrafficTypeDiagnostic: AM9PR10MB4370: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qs8AA5Gc+WkI9oEP3zh6Z1UbfqgyTJN4mkOJfROdHJZIIGubmD7p6bLN669ibDbK/e3utNucHYn92xw1y4QG7l+bCaLriVz+TG0OGrkDjv8Me83jqV4evzdhKHaB6WopIcF+uBG0U80FUrPuBXgNDt+ioCUZ+PrZrOL0pfAIznzzTlUvd0PSWj3A/G1ZiplE2M1SHfhrNyFO6lkuuE0YFnrVWQ1PNhPxFVUqO5Ront9j8+XOCsNEdqhgl1FTcJh21Yfl2jpzvpb0T09wJyqi5WGnHFRxbhxobBCwAEsiRKp9Zl1zIOeSVVPSYAn4nj22GWNK8jXBk/5OUxfAjvlmqb0SXNiCrXoOegz+cb+q0PXuTTDTsOom8wD3w2LtDApRtRA9E4fIIsDNiDa7w5FyYxWYuy3j32jdhBCNkTWBK1FOJoXus6WpoTh0p+LDTbzNRU6n7cv/veJYb9x88XUb5X4qKZpb7evTfjksBt84Riu/kX1eYTTHHOZ0hS5VhNoge1zNc1z8t9ihk6cP2UV/SSWtJo2Vm62QiRXoNzkDCK5PW4hiJlveV/D8y7xLvFwws8FTy9UzLcpUa/Ckw+F1sre0nATqUw8/djlTNMw/vVCPHzPWnGeaHNocuItQWDzsAZG10nMqOC2X24PMmMuHpjxdFVH3arliiQS45b8+1YqBoKGZopxBvRyJQ3qfdFZn841uPcbXqrN+ok7kga/zwCwoXjg78WpLcAHZwY+QCmas8RTKXVSASeYJprAsA7/oor4RKQfIg3rkoUPlHbFb5g== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM0PR10MB1874.EURPRD10.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(366004)(39830400003)(136003)(346002)(376002)(396003)(86362001)(2616005)(66946007)(54906003)(44832011)(4744005)(956004)(110136005)(26005)(31696002)(6486002)(5660300002)(8676002)(16576012)(478600001)(2906002)(316002)(38350700002)(83380400001)(8936002)(36756003)(52116002)(4326008)(66556008)(66476007)(31686004)(186003)(38100700002)(8976002)(16526019)(43740500002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?Windows-1252?Q?UpPjCOyYWJ9WD+CSLA3j+8OPYIhU1Eym0e5ojbmoSM7lvC/gdlCFt0LN?= =?Windows-1252?Q?r2CH/vWnzpGOrlMXntmFK5fRxeDNmJ3DGEegXShOE/e6QFfgcLSt+wkv?= =?Windows-1252?Q?1KkgZq/SH+VRruhc8SiQOlyrAkfoYiUnBQAPljK8Dm3BA8O5zjZ4D1V6?= =?Windows-1252?Q?0MYtRsjDqd2A7ME2SefmocgkNY6tvXgheGYcH2+VnMWAcSfbz7Oli8u4?= =?Windows-1252?Q?m0PvxBp0MkPK+7FtALfD6BsJI9teERG3wjcCf8klImmW2o97Du5PxmSl?= =?Windows-1252?Q?QEE1D/H6VqBIhsKcH6Q05iLa164sDmaK3Dto/R9gp0lsJ7fAVnjDIfK8?= =?Windows-1252?Q?LvxS4WWYzxXs5hW3Vwdvr9ejfoz+ESLKvrpMkm6CL0/RByxcQrmTahq8?= =?Windows-1252?Q?ZbuTnTOp4vYTzM+5+xhyAb3lRxZ7pJGP1wl8nakW6cSdAu8tP5K/HvoW?= =?Windows-1252?Q?ldOKDg7on6F/PADsE2jADresvKvzRr7hE3vpClNx+lkZ8ockSfieLqLy?= =?Windows-1252?Q?d9IkRrcW2JC2ZWQ4BwlmzpgCKr6ZpS4bjlNzhFPTOx+4yop8LAVnp1kx?= =?Windows-1252?Q?S3zS/w1FMOaPF2WXahR4CPvEyHSXZTb5k+I2pdcv4xxprvuEn+XV4Cme?= =?Windows-1252?Q?rggcqlgsn3XJcO5+ljeBW7b1znIRovz2zEvwn1tvb7p4rm305zKkv769?= =?Windows-1252?Q?JbNXHsC5vN0eN1MLVn7SuryKM2cXTYDnBRAbGD+04C9NTQrLQuUHSxi8?= =?Windows-1252?Q?TenZckhOhFZlnrl546QLwEycJUiilzoj8uTbMAcSVwzDZEFUzJJGCngc?= =?Windows-1252?Q?XW9sEwlURWgxnaKu1VQ/qly9T2bAecpkWuOzA4ZgTln0pKMbU6ONNTLB?= =?Windows-1252?Q?fEq1ID4xVVSL9rMmHvM1yePRZbKrajoNcL9OtQoxWR3jD+gwem5ybX2P?= =?Windows-1252?Q?s5MRIRWoPrgET89D/rZyBHOvMOtck4nNR4YD70ex18+57PvCz1x5W635?= =?Windows-1252?Q?Rl7kP2AxFQkyJDlIjlnISi8XNeStJNnSIcPwArdifzWQD6YyEiaAcIbr?= =?Windows-1252?Q?wjs006WJ3/8wMTbJon3z+7sBpHKWFTkT2ggOFh8xnD//YK7XKcGoZ6bq?= =?Windows-1252?Q?TXplhMX8G9Ke+CGSWNg8M7bZvUV99k3fWNGXiZNldep4sT/gFZWhIPV+?= =?Windows-1252?Q?848V0uhAqsq5Q98adiSd4N/FCFz00u25E1Mls79LDvPvlCd6Zvpa0dqk?= =?Windows-1252?Q?Gdh5VV9LyK6JpZKxnTJc9rb14IToq71ChQH9fZsE0Qto7m55KKwLfOFw?= =?Windows-1252?Q?2KZj0R3Rqr+BYhPR3APbYZ6phQJeg4gVe21S44s5SLSThmkb70DBNlAh?= =?Windows-1252?Q?MLKQig5RHShRcWRLNHLCZUfIyGqB0S5xhiXcoSd0YcUZwvzRBLU5JiFm?= X-OriginatorOrg: prevas.dk X-MS-Exchange-CrossTenant-Network-Message-Id: 5d8ff4c5-8334-4d28-1b30-08d93d348bad X-MS-Exchange-CrossTenant-AuthSource: AM0PR10MB1874.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Jul 2021 08:36:54.4565 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: d350cf71-778d-4780-88f5-071a4cb1ed61 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 5WXNhqB7lhbnksiiYp1FU6J+1xd07CG+6rSJ5SiaqmjhVByFLwfuoF8UHVaq6d/xhbYR5bWpdCuieN59Unv+4J/0LiJb6Treon7dL5yHGbU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR10MB4370 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On 01/07/2021 08.15, Sean Anderson wrote: > Apparently strdup is not portable, so LIL used its own. Use strdup. You could reduce the churn by just making strclone "#define strclone(x) strdup(x)", but I suppose you end up modifying the upstream code so much that there's not really anything gained by that. But that begs the question: What is the long-term plan for this? While it does seem to be an improvement compared to hush, will we ever be able to incorporate fixes&features from upstream, or will this code end up in the same situation as hush? Have you been in contact with upstream about this project? Perhaps some of the things you do could go upstream - e.g. the conversion from an array of wrongly-typed callbacks to an "ops" struct seems to be an obvious improvement [lil_callback would have to be kept, and changed to use a switch() statement to update the right slot, but we wouldn't have to care because ld will remove it anyway if we don't add any users of it]. Rasmus