From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87AB0C2D0CD for ; Wed, 18 Dec 2019 17:00:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5CDC6227BF for ; Wed, 18 Dec 2019 17:00:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="X5I+RWQK" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727624AbfLRRA1 (ORCPT ); Wed, 18 Dec 2019 12:00:27 -0500 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:40517 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727600AbfLRRA1 (ORCPT ); Wed, 18 Dec 2019 12:00:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1576688426; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dn5SUwiPZ6v5NQ8mtwG6iqV/r/5Gbbs8HrzPzH1EerI=; b=X5I+RWQKaKMORa2YSd2a5kZLGEHwmPKfLGmxZyfEYM+lRErqMj0Uz2B9OrYOiDDSO2vCFv jwCQkqFeIBbFhZ4VpQNH5qZnvV93uCTLdvR9KuurPhMQiSpRkiwmZfb2EtWQkSB9adhNam KqWiTEp98gwIcIxacqTqhjKVfxVkmjw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-352-9UUkOd8SOmCuHuHDl5aHpg-1; Wed, 18 Dec 2019 12:00:18 -0500 X-MC-Unique: 9UUkOd8SOmCuHuHDl5aHpg-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 797B119586C8; Wed, 18 Dec 2019 17:00:14 +0000 (UTC) Received: from [10.36.116.117] (ovpn-116-117.ams2.redhat.com [10.36.116.117]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1A81460C18; Wed, 18 Dec 2019 17:00:09 +0000 (UTC) Subject: Re: [PATCH v3 08/13] iommu/arm-smmu-v3: Propate ssid_bits To: Jean-Philippe Brucker Cc: linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org, devicetree@vger.kernel.org, iommu@lists.linux-foundation.org, joro@8bytes.org, robh+dt@kernel.org, mark.rutland@arm.com, lorenzo.pieralisi@arm.com, guohanjun@huawei.com, sudeep.holla@arm.com, rjw@rjwysocki.net, lenb@kernel.org, will@kernel.org, robin.murphy@arm.com, bhelgaas@google.com, jonathan.cameron@huawei.com, zhangfei.gao@linaro.org References: <20191209180514.272727-1-jean-philippe@linaro.org> <20191209180514.272727-9-jean-philippe@linaro.org> <466bbc57-79d4-274c-67bc-4ed591da9968@redhat.com> <20191218160834.GG2371701@myrica> From: Auger Eric Message-ID: Date: Wed, 18 Dec 2019 18:00:08 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20191218160834.GG2371701@myrica> Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org Hi Jean, On 12/18/19 5:08 PM, Jean-Philippe Brucker wrote: > On Tue, Dec 17, 2019 at 06:07:26PM +0100, Auger Eric wrote: >> Hi Jean, >> >> On 12/9/19 7:05 PM, Jean-Philippe Brucker wrote: >> >> s/Propate/Propagate in the commit title. >>> Now that we support substream IDs, initialize s1cdmax with the number of >>> SSID bits supported by a master and the SMMU. >>> >>> Context descriptor tables are allocated once for the first master >>> attached to a domain. Therefore attaching multiple devices with >>> different SSID sizes is tricky, and we currently don't support it. >>> >>> As a future improvement it would be nice to at least support attaching a >>> SSID-capable device to a domain that isn't using SSID, by reallocating >>> the SSID table. >> Isn't that use case relevant (I mean using both devices in a non SSID >> use case). For platform devices you can work this around with FW but for >> PCI devices? > > Normally each device gets its own domain. Especially since PASID is a PCI > Express capability, I expect them to be properly isolated with ACS, each > with its own IOMMU group. So I don't think this is too relevant for the > moment, it would be a quirk for a broken system. OK Eric > > Thanks, > Jean > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67C3AC43603 for ; Wed, 18 Dec 2019 17:00:47 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3CCF32176D for ; Wed, 18 Dec 2019 17:00:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ItGxrXOf" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3CCF32176D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 0C3B48770A; Wed, 18 Dec 2019 17:00:47 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6iKK07Ba6gTM; Wed, 18 Dec 2019 17:00:46 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by whitealder.osuosl.org (Postfix) with ESMTP id 91F3F86FEA; Wed, 18 Dec 2019 17:00:46 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 862AEC1797; Wed, 18 Dec 2019 17:00:46 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists.linuxfoundation.org (Postfix) with ESMTP id D89C0C077D for ; Wed, 18 Dec 2019 17:00:44 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id D4AFB84409 for ; Wed, 18 Dec 2019 17:00:44 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id C0jTbxkKFtMa for ; Wed, 18 Dec 2019 17:00:44 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by fraxinus.osuosl.org (Postfix) with ESMTPS id 0FA2686975 for ; Wed, 18 Dec 2019 17:00:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1576688442; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dn5SUwiPZ6v5NQ8mtwG6iqV/r/5Gbbs8HrzPzH1EerI=; b=ItGxrXOflq3XyLIwUJF7tFGtxNAtXEZvoJAqtOQ8q+t4Z7s9krV+q06Ts5M9DKXW1CBzPU agL7aGhiuJwVchL9v7JxPXOgWH5wVBcgrqXkEfqei7IugImk2h4LzKrvvEG+ju9FXxeKXT Ncvjlv+uMS2lQ3/c1dvaa/IM9Dcdrpo= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-352-9UUkOd8SOmCuHuHDl5aHpg-1; Wed, 18 Dec 2019 12:00:18 -0500 X-MC-Unique: 9UUkOd8SOmCuHuHDl5aHpg-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 797B119586C8; Wed, 18 Dec 2019 17:00:14 +0000 (UTC) Received: from [10.36.116.117] (ovpn-116-117.ams2.redhat.com [10.36.116.117]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1A81460C18; Wed, 18 Dec 2019 17:00:09 +0000 (UTC) Subject: Re: [PATCH v3 08/13] iommu/arm-smmu-v3: Propate ssid_bits To: Jean-Philippe Brucker References: <20191209180514.272727-1-jean-philippe@linaro.org> <20191209180514.272727-9-jean-philippe@linaro.org> <466bbc57-79d4-274c-67bc-4ed591da9968@redhat.com> <20191218160834.GG2371701@myrica> From: Auger Eric Message-ID: Date: Wed, 18 Dec 2019 18:00:08 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20191218160834.GG2371701@myrica> Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, linux-pci@vger.kernel.org, sudeep.holla@arm.com, rjw@rjwysocki.net, robin.murphy@arm.com, linux-acpi@vger.kernel.org, iommu@lists.linux-foundation.org, robh+dt@kernel.org, guohanjun@huawei.com, bhelgaas@google.com, zhangfei.gao@linaro.org, will@kernel.org, linux-arm-kernel@lists.infradead.org, lenb@kernel.org X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" Hi Jean, On 12/18/19 5:08 PM, Jean-Philippe Brucker wrote: > On Tue, Dec 17, 2019 at 06:07:26PM +0100, Auger Eric wrote: >> Hi Jean, >> >> On 12/9/19 7:05 PM, Jean-Philippe Brucker wrote: >> >> s/Propate/Propagate in the commit title. >>> Now that we support substream IDs, initialize s1cdmax with the number of >>> SSID bits supported by a master and the SMMU. >>> >>> Context descriptor tables are allocated once for the first master >>> attached to a domain. Therefore attaching multiple devices with >>> different SSID sizes is tricky, and we currently don't support it. >>> >>> As a future improvement it would be nice to at least support attaching a >>> SSID-capable device to a domain that isn't using SSID, by reallocating >>> the SSID table. >> Isn't that use case relevant (I mean using both devices in a non SSID >> use case). For platform devices you can work this around with FW but for >> PCI devices? > > Normally each device gets its own domain. Especially since PASID is a PCI > Express capability, I expect them to be properly isolated with ACS, each > with its own IOMMU group. So I don't think this is too relevant for the > moment, it would be a quirk for a broken system. OK Eric > > Thanks, > Jean > _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9DD41C43603 for ; Wed, 18 Dec 2019 17:00:50 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4B68B2176D for ; Wed, 18 Dec 2019 17:00:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="sxDsVXX1"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="PHFPpPpi" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4B68B2176D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=oANNA+3uLYZacxk9x/TCqf6UTsOvz9iBQhRAdBiN2RM=; b=sxDsVXX1+Js024 CRSb1URmKrOgH11dc3OIWyTlWJRRbm+alsC7F6E68J0UIrq23EqDRLjMRjLdRZ+JmvpI3R47DGt9e 91DD0thNcyl4Pp/moXgYDHIE0noiViZ3QS5m7GSnxYPKU9UaeP++CcnxSycR0KQ507L1wiBYrIHNJ v6INVdEdbQCWtcmaEZQUQlvg0GMPK4XOaYgxHc92cveJrq9oUcuRR7e1F5xpNoqpG+N0yAYBe5PX5 dFDeUiTofC1dzNmNaAPS10KCJVZYQtrpnvRmLBRGvsLSOSvETbp2NKtQvxnbIWhBEfjncpb8dxjE5 tfdZkOpNj0Vp832EAhwg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ihcgj-0006fJ-SC; Wed, 18 Dec 2019 17:00:41 +0000 Received: from us-smtp-1.mimecast.com ([205.139.110.61] helo=us-smtp-delivery-1.mimecast.com) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ihcgg-0006eX-3K for linux-arm-kernel@lists.infradead.org; Wed, 18 Dec 2019 17:00:39 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1576688436; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dn5SUwiPZ6v5NQ8mtwG6iqV/r/5Gbbs8HrzPzH1EerI=; b=PHFPpPpiHmUbRsqsVkZQ9bSq+PU1NV2wbtFM1bPZD5E4ZPFFwO8h92Vwy8f3u7zNthq8lW vx2rY7tZ6s3593h9Rwtxn8A39wwq0enEF0mwnO6twcpyEsSq1ynoKBAjAfJLxCi9rNCoTy N3nwFdi54IfEpWHfyBKYR/Q2X6L5SoA= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-352-9UUkOd8SOmCuHuHDl5aHpg-1; Wed, 18 Dec 2019 12:00:18 -0500 X-MC-Unique: 9UUkOd8SOmCuHuHDl5aHpg-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 797B119586C8; Wed, 18 Dec 2019 17:00:14 +0000 (UTC) Received: from [10.36.116.117] (ovpn-116-117.ams2.redhat.com [10.36.116.117]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1A81460C18; Wed, 18 Dec 2019 17:00:09 +0000 (UTC) Subject: Re: [PATCH v3 08/13] iommu/arm-smmu-v3: Propate ssid_bits To: Jean-Philippe Brucker References: <20191209180514.272727-1-jean-philippe@linaro.org> <20191209180514.272727-9-jean-philippe@linaro.org> <466bbc57-79d4-274c-67bc-4ed591da9968@redhat.com> <20191218160834.GG2371701@myrica> From: Auger Eric Message-ID: Date: Wed, 18 Dec 2019 18:00:08 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20191218160834.GG2371701@myrica> Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191218_090038_210350_6950F9E9 X-CRM114-Status: GOOD ( 15.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, lorenzo.pieralisi@arm.com, linux-pci@vger.kernel.org, joro@8bytes.org, sudeep.holla@arm.com, rjw@rjwysocki.net, robin.murphy@arm.com, linux-acpi@vger.kernel.org, iommu@lists.linux-foundation.org, robh+dt@kernel.org, jonathan.cameron@huawei.com, guohanjun@huawei.com, bhelgaas@google.com, zhangfei.gao@linaro.org, will@kernel.org, linux-arm-kernel@lists.infradead.org, lenb@kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Jean, On 12/18/19 5:08 PM, Jean-Philippe Brucker wrote: > On Tue, Dec 17, 2019 at 06:07:26PM +0100, Auger Eric wrote: >> Hi Jean, >> >> On 12/9/19 7:05 PM, Jean-Philippe Brucker wrote: >> >> s/Propate/Propagate in the commit title. >>> Now that we support substream IDs, initialize s1cdmax with the number of >>> SSID bits supported by a master and the SMMU. >>> >>> Context descriptor tables are allocated once for the first master >>> attached to a domain. Therefore attaching multiple devices with >>> different SSID sizes is tricky, and we currently don't support it. >>> >>> As a future improvement it would be nice to at least support attaching a >>> SSID-capable device to a domain that isn't using SSID, by reallocating >>> the SSID table. >> Isn't that use case relevant (I mean using both devices in a non SSID >> use case). For platform devices you can work this around with FW but for >> PCI devices? > > Normally each device gets its own domain. Especially since PASID is a PCI > Express capability, I expect them to be properly isolated with ACS, each > with its own IOMMU group. So I don't think this is too relevant for the > moment, it would be a quirk for a broken system. OK Eric > > Thanks, > Jean > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel