From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751351AbcL1LHF (ORCPT ); Wed, 28 Dec 2016 06:07:05 -0500 Received: from mailout2.w1.samsung.com ([210.118.77.12]:9659 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751277AbcL1LHC (ORCPT ); Wed, 28 Dec 2016 06:07:02 -0500 X-AuditID: cbfec7f1-f79626d000005d7d-bb-58639a0a60f4 Subject: Re: [PATCH] of: reserved_mem: set dma_ops for devices using reserved mem To: Pankaj Dubey , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org Cc: robh+dt@kernel.org, frowand.list@gmail.com, hans.verkuil@cisco.com, krzk@kernel.org, kgene@kernel.org, Smitha T Murthy From: Marek Szyprowski Message-id: Date: Wed, 28 Dec 2016 11:55:05 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-version: 1.0 In-reply-to: <1482299071-22637-1-git-send-email-pankaj.dubey@samsung.com> Content-type: text/plain; charset=utf-8; format=flowed Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA02SbUhTURzGObu7u9fp4nZd9c9SYRCVoqXuw01DjCQmEQh9SKTIpdcXciq7 vgaRzFlugYpKm0vQ1FJMUueyMhNbvoSRs7TSD1oqKZVD8wUUY+blTvDb73+e5zx/nsMhMboO 9yHTMrJZbYY6XSGRirsGN0eCPC2JcaeXixBT2z+CM9WL2xKmcbNbxJTN/cEYh6OdYMa6aySM 2dErYuqfrxFM8Zt+gpnq6UJRUlXVVgeuemWZIlTWFoNEVWprQapVq18sHi89m8Smp+Wy2lOR CdLUzfEeImtGmq/r/IwXop+kEXmQQClh9NcKIfBBGJ1ukxiRlKSpxwj0jTZcGFZ3huFqfPdG 82ODW3iCoNW64b6ygMD1b1jEu7ypy1D0Yk7MC3LKiODH4jziBYyqROBcuMCzhAoBo9Mo4VlG RcLKIO8hSTF1DNYdofzxAeoqOMwDmGDZDxuV02KePagYeGqcwITIcJh3FeMC+0NnqxPj9wJl J2BsugLnM4HyBWsfJjSIhvLxZXcbb/g9ZHP3PwqGkrcigcsQ6IoDBTYjGHHKBI6Ad0Of3Lv2 QUWXCRPiZVBylxYsKrj/sNwdeQ70jxzu96lBUGqekpQjf8ueOpY9FSx7KtQhrAXJ2RxOk8Jy ocGcWsPlZKQEJ2ZqrGjn33xwDf19iZbeh9sRRSKFl6x54kYcjatzuQKNHQGJKeSy7AeJcbQs SV1wi9VmXtfmpLOcHR0hxYpDsp668Ss0laLOZm+ybBar3VVFpIdPITK5tO1RJ5yrVR/D6wyR 8fIiyK89Y1OUNmkDYohoWm8aqIh9JlYFxay16zfCRDMT976fp5WHxes937g5IjEhNo+4bTf5 6sevidqyGvuS8y/O6rfKZ5fok4FeJXd0eTFfj2vqk5v8PDsml1wNwxERYfO9A5cmv0i3G5RK 3etchZhLVYcEYFpO/R+v8WgWMwMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrEIsWRmVeSWpSXmKPExsVy+t/xa7pGs5IjDJ4v57OYf+Qcq8XMN//Z LJb83MVk0f/4NbPF+fMb2C0u75rDZjHj/D4mi0Vbv7BbtO49wm5xd882Rgcujym/N7J67Jx1 l91j06pONo++LasYPT5vkgtgjXKzyUhNTEktUkjNS85PycxLt1UKDXHTtVBSyEvMTbVVitD1 DQlSUihLzCkF8owM0ICDc4B7sJK+XYJbxs8re9gLHnJVNG2+xNrA+JSji5GTQ0LARGLF0k5W CFtM4sK99WxdjFwcQgJLGCWOLu1mhXCeM0rsW/uDBaRKWCBYYtnV5UwgCRGBLkaJ6297mSGq 5jFKHHl6iBHEYRaYzCgx6es6ZpAWNgFDia63XWwgNq+AncSnY8+Aijg4WARUJb6eNwIJiwrE SCw5Po8FokRQ4sfke2A2p4CnxOquG2BjmAXMJL68PMwKYctLbF7zlnkCo8AsJC2zkJTNQlK2 gJF5FaNIamlxbnpusaFecWJucWleul5yfu4mRmD8bTv2c/MOxksbgw8xCnAwKvHwBlxLihBi TSwrrsw9xCjBwawkwlsyLTlCiDclsbIqtSg/vqg0J7X4EKMp0A8TmaVEk/OBqSGvJN7QxNDc 0tDI2MLC3MhISZy35MOVcCGB9MSS1OzU1ILUIpg+Jg5OqQbGhBlvTx8O5s3zFugziH/TaWvI myX243G+8/HiE+x6sl8dny49/oDdul3D/rp8GW+amlecjuy6ApaLCiv/LPXcIPbhSHqpdy6T 6LHor9NVv33em7Tc48P5XCejjZ/WvTv8MnAm281jh0uPtH5vuOpkn+g1LUmVycTcUGiHv83V FQL8tZx3pjEpsRRnJBpqMRcVJwIAiZhpg9UCAAA= X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20161228105506eucas1p23d204ccbfcb4463190f7456c9ab3a6cd X-Msg-Generator: CA X-Sender-IP: 182.198.249.179 X-Local-Sender: =?UTF-8?B?TWFyZWsgU3p5cHJvd3NraRtTUlBPTC1LZXJuZWwgKFRQKRs=?= =?UTF-8?B?7IK87ISx7KCE7J6QG1NlbmlvciBTb2Z0d2FyZSBFbmdpbmVlcg==?= X-Global-Sender: =?UTF-8?B?TWFyZWsgU3p5cHJvd3NraRtTUlBPTC1LZXJuZWwgKFRQKRtT?= =?UTF-8?B?YW1zdW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBFbmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 201P X-HopCount: 7 X-CMS-RootMailID: 20161221054333epcas5p1e27800790de041d997b4fb297cb759c3 X-RootMTR: 20161221054333epcas5p1e27800790de041d997b4fb297cb759c3 References: <1482299071-22637-1-git-send-email-pankaj.dubey@samsung.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Pankaj, On 2016-12-21 06:44, Pankaj Dubey wrote: > From: Smitha T Murthy > > For some IPs, there may be virtual child devices created and for them its > necessary to set the dma_ops if it's using reserved memory else it will call > the dummy dma_ops during buffer operations for the child devices which will > lead to memory mapping failure. > > Signed-off-by: Smitha T Murthy > Signed-off-by: Pankaj Dubey Acked-by: Marek Szyprowski > --- > drivers/of/of_reserved_mem.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/of/of_reserved_mem.c b/drivers/of/of_reserved_mem.c > index 366d8c3..d507c35 100644 > --- a/drivers/of/of_reserved_mem.c > +++ b/drivers/of/of_reserved_mem.c > @@ -354,6 +354,10 @@ int of_reserved_mem_device_init_by_idx(struct device *dev, > mutex_lock(&of_rmem_assigned_device_mutex); > list_add(&rd->list, &of_rmem_assigned_device_list); > mutex_unlock(&of_rmem_assigned_device_mutex); > + /* ensure that dma_ops is set for virtual devices > + * using reserved memory > + */ > + of_dma_configure(dev, np); > > dev_info(dev, "assigned reserved memory node %s\n", rmem->name); > } else { Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Szyprowski Subject: Re: [PATCH] of: reserved_mem: set dma_ops for devices using reserved mem Date: Wed, 28 Dec 2016 11:55:05 +0100 Message-ID: References: <1482299071-22637-1-git-send-email-pankaj.dubey@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-reply-to: <1482299071-22637-1-git-send-email-pankaj.dubey-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Pankaj Dubey , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Cc: robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, frowand.list-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, hans.verkuil-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org, krzk-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, kgene-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, Smitha T Murthy List-Id: devicetree@vger.kernel.org Hi Pankaj, On 2016-12-21 06:44, Pankaj Dubey wrote: > From: Smitha T Murthy > > For some IPs, there may be virtual child devices created and for them its > necessary to set the dma_ops if it's using reserved memory else it will call > the dummy dma_ops during buffer operations for the child devices which will > lead to memory mapping failure. > > Signed-off-by: Smitha T Murthy > Signed-off-by: Pankaj Dubey Acked-by: Marek Szyprowski > --- > drivers/of/of_reserved_mem.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/of/of_reserved_mem.c b/drivers/of/of_reserved_mem.c > index 366d8c3..d507c35 100644 > --- a/drivers/of/of_reserved_mem.c > +++ b/drivers/of/of_reserved_mem.c > @@ -354,6 +354,10 @@ int of_reserved_mem_device_init_by_idx(struct device *dev, > mutex_lock(&of_rmem_assigned_device_mutex); > list_add(&rd->list, &of_rmem_assigned_device_list); > mutex_unlock(&of_rmem_assigned_device_mutex); > + /* ensure that dma_ops is set for virtual devices > + * using reserved memory > + */ > + of_dma_configure(dev, np); > > dev_info(dev, "assigned reserved memory node %s\n", rmem->name); > } else { Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html