From: Paolo Bonzini <pbonzini@redhat.com>
To: Thomas Huth <thuth@redhat.com>, kvm@vger.kernel.org
Cc: "David Hildenbrand" <david@redhat.com>,
"Radim Krčmář" <rkrcmar@redhat.com>,
"Laurent Vivier" <lvivier@redhat.com>,
"Drew Jones" <drjones@redhat.com>
Subject: Re: [kvm-unit-tests PATCH] Replace -Wextra with a saner list of warning flags
Date: Fri, 30 Jun 2017 12:40:19 +0200 [thread overview]
Message-ID: <bf6f2397-b527-7613-4830-5885b0df3690@redhat.com> (raw)
In-Reply-To: <c8217793-f52f-99c5-ce44-dad99032433c@redhat.com>
On 29/06/2017 19:19, Thomas Huth wrote:
>
>> x86 cannot use "Wmissing-parameter-type -Wold-style-declaration
>> -Woverride-init" only because they're not valid in C++. Maybe we should
>> split CFLAGS into COMMON_CCFLAGS and CFLAGS proper, so that CXXFLAGS and
>> LDFLAGS can be assigned with
>>
>> CXXFLAGS += $(COMMON_CCFLAGS)
>> LDFLAGS += $(COMMON_CCFLAGS)
>>
>> Then those three could go in CFLAGS, and the others in COMMON_CCFLAGS.
> That's of course a good idea. I'll send a v2 ...
FWIW, I also removed -Wtype-limits when applying. Checking against
symbolic values that turn out to be zero is pretty common.
Paolo
prev parent reply other threads:[~2017-06-30 10:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-29 15:40 [kvm-unit-tests PATCH] Replace -Wextra with a saner list of warning flags Thomas Huth
2017-06-29 16:30 ` Thomas Huth
2017-06-29 16:35 ` Andrew Jones
2017-06-29 17:00 ` Paolo Bonzini
2017-06-29 16:56 ` Laurent Vivier
2017-06-29 17:07 ` Paolo Bonzini
2017-06-29 17:19 ` Thomas Huth
2017-06-30 10:40 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bf6f2397-b527-7613-4830-5885b0df3690@redhat.com \
--to=pbonzini@redhat.com \
--cc=david@redhat.com \
--cc=drjones@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=lvivier@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.