All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laurent Vivier <lvivier@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>,
	Paolo Bonzini <pbonzini@redhat.com>
Cc: "Greg Kurz" <groug@kaod.org>,
	"QEMU Developers" <qemu-devel@nongnu.org>,
	"Cédric Le Goater" <clg@kaod.org>,
	"David Gibson" <david@gibson.dropbear.id.au>
Subject: Re: [Qemu-devel] [PATCH] qtest: add read/write accessors with a specific endianness
Date: Thu, 6 Oct 2016 17:59:00 +0200	[thread overview]
Message-ID: <bf7aedb8-adb1-82e1-8af5-21a3718f3a77@redhat.com> (raw)
In-Reply-To: <CAFEAcA9qAbkW8hfqjM90dMp7-9SkdXrPw4oX5rx45Hfw7kXHmw@mail.gmail.com>



On 06/10/2016 17:41, Peter Maydell wrote:
> On 6 October 2016 at 16:36, Paolo Bonzini <pbonzini@redhat.com> wrote:
>>
>>
>> On 06/10/2016 16:11, Greg Kurz wrote:
>>> FWIW, Cedric had another proposal which apparently went unnoticed:
>>>
>>> <fc24ad74-da26-a713-9312-a2c2d07fb6a7@kaod.org>
>>>
>>> The idea is to add an optional endianness argument to the read*/write*
>>> commands in the qtest protocol:
>>> - libqtest then provides explicit _le and _be APIs
>>> - no extra byteswap is performed on the test program side: qtest
>>>   actually handles that and does exactly 1 or 0 byteswap.
>>> - it does not use memread/memwrite
>>> - the current 'guest native' API where qtest tswaps is preserved
>>>
>>
>> No, this is a worse idea, because the right place to do the swap is in
>> the "program" (libqtest) not in the "CPU" (QEMU).
> 
> Speaking of the right place to do things, perhaps we should
> reimplement qtest_big_endian() in libqtest.c to send a query
> to the QEMU-under-test to ask it what TARGET_BIG_ENDIAN says,
> rather than hardcoding a big list of architectures...

Yes, it's a good idea.

I can do that...

Laurent

  reply	other threads:[~2016-10-06 15:59 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-04 12:17 [Qemu-devel] [PATCH] qtest: add read/write accessors with a specific endianness Cédric Le Goater
2016-10-04 12:36 ` Peter Maydell
2016-10-04 14:04   ` Laurent Vivier
2016-10-04 14:07   ` Cédric Le Goater
2016-10-04 17:15   ` Paolo Bonzini
2016-10-04 23:43   ` David Gibson
2016-10-05  5:59     ` Cédric Le Goater
2016-10-05 12:31     ` Peter Maydell
2016-10-05 13:49       ` Cédric Le Goater
2016-10-05 13:53         ` Peter Maydell
2016-10-05 14:00           ` Cédric Le Goater
2016-10-05 14:20             ` Peter Maydell
2016-10-05 17:17               ` Cédric Le Goater
2016-10-05 17:32                 ` Peter Maydell
2016-10-06  3:45               ` David Gibson
2016-10-06  7:23                 ` Paolo Bonzini
2016-10-06  8:37                   ` David Gibson
2016-10-06  9:40                     ` Paolo Bonzini
2016-10-06 10:44                       ` Cédric Le Goater
2016-10-06 10:47                 ` Peter Maydell
2016-10-06 23:09                   ` David Gibson
2016-10-06  3:40         ` David Gibson
2016-10-06  3:38       ` David Gibson
2016-10-06  6:10         ` David Gibson
2016-10-06 11:03         ` Peter Maydell
2016-10-06 14:11           ` Greg Kurz
2016-10-06 15:36             ` Paolo Bonzini
2016-10-06 15:41               ` Peter Maydell
2016-10-06 15:59                 ` Laurent Vivier [this message]
2016-10-06 23:34                   ` David Gibson
2016-10-07  7:44                     ` Laurent Vivier
2016-10-06 15:44               ` Cédric Le Goater
2016-10-06 15:45                 ` Paolo Bonzini
2016-10-06 23:43               ` David Gibson
2016-10-06 23:31             ` David Gibson
2016-10-06 23:31           ` David Gibson
2016-10-07  9:52             ` Peter Maydell
2016-10-04 23:26 ` David Gibson
2016-10-05  5:36   ` Cédric Le Goater

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bf7aedb8-adb1-82e1-8af5-21a3718f3a77@redhat.com \
    --to=lvivier@redhat.com \
    --cc=clg@kaod.org \
    --cc=david@gibson.dropbear.id.au \
    --cc=groug@kaod.org \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.