From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: luoyonggang@gmail.com, Bruce Rogers <brogers@suse.com>
Cc: qemu-level <qemu-devel@nongnu.org>, Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [PATCH] meson.build: don't condition iconv detection on library detection
Date: Thu, 15 Oct 2020 08:51:08 +0200 [thread overview]
Message-ID: <bf846ef9-79d7-d388-d53a-9de605ce37e2@redhat.com> (raw)
In-Reply-To: <CAE2XoE_1T8cobLaZT=gCugHozV=todSvQynNYvQ-VxXVMKxc-w@mail.gmail.com>
On 10/15/20 6:33 AM, 罗勇刚(Yonggang Luo) wrote:
>
>
> On Thu, Oct 15, 2020 at 6:19 AM Bruce Rogers <brogers@suse.com
> <mailto:brogers@suse.com>> wrote:
> >
> > It isn't necessarily the case that use of iconv requires an additional
> > library. For that reason we shouldn't conditionalize iconv detection on
> > libiconv.found.
> >
> > Fixes: 5285e593c33 (configure: Fixes ncursesw detection under
> msys2/mingw by convert them to meson)
> >
> > Signed-off-by: Bruce Rogers <brogers@suse.com <mailto:brogers@suse.com>>
> > ---
> > meson.build | 16 +++++++---------
> > 1 file changed, 7 insertions(+), 9 deletions(-)
> >
> > diff --git a/meson.build b/meson.build
> > index 1a4a482492..84c8ec9541 100644
> > --- a/meson.build
> > +++ b/meson.build
> > @@ -431,15 +431,13 @@ if not get_option('iconv').disabled()
> > libiconv = cc.find_library('iconv',
> > required: false,
> > static: enable_static)
> > - if libiconv.found()
> > - if cc.links('''
> > - #include <iconv.h>
> > - int main(void) {
> > - iconv_t conv = iconv_open("WCHAR_T", "UCS-2");
> > - return conv != (iconv_t) -1;
> > - }''', dependencies: [libiconv])
> > - iconv = declare_dependency(dependencies: [libiconv])
> > - endif
> > + if cc.links('''
> > + #include <iconv.h>
> > + int main(void) {
> > + iconv_t conv = iconv_open("WCHAR_T", "UCS-2");
> > + return conv != (iconv_t) -1;
> > + }''', dependencies: [libiconv])
> > + iconv = declare_dependency(dependencies: [libiconv])
> > endif
> > endif
> > if get_option('iconv').enabled() and not iconv.found()
> > --
> > 2.28.0
> >
> Reviewed-by: Yonggang Luo<l
> <mailto:brogers@suse.com>uoyonggang@gmail.com <mailto:uoyonggang@gmail.com>>
Something is certainly wrong here =)
I suppose you meant:
Reviewed-by:Yonggang Luo <luoyonggang@gmail.com>
>
> --
> 此致
> 礼
> 罗勇刚
> Yours
> sincerely,
> Yonggang Luo
next prev parent reply other threads:[~2020-10-15 6:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-14 22:19 [PATCH] meson.build: don't condition iconv detection on library detection Bruce Rogers
2020-10-15 4:33 ` 罗勇刚(Yonggang Luo)
2020-10-15 6:51 ` Philippe Mathieu-Daudé [this message]
2020-10-15 17:12 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bf846ef9-79d7-d388-d53a-9de605ce37e2@redhat.com \
--to=philmd@redhat.com \
--cc=brogers@suse.com \
--cc=kraxel@redhat.com \
--cc=luoyonggang@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.