All of lore.kernel.org
 help / color / mirror / Atom feed
From: Oliver Neukum <oneukum@suse.com>
To: syzbot <syzbot+fd9d03311cdce9a9ec36@syzkaller.appspotmail.com>,
	andreyknvl@google.com, linux-usb@vger.kernel.org,
	syzkaller-bugs@googlegroups.com, thomas@winischhofer.net
Subject: Re: [syzbot] INFO: task hung in sisusb_open
Date: Wed, 27 Oct 2021 11:52:30 +0200	[thread overview]
Message-ID: <bf8eefe4-7fe1-002f-8258-10a3e825856a@suse.com> (raw)
In-Reply-To: <000000000000c87fc005cef26865@google.com>

[-- Attachment #1: Type: text/plain, Size: 773 bytes --]


On 22.10.21 17:10, syzbot wrote:
> syzbot has found a reproducer for the following issue on:
>
> HEAD commit:    2f111a6fd5b5 Merge tag 'ceph-for-5.15-rc7' of git://github..
> git tree:       upstream
> console output: https://syzkaller.appspot.com/x/log.txt?x=15a3aaf0b00000
> kernel config:  https://syzkaller.appspot.com/x/.config?x=61f4d9af07d3bbdf
> dashboard link: https://syzkaller.appspot.com/bug?extid=fd9d03311cdce9a9ec36
> compiler:       gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2
> syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=13d4e9fcb00000
> C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=1444ada4b00000


#syz test https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git  2f111a6fd5b5



[-- Attachment #2: sisusb_debug.patch --]
[-- Type: text/x-patch, Size: 510 bytes --]

diff --git a/drivers/usb/misc/sisusbvga/sisusb.c b/drivers/usb/misc/sisusbvga/sisusb.c
index f08de33d9ff3..de30fb85ceda 100644
--- a/drivers/usb/misc/sisusbvga/sisusb.c
+++ b/drivers/usb/misc/sisusbvga/sisusb.c
@@ -251,7 +251,8 @@ static int sisusb_bulkout_msg(struct sisusb_usb_data *sisusb, int index,
 			retval = urb->status;
 			byteswritten = urb->actual_length;
 		}
-	}
+	} else if (timeout == 0)
+		printk(KERN_ERR"Message without timeout\n");
 
 	if (actual_length)
 		*actual_length = byteswritten;

  parent reply	other threads:[~2021-10-27  9:52 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-06 15:22 INFO: task hung in sisusb_open syzbot
2021-10-22 15:10 ` [syzbot] " syzbot
2021-10-25 14:40   ` Oliver Neukum
2021-10-27  6:27     ` Dmitry Vyukov
2021-10-27  9:52   ` Oliver Neukum [this message]
2021-10-27 12:28     ` syzbot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bf8eefe4-7fe1-002f-8258-10a3e825856a@suse.com \
    --to=oneukum@suse.com \
    --cc=andreyknvl@google.com \
    --cc=linux-usb@vger.kernel.org \
    --cc=syzbot+fd9d03311cdce9a9ec36@syzkaller.appspotmail.com \
    --cc=syzkaller-bugs@googlegroups.com \
    --cc=thomas@winischhofer.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.