From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8F02C2BC11 for ; Fri, 11 Sep 2020 17:06:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AC229214F1 for ; Fri, 11 Sep 2020 17:06:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="XUkS/xO3" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726235AbgIKRG1 (ORCPT ); Fri, 11 Sep 2020 13:06:27 -0400 Received: from lelv0143.ext.ti.com ([198.47.23.248]:55680 "EHLO lelv0143.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726189AbgIKPCf (ORCPT ); Fri, 11 Sep 2020 11:02:35 -0400 Received: from fllv0034.itg.ti.com ([10.64.40.246]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id 08BEmGPA089963; Fri, 11 Sep 2020 09:48:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1599835697; bh=utgFM9WorG4OFofGm9b5aCjLlddXO94Yx+teMloJ8+U=; h=Subject:To:References:From:Date:In-Reply-To; b=XUkS/xO3at4lfOm/piZLuaB2/XlW4AlvLQpvHWo6dLE1BCI84/aX/tunBvIXAwOf2 u14gxPDv3NnLqmIjFavvaakscCKeUVkRapJrchoqm1hgmCNItBsjvuL9Cxn2uKu0XG 51r8CVPCTieQhopP8X7o52xHVnXkhlGWHKOYEf2Y= Received: from DFLE104.ent.ti.com (dfle104.ent.ti.com [10.64.6.25]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 08BEmGLX120810 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 11 Sep 2020 09:48:16 -0500 Received: from DFLE100.ent.ti.com (10.64.6.21) by DFLE104.ent.ti.com (10.64.6.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Fri, 11 Sep 2020 09:48:16 -0500 Received: from lelv0326.itg.ti.com (10.180.67.84) by DFLE100.ent.ti.com (10.64.6.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Fri, 11 Sep 2020 09:48:16 -0500 Received: from [192.168.2.14] (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 08BEmFR2119261; Fri, 11 Sep 2020 09:48:15 -0500 Subject: Re: [PATCH] memory: omap-gpmc: Fix compile test on SPARC To: Krzysztof Kozlowski , Tony Lindgren , , References: <20200911143251.399-1-krzk@kernel.org> From: Roger Quadros Message-ID: Date: Fri, 11 Sep 2020 17:48:14 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200911143251.399-1-krzk@kernel.org> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Krzysztof, On 11/09/2020 17:32, Krzysztof Kozlowski wrote: > SPARC comes without CONFIG_OF_ADDRESS thus compile testing fails on > linking: > > /usr/bin/sparc64-linux-gnu-ld: drivers/memory/omap-gpmc.o: in function `gpmc_probe_generic_child': > omap-gpmc.c:(.text.unlikely+0x14ec): undefined reference to `of_platform_device_create' > > Fixes: ea0c0ad6b6eb ("memory: Enable compile testing for most of the drivers") > Signed-off-by: Krzysztof Kozlowski > --- > drivers/memory/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/memory/Kconfig b/drivers/memory/Kconfig > index 8072204bc21a..00e013b14703 100644 > --- a/drivers/memory/Kconfig > +++ b/drivers/memory/Kconfig > @@ -104,6 +104,7 @@ config TI_EMIF > > config OMAP_GPMC > bool "Texas Instruments OMAP SoC GPMC driver" if COMPILE_TEST > + depends on OF_ADDRESS but of_platform_device_create() is defined in platform.c which gets built irrespective of OF_ADDRESS. Maybe we need to just depend on CONFIG_OF ? > select GPIOLIB > help > This driver is for the General Purpose Memory Controller (GPMC) > cheers, -roger -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki