From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43014) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bXZ5U-0003pa-It for qemu-devel@nongnu.org; Wed, 10 Aug 2016 15:22:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bXZ5T-0005mV-Ha for qemu-devel@nongnu.org; Wed, 10 Aug 2016 15:22:48 -0400 References: <1470679640-18366-1-git-send-email-clord@redhat.com> <1470679640-18366-5-git-send-email-clord@redhat.com> <373902e2-bd93-941d-1b91-6f4f0d451dba@redhat.com> From: Colin Lord Message-ID: Date: Wed, 10 Aug 2016 15:22:23 -0400 MIME-Version: 1.0 In-Reply-To: <373902e2-bd93-941d-1b91-6f4f0d451dba@redhat.com> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v7 4/4] blockdev: Modularize nfs block driver List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-devel@nongnu.org Cc: kwolf@redhat.com, qemu-block@nongnu.org On 08/10/2016 03:04 PM, Max Reitz wrote: > On 08.08.2016 20:07, Colin Lord wrote: >> Modularizes the nfs block driver so that it gets dynamically loaded. >> >> Signed-off-by: Colin Lord >> Reviewed-by: Stefan Hajnoczi >> --- >> block/Makefile.objs | 1 + >> configure | 4 ++-- >> 2 files changed, 3 insertions(+), 2 deletions(-) > > I'm not quite sure what this achieves. From what I can see, the NFS > block driver is still linked hard into qemu and it is unconditionally > registered at qemu startup. > ldd seems to be telling me that libnfs is not linked to the main binary after this patch. > (The output from a printf() in nfs_block_init() is visible even when > just starting qemu-img or qemu-io without any arguments; most notably > without bdrv_find_protocol() having been invoked at all.) > > Max > I can't seem to reproduce this. Is it possible you applied this patch without applying the first 3 before it? Or maybe didn't have modules enabled in the configuration? As far as I can tell NFS seems to building as a module and doesn't seem to be hard linked, so I'm not really sure what's going on. Colin