From: Michal Simek <michal.simek@xilinx.com>
To: Guenter Roeck <linux@roeck-us.net>,
Franz Forstmayr <forstmayr.franz@gmail.com>
Cc: Jean Delvare <jdelvare@suse.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Jonathan Corbet <corbet@lwn.net>,
linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org
Subject: Re: [PATCH 3/3] hwmon: (ina2xx) Add support for ina260
Date: Tue, 19 May 2020 07:21:05 +0200 [thread overview]
Message-ID: <bfa786b6-fe62-a5fb-718f-bb9e95b1f051@xilinx.com> (raw)
In-Reply-To: <a78bbb40-9a0c-8acc-841e-7a51447d4dbc@roeck-us.net>
On 26. 02. 20 3:16, Guenter Roeck wrote:
> On 2/24/20 3:26 PM, Franz Forstmayr wrote:
>> Add initial support for INA260 power monitor with integrated shunt.
>> Registers are different from other INA2xx devices, that's why a small
>> translation table is used.
>>
>> Signed-off-by: Franz Forstmayr <forstmayr.franz@gmail.com>
>
> I think the chip is sufficiently different to other chips that a separate
> driver would make much more sense than adding support to the existing
> driver.
> There is no calibration, registers are different, the retry logic is
> not needed. A new driver could use the with_info API and would be much
> simpler while at the same time not messing up the existing driver.
Isn't it also better to switch to IIO framework?
As we discussed in past there are two ina226 drivers. One in hwmon and
second based on IIO framework (more advance one?) and would be good to
deprecate hwmon one.
That's why separate driver is necessary.
Thanks,
Michal
next prev parent reply other threads:[~2020-05-19 5:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-24 23:26 [PATCH 1/3] dt-bindings: hwmon: Add compatible for ti,ina260 Franz Forstmayr
2020-02-24 23:26 ` [PATCH 2/3] docs: hwmon: Add support for ina2xx Franz Forstmayr
2020-02-25 14:49 ` Guenter Roeck
2020-02-24 23:26 ` [PATCH 3/3] hwmon: (ina2xx) Add support for ina260 Franz Forstmayr
2020-02-26 2:16 ` Guenter Roeck
2020-05-19 5:21 ` Michal Simek [this message]
2020-05-19 14:14 ` Guenter Roeck
2020-05-19 15:28 ` Michal Simek
2020-03-02 20:50 ` [PATCH 1/3] dt-bindings: hwmon: Add compatible for ti,ina260 Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bfa786b6-fe62-a5fb-718f-bb9e95b1f051@xilinx.com \
--to=michal.simek@xilinx.com \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=forstmayr.franz@gmail.com \
--cc=jdelvare@suse.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.