All of lore.kernel.org
 help / color / mirror / Atom feed
From: Timur Tabi <timur@kernel.org>
To: Steven Rostedt <rostedt@goodmis.org>,
	Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
Cc: Petr Mladek <pmladek@suse.com>,
	Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
	Vlastimil Babka <vbabka@suse.cz>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Matthew Wilcox <willy@infradead.org>,
	akpm@linux-foundation.org,
	Linus Torvalds <torvalds@linux-foundation.org>,
	roman.fietze@magna.com, Kees Cook <keescook@chromium.org>,
	John Ogness <john.ogness@linutronix.de>,
	akinobu.mita@gmail.com, glider@google.com,
	Andrey Konovalov <andreyknvl@google.com>,
	Marco Elver <elver@google.com>,
	Rasmus Villemoes <linux@rasmusvillemoes.dk>,
	Pavel Machek <pavel@ucw.cz>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH 0/3][RESEND] add support for never printing hashed addresses
Date: Wed, 10 Feb 2021 11:21:52 -0600	[thread overview]
Message-ID: <bfb425fb-0254-c1e3-62b3-d55a7cbb46ae@kernel.org> (raw)
In-Reply-To: <20210210114633.1b755f6e@gandalf.local.home>



On 2/10/21 10:46 AM, Steven Rostedt wrote:
> Now the question is, why do you need the unhashed pointer?
> 
> Currently, the instruction pointer is what is fine right? You get the
> a function and its offset. If there's something that is needed, perhaps we
> should look at how to fix that, instead of just unhashing all pointers by
> default.

The original version of this patch only fixed print_hex_dump(), because 
hashed addresses didn't make any sense for that.  Each address is 
incremented by 16 or 32, but since they were all hashed, they may as 
well have been random numbers.

  parent reply	other threads:[~2021-02-10 17:23 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-10  5:18 [PATCH 0/3][RESEND] add support for never printing hashed addresses Timur Tabi
2021-02-10  5:18 ` [PATCH 1/3] lib/test_printf: use KSTM_MODULE_GLOBALS macro Timur Tabi
2021-02-10  5:21   ` Timur Tabi
2021-02-10 13:14   ` Petr Mladek
2021-02-10  5:18 ` [PATCH 2/3] kselftest: add support for skipped tests Timur Tabi
2021-02-10  9:09   ` kernel test robot
2021-02-10  9:09     ` kernel test robot
2021-02-10  5:18 ` [PATCH 3/3] lib/vsprintf: make-printk-non-secret printks all addresses as unhashed Timur Tabi
2021-02-10 11:03   ` Vlastimil Babka
2021-02-10 13:41   ` Petr Mladek
2021-02-10 17:27     ` Timur Tabi
2021-02-12 11:52       ` Petr Mladek
2021-02-10 11:11 ` [PATCH 0/3][RESEND] add support for never printing hashed addresses Marco Elver
2021-02-10 19:03   ` Timur Tabi
2021-02-10 11:47 ` Andy Shevchenko
2021-02-10 11:47   ` Andy Shevchenko
2021-02-10 16:57   ` Timur Tabi
2021-02-10 15:46 ` Tetsuo Handa
2021-02-10 16:18   ` Steven Rostedt
2021-02-10 16:39     ` Tetsuo Handa
2021-02-10 16:46       ` Steven Rostedt
2021-02-10 17:07         ` Tetsuo Handa
2021-02-10 17:29           ` Steven Rostedt
2021-02-10 17:21         ` Timur Tabi [this message]
2021-02-10 16:54       ` Andy Shevchenko
2021-02-10 17:41         ` Tetsuo Handa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bfb425fb-0254-c1e3-62b3-d55a7cbb46ae@kernel.org \
    --to=timur@kernel.org \
    --cc=akinobu.mita@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=andreyknvl@google.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=elver@google.com \
    --cc=glider@google.com \
    --cc=john.ogness@linutronix.de \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux@rasmusvillemoes.dk \
    --cc=pavel@ucw.cz \
    --cc=penguin-kernel@i-love.sakura.ne.jp \
    --cc=pmladek@suse.com \
    --cc=roman.fietze@magna.com \
    --cc=rostedt@goodmis.org \
    --cc=sergey.senozhatsky@gmail.com \
    --cc=torvalds@linux-foundation.org \
    --cc=vbabka@suse.cz \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.