From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76342C1B0D8 for ; Tue, 8 Dec 2020 07:14:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3F31423A6C for ; Tue, 8 Dec 2020 07:14:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726586AbgLHHOO (ORCPT ); Tue, 8 Dec 2020 02:14:14 -0500 Received: from foss.arm.com ([217.140.110.172]:43164 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725785AbgLHHOO (ORCPT ); Tue, 8 Dec 2020 02:14:14 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 48A8231B; Mon, 7 Dec 2020 23:13:28 -0800 (PST) Received: from [10.57.34.152] (unknown [10.57.34.152]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 26F033F718; Mon, 7 Dec 2020 23:13:26 -0800 (PST) Subject: Re: [PATCH v4 1/4] dt-bindings/opp: Update documentation for opp-shared To: Viresh Kumar Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, sudeep.holla@arm.com, rjw@rjwysocki.net, vireshk@kernel.org, robh+dt@kernel.org, sboyd@kernel.org, nm@ti.com, daniel.lezcano@linaro.org, morten.rasmussen@arm.com, chris.redpath@arm.com References: <20201202172356.10508-1-nicola.mazzucato@arm.com> <20201202172356.10508-2-nicola.mazzucato@arm.com> <20201208042924.kv7tqsbstoanqham@vireshk-i7> From: Nicola Mazzucato Message-ID: Date: Tue, 8 Dec 2020 07:15:30 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <20201208042924.kv7tqsbstoanqham@vireshk-i7> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Viresh, thanks for your comments. I will update subject and content as you suggested. Regards, Nicola On 12/8/20 4:29 AM, Viresh Kumar wrote: > Subject should rather be: > > dt-bindings: opp: Allow empty OPP tables > > On 02-12-20, 17:23, Nicola Mazzucato wrote: >> Currently the optional property opp-shared is used within an opp table >> to tell that a set of devices share their clock/voltage lines (and the >> opp points). >> It is therefore possible to use an empty opp table to convey only that >> information, useful in situations where the opp points are provided via >> other means (hardware. firmware, etc). >> >> Update the documentation to remark this additional case and provide an >> example. >> >> Signed-off-by: Nicola Mazzucato >> --- >> Documentation/devicetree/bindings/opp/opp.txt | 53 +++++++++++++++++++ >> 1 file changed, 53 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/opp/opp.txt b/Documentation/devicetree/bindings/opp/opp.txt >> index 9847dfeeffcb..a5f1f993eab9 100644 >> --- a/Documentation/devicetree/bindings/opp/opp.txt >> +++ b/Documentation/devicetree/bindings/opp/opp.txt >> @@ -72,6 +72,9 @@ Optional properties: >> switch their DVFS state together, i.e. they share clock/voltage/current lines. >> Missing property means devices have independent clock/voltage/current lines, >> but they share OPP tables. >> + This optional property can be used without any OPP nodes when its only purpose >> + is to describe a dependency of clock/voltage/current lines among a set of >> + devices. > > And instead of this, we should rather update "OPP nodes:" section like > this: > > diff --git a/Documentation/devicetree/bindings/opp/opp.txt b/Documentation/devicetree/bindings/opp/opp.txt > index 9847dfeeffcb..28077ce3a845 100644 > --- a/Documentation/devicetree/bindings/opp/opp.txt > +++ b/Documentation/devicetree/bindings/opp/opp.txt > @@ -63,11 +63,13 @@ This describes the OPPs belonging to a device. This node can have following > - compatible: Allow OPPs to express their compatibility. It should be: > "operating-points-v2". > > +Optional properties: > - OPP nodes: One or more OPP nodes describing voltage-current-frequency > combinations. Their name isn't significant but their phandle can be used to > - reference an OPP. > + reference an OPP. These are mandatory except for the case where the OPP table > + is present only to indicate dependency between devices using the opp-shared > + property. > > -Optional properties: > - opp-shared: Indicates that device nodes using this OPP Table Node's phandle > switch their DVFS state together, i.e. they share clock/voltage/current lines. > Missing property means devices have independent clock/voltage/current lines, > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD3CEC4167B for ; Tue, 8 Dec 2020 07:14:55 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 59F1423A6C for ; Tue, 8 Dec 2020 07:14:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 59F1423A6C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=P5umfZm3FHEGK75iY974Mr6bANrr6/L8cmooYztAkyo=; b=ymKo4GEV8xMTuXmeZOoG5aBOy LZe85g56ilArvYwymJ4WAKATzqjk+QRas7R8ghOHNxYtQcG/vHhjIBoeuOLQXGnI188xB6y4lAjS7 BAeJSQrk6E4JKkHLz91f14+KtpAGqcPwuis/J965sSACcfovxTNQknvBAEOnBXRC/ZydmNCKAlTLh 780zFv50YGbhGSIi/8ZNDXRwzG8Klq2n8it5M20HcngKcqapohaUt3JJqiezbwEVGMttVwJF1cpK9 Dv0qDoTio2j6ichsKtikE9Y+DtYRG5AJfA37NKGfa7JAZyNg1fgpK98nsUhRClkVnLuLf647tFg7M vQRCmWiZg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kmXBp-0004VM-7j; Tue, 08 Dec 2020 07:13:37 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kmXBm-0004Ui-SN for linux-arm-kernel@lists.infradead.org; Tue, 08 Dec 2020 07:13:35 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 48A8231B; Mon, 7 Dec 2020 23:13:28 -0800 (PST) Received: from [10.57.34.152] (unknown [10.57.34.152]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 26F033F718; Mon, 7 Dec 2020 23:13:26 -0800 (PST) Subject: Re: [PATCH v4 1/4] dt-bindings/opp: Update documentation for opp-shared To: Viresh Kumar References: <20201202172356.10508-1-nicola.mazzucato@arm.com> <20201202172356.10508-2-nicola.mazzucato@arm.com> <20201208042924.kv7tqsbstoanqham@vireshk-i7> From: Nicola Mazzucato Message-ID: Date: Tue, 8 Dec 2020 07:15:30 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <20201208042924.kv7tqsbstoanqham@vireshk-i7> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201208_021335_021514_860F94C9 X-CRM114-Status: GOOD ( 20.41 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: nm@ti.com, devicetree@vger.kernel.org, linux-pm@vger.kernel.org, sboyd@kernel.org, vireshk@kernel.org, daniel.lezcano@linaro.org, rjw@rjwysocki.net, linux-kernel@vger.kernel.org, robh+dt@kernel.org, sudeep.holla@arm.com, chris.redpath@arm.com, morten.rasmussen@arm.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Viresh, thanks for your comments. I will update subject and content as you suggested. Regards, Nicola On 12/8/20 4:29 AM, Viresh Kumar wrote: > Subject should rather be: > > dt-bindings: opp: Allow empty OPP tables > > On 02-12-20, 17:23, Nicola Mazzucato wrote: >> Currently the optional property opp-shared is used within an opp table >> to tell that a set of devices share their clock/voltage lines (and the >> opp points). >> It is therefore possible to use an empty opp table to convey only that >> information, useful in situations where the opp points are provided via >> other means (hardware. firmware, etc). >> >> Update the documentation to remark this additional case and provide an >> example. >> >> Signed-off-by: Nicola Mazzucato >> --- >> Documentation/devicetree/bindings/opp/opp.txt | 53 +++++++++++++++++++ >> 1 file changed, 53 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/opp/opp.txt b/Documentation/devicetree/bindings/opp/opp.txt >> index 9847dfeeffcb..a5f1f993eab9 100644 >> --- a/Documentation/devicetree/bindings/opp/opp.txt >> +++ b/Documentation/devicetree/bindings/opp/opp.txt >> @@ -72,6 +72,9 @@ Optional properties: >> switch their DVFS state together, i.e. they share clock/voltage/current lines. >> Missing property means devices have independent clock/voltage/current lines, >> but they share OPP tables. >> + This optional property can be used without any OPP nodes when its only purpose >> + is to describe a dependency of clock/voltage/current lines among a set of >> + devices. > > And instead of this, we should rather update "OPP nodes:" section like > this: > > diff --git a/Documentation/devicetree/bindings/opp/opp.txt b/Documentation/devicetree/bindings/opp/opp.txt > index 9847dfeeffcb..28077ce3a845 100644 > --- a/Documentation/devicetree/bindings/opp/opp.txt > +++ b/Documentation/devicetree/bindings/opp/opp.txt > @@ -63,11 +63,13 @@ This describes the OPPs belonging to a device. This node can have following > - compatible: Allow OPPs to express their compatibility. It should be: > "operating-points-v2". > > +Optional properties: > - OPP nodes: One or more OPP nodes describing voltage-current-frequency > combinations. Their name isn't significant but their phandle can be used to > - reference an OPP. > + reference an OPP. These are mandatory except for the case where the OPP table > + is present only to indicate dependency between devices using the opp-shared > + property. > > -Optional properties: > - opp-shared: Indicates that device nodes using this OPP Table Node's phandle > switch their DVFS state together, i.e. they share clock/voltage/current lines. > Missing property means devices have independent clock/voltage/current lines, > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel