From: Ian Kent <raven@themaw.net>
To: David Howells <dhowells@redhat.com>
Cc: Miklos Szeredi <miklos@szeredi.hu>,
Linus Torvalds <torvalds@linux-foundation.org>,
Al Viro <viro@zeniv.linux.org.uk>,
Casey Schaufler <casey@schaufler-ca.com>,
Stephen Smalley <sds@tycho.nsa.gov>,
Nicolas Dichtel <nicolas.dichtel@6wind.com>,
Christian Brauner <christian@brauner.io>,
andres@anarazel.de, Jeff Layton <jlayton@redhat.com>,
dray@redhat.com, Karel Zak <kzak@redhat.com>,
keyrings@vger.kernel.org, Linux API <linux-api@vger.kernel.org>,
linux-fsdevel@vger.kernel.org,
LSM <linux-security-module@vger.kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 13/17] watch_queue: Implement mount topology and attribute change notifications [ver #5]
Date: Mon, 03 Aug 2020 14:30:26 +0000 [thread overview]
Message-ID: <bfba8e858885b8c507b8816d5296f7ab7f949e78.camel@themaw.net> (raw)
In-Reply-To: <1692826.1596457912@warthog.procyon.org.uk>
On Mon, 2020-08-03 at 13:31 +0100, David Howells wrote:
> Ian Kent <raven@themaw.net> wrote:
>
> > > I'm changing it so that the fields are 64-bit, but initialised
> > > with the
> > > existing mount ID in the notifications set. The fsinfo set
> > > changes that
> > > to a unique ID. I'm tempted to make the unique IDs start at
> > > UINT_MAX+1 to
> > > disambiguate them.
> >
> > Mmm ... so what would I use as a mount id that's not used, like
> > NULL
> > for strings?
>
> Zero is skipped, so you could use that.
>
> > I'm using -1 now but changing this will mean I need something
> > different.
>
> It's 64-bits, so you're not likely to see it reach -1, even if it
> does start
> at UINT_MAX+1.
Ha, either or, I don't think it will be a problem, there's
bound to be a few changes so the components using this will
need to change a bit before it's finalized, shouldn't be a
big deal I think. At least not for me and shouldn't be much
for libmount either I think.
Ian
WARNING: multiple messages have this Message-ID (diff)
From: Ian Kent <raven@themaw.net>
To: David Howells <dhowells@redhat.com>
Cc: Miklos Szeredi <miklos@szeredi.hu>,
Linus Torvalds <torvalds@linux-foundation.org>,
Al Viro <viro@zeniv.linux.org.uk>,
Casey Schaufler <casey@schaufler-ca.com>,
Stephen Smalley <sds@tycho.nsa.gov>,
Nicolas Dichtel <nicolas.dichtel@6wind.com>,
Christian Brauner <christian@brauner.io>,
andres@anarazel.de, Jeff Layton <jlayton@redhat.com>,
dray@redhat.com, Karel Zak <kzak@redhat.com>,
keyrings@vger.kernel.org, Linux API <linux-api@vger.kernel.org>,
linux-fsdevel@vger.kernel.org,
LSM <linux-security-module@vger.kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 13/17] watch_queue: Implement mount topology and attribute change notifications [ver #5]
Date: Mon, 03 Aug 2020 22:30:26 +0800 [thread overview]
Message-ID: <bfba8e858885b8c507b8816d5296f7ab7f949e78.camel@themaw.net> (raw)
In-Reply-To: <1692826.1596457912@warthog.procyon.org.uk>
On Mon, 2020-08-03 at 13:31 +0100, David Howells wrote:
> Ian Kent <raven@themaw.net> wrote:
>
> > > I'm changing it so that the fields are 64-bit, but initialised
> > > with the
> > > existing mount ID in the notifications set. The fsinfo set
> > > changes that
> > > to a unique ID. I'm tempted to make the unique IDs start at
> > > UINT_MAX+1 to
> > > disambiguate them.
> >
> > Mmm ... so what would I use as a mount id that's not used, like
> > NULL
> > for strings?
>
> Zero is skipped, so you could use that.
>
> > I'm using -1 now but changing this will mean I need something
> > different.
>
> It's 64-bits, so you're not likely to see it reach -1, even if it
> does start
> at UINT_MAX+1.
Ha, either or, I don't think it will be a problem, there's
bound to be a few changes so the components using this will
need to change a bit before it's finalized, shouldn't be a
big deal I think. At least not for me and shouldn't be much
for libmount either I think.
Ian
next prev parent reply other threads:[~2020-08-03 14:30 UTC|newest]
Thread overview: 87+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-18 15:03 [PATCH 00/17] pipe: Keyrings, mount and superblock notifications [ver #5] David Howells
2020-03-18 15:03 ` David Howells
2020-03-18 15:03 ` [PATCH 01/17] uapi: General notification queue definitions " David Howells
2020-03-18 15:03 ` [PATCH 02/17] security: Add hooks to rule on setting a watch " David Howells
2020-03-18 15:03 ` David Howells
2020-03-18 18:56 ` James Morris
2020-03-18 18:56 ` James Morris
2020-03-18 15:03 ` [PATCH 03/17] security: Add a hook for the point of notification insertion " David Howells
2020-03-18 15:03 ` David Howells
2020-03-18 18:57 ` James Morris
2020-03-18 18:57 ` James Morris
2020-03-18 15:03 ` [PATCH 04/17] pipe: Add O_NOTIFICATION_PIPE " David Howells
2020-03-18 15:03 ` [PATCH 05/17] pipe: Add general notification queue support " David Howells
2020-03-18 15:03 ` David Howells
2020-03-18 15:04 ` [PATCH 06/17] watch_queue: Add a key/keyring notification facility " David Howells
2020-03-18 15:04 ` David Howells
2020-03-18 19:04 ` James Morris
2020-03-18 19:04 ` James Morris
2020-03-18 15:04 ` [PATCH 07/17] Add sample notification program " David Howells
2020-03-18 15:04 ` David Howells
2020-03-18 15:04 ` [PATCH 08/17] pipe: Allow buffers to be marked read-whole-or-error for notifications " David Howells
2020-03-18 15:04 ` David Howells
2020-03-18 15:04 ` [PATCH 09/17] pipe: Add notification lossage handling " David Howells
2020-03-18 15:04 ` David Howells
2020-03-18 15:04 ` [PATCH 10/17] selinux: Implement the watch_key security hook " David Howells
2020-03-18 15:04 ` David Howells
2020-03-18 19:06 ` James Morris
2020-03-18 19:06 ` James Morris
2020-03-18 15:04 ` [PATCH 11/17] smack: Implement the watch_key and post_notification hooks " David Howells
2020-03-18 15:04 ` David Howells
2020-03-18 15:05 ` [PATCH 12/17] watch_queue: Add security hooks to rule on setting mount and sb watches " David Howells
2020-03-18 15:05 ` David Howells
2020-03-18 19:07 ` James Morris
2020-03-18 19:07 ` James Morris
2020-03-18 15:05 ` [PATCH 13/17] watch_queue: Implement mount topology and attribute change notifications " David Howells
2020-03-18 15:05 ` David Howells
2020-04-02 15:19 ` Miklos Szeredi
2020-04-02 15:19 ` Miklos Szeredi
2020-06-14 3:07 ` Ian Kent
2020-06-14 3:07 ` Ian Kent
2020-06-15 8:44 ` Miklos Szeredi
2020-06-15 8:44 ` Miklos Szeredi
2020-07-23 10:48 ` David Howells
2020-07-23 10:48 ` David Howells
2020-08-03 9:29 ` Miklos Szeredi
2020-08-03 9:29 ` Miklos Szeredi
2020-08-04 11:38 ` Ian Kent
2020-08-04 11:38 ` Ian Kent
2020-08-04 13:19 ` Miklos Szeredi
2020-08-04 13:19 ` Miklos Szeredi
2020-08-05 1:53 ` Ian Kent
2020-08-05 1:53 ` Ian Kent
2020-08-05 7:43 ` Miklos Szeredi
2020-08-05 7:43 ` Miklos Szeredi
2020-08-05 11:36 ` Ian Kent
2020-08-05 11:36 ` Ian Kent
2020-08-05 11:56 ` Miklos Szeredi
2020-08-05 11:56 ` Miklos Szeredi
2020-07-24 10:19 ` David Howells
2020-07-24 10:19 ` David Howells
2020-07-24 10:44 ` Ian Kent
2020-07-24 10:44 ` Ian Kent
2020-07-24 11:36 ` David Howells
2020-07-24 11:36 ` David Howells
2020-08-03 10:02 ` Miklos Szeredi
2020-08-03 10:02 ` Miklos Szeredi
2020-08-03 10:08 ` David Howells
2020-08-03 10:08 ` David Howells
2020-08-03 10:18 ` David Howells
2020-08-03 10:18 ` David Howells
2020-08-03 11:17 ` Miklos Szeredi
2020-08-03 11:17 ` Miklos Szeredi
2020-08-03 11:49 ` David Howells
2020-08-03 11:49 ` David Howells
2020-08-03 12:01 ` Ian Kent
2020-08-03 12:01 ` Ian Kent
2020-08-03 12:31 ` David Howells
2020-08-03 12:31 ` David Howells
2020-08-03 14:30 ` Ian Kent [this message]
2020-08-03 14:30 ` Ian Kent
2020-03-18 15:05 ` [PATCH 14/17] watch_queue: sample: Display mount tree " David Howells
2020-03-18 15:05 ` David Howells
2020-03-18 15:05 ` [PATCH 15/17] watch_queue: Introduce a non-repeating system-unique superblock ID " David Howells
2020-03-18 15:05 ` [PATCH 16/17] watch_queue: Add superblock notifications " David Howells
2020-03-18 15:05 ` David Howells
2020-03-18 15:05 ` [PATCH 17/17] watch_queue: sample: Display " David Howells
2020-03-18 15:05 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bfba8e858885b8c507b8816d5296f7ab7f949e78.camel@themaw.net \
--to=raven@themaw.net \
--cc=andres@anarazel.de \
--cc=casey@schaufler-ca.com \
--cc=christian@brauner.io \
--cc=dhowells@redhat.com \
--cc=dray@redhat.com \
--cc=jlayton@redhat.com \
--cc=keyrings@vger.kernel.org \
--cc=kzak@redhat.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=nicolas.dichtel@6wind.com \
--cc=sds@tycho.nsa.gov \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.