All of lore.kernel.org
 help / color / mirror / Atom feed
From: sbhanu@codeaurora.org
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: adrian.hunter@intel.com, ulf.hansson@linaro.org,
	robh+dt@kernel.org, sartgarg@codeaurora.org,
	asutoshd@codeaurora.org, stummala@codeaurora.org,
	vbadigan@codeaurora.org, rampraka@codeaurora.org,
	sayalil@codeaurora.org, rnayak@codeaurora.org,
	saiprakash.ranjan@codeaurora.org, sibis@codeaurora.org,
	cang@codeaurora.org, pragalla@codeaurora.org,
	nitirawa@codeaurora.org, linux-mmc@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	devicetree@vger.kernel.org, agross@kernel.org
Subject: Re: [PATCH V1] arm64: dts: qcom: sc7280: Add nodes for eMMC and SD card
Date: Sat, 13 Mar 2021 13:47:49 +0530	[thread overview]
Message-ID: <bfd67fa65b0c012e06dc5691c85c1c63@codeaurora.org> (raw)
In-Reply-To: <b25a0793df3bc6ae841502aca1f9fc3e@codeaurora.org>

On 2021-03-10 19:17, sbhanu@codeaurora.org wrote:
> On 2021-03-10 01:32, Bjorn Andersson wrote:
>> On Tue 09 Mar 13:18 CST 2021, Shaik Sajida Bhanu wrote:
>> 
>>> Add nodes for eMMC and SD card on sc7280.
>>> 
>>> Signed-off-by: Shaik Sajida Bhanu <sbhanu@codeaurora.org>
>>> 
>>> ---
>>> This change is depends on the below patch series:
>>> https://lore.kernel.org/lkml/1613114930-1661-1-git-send-email-rnayak@codeaurora.org/
>>> https://lore.kernel.org/patchwork/project/lkml/list/?series=&submitter=28035&state=&q=&archive=&delegate=
>>> ---
>>>  arch/arm64/boot/dts/qcom/sc7280-idp.dts |  26 +++++
>>>  arch/arm64/boot/dts/qcom/sc7280.dtsi    | 170 
>>> ++++++++++++++++++++++++++++++++
>>>  2 files changed, 196 insertions(+)
>>> 
>>> diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dts 
>>> b/arch/arm64/boot/dts/qcom/sc7280-idp.dts
>>> index ac79420..6abb2aa 100644
>>> --- a/arch/arm64/boot/dts/qcom/sc7280-idp.dts
>>> +++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dts
>>> @@ -8,6 +8,7 @@
>>>  /dts-v1/;
>>> 
>>>  #include "sc7280.dtsi"
>>> +#include <dt-bindings/gpio/gpio.h>
>>> 
>>>  / {
>>>  	model = "Qualcomm Technologies, Inc. SC7280 IDP platform";
>>> @@ -256,3 +257,28 @@
>>>  		bias-pull-up;
>>>  	};
>>>  };
>>> +
>>> +&sdhc_1 {
>>> +	status = "okay";
>>> +
>>> +	pinctrl-names = "default", "sleep";
>>> +	pinctrl-0 = <&sdc1_on>;
>>> +	pinctrl-1 = <&sdc1_off>;
>>> +
>>> +	vmmc-supply = <&vreg_l7b_2p9>;
>>> +	vqmmc-supply = <&vreg_l19b_1p8>;
>>> +
>>> +};
>>> +
>>> +&sdhc_2 {
>>> +	status = "okay";
>>> +
>>> +	pinctrl-names = "default","sleep";
>>> +	pinctrl-0 = <&sdc2_on>;
>>> +	pinctrl-1 = <&sdc2_off>;
>>> +
>>> +	vmmc-supply = <&vreg_l9c_2p9>;
>>> +	vqmmc-supply = <&vreg_l6c_2p9>;
>>> +
>>> +	cd-gpios = <&tlmm 91 GPIO_ACTIVE_LOW>;
>> 
>> Please add these nodes above the comment that says "PINCTRL -
>> additions..." and please include the pinctrl state for gpio 91.
>> 
> sure
Hi

>> "and please include the pinctrl state for gpio 91"
sorry didn't get this

>>> +};
>>> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi 
>>> b/arch/arm64/boot/dts/qcom/sc7280.dtsi
>>> index 3b86052..91fb18a 100644
>>> --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
>>> +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
>>> @@ -18,6 +18,11 @@
>>> 
>>>  	chosen { };
>>> 
>>> +	aliases {
>>> +		mmc1 = &sdhc_1;
>>> +		mmc2 = &sdhc_2;
>>> +	};
>>> +
>>>  	clocks {
>>>  		xo_board: xo-board {
>>>  			compatible = "fixed-clock";
>>> @@ -315,6 +320,69 @@
>>>  			#power-domain-cells = <1>;
>>>  		};
>>> 
>>> +		sdhc_1: sdhci@7c4000 {
>>> +			compatible = "qcom,sdhci-msm-v5";
>>> +			reg = <0 0x7c4000 0 0x1000>,
>>> +					<0 0x7c5000 0 0x1000>;
>>> +			reg-names = "hc", "cqhci";
>>> +
>>> +			iommus = <&apps_smmu 0xC0 0x0>;
>>> +			interrupts = <GIC_SPI 652 IRQ_TYPE_LEVEL_HIGH>,
>>> +					<GIC_SPI 656 IRQ_TYPE_LEVEL_HIGH>;
>>> +			interrupt-names = "hc_irq", "pwr_irq";
>>> +
>>> +			clocks = <&gcc GCC_SDCC1_APPS_CLK>,
>>> +					<&gcc GCC_SDCC1_AHB_CLK>,
>>> +					<&rpmhcc RPMH_CXO_CLK>;
>>> +			clock-names = "core", "iface", "xo";
>>> +
>>> +			bus-width = <8>;
>>> +			non-removable;
>>> +			supports-cqe;
>>> +			no-sd;
>>> +			no-sdio;
>>> +
>>> +			max-frequency = <192000000>;
>>> +
>>> +			qcom,dll-config = <0x0007642c>;
>>> +			qcom,ddr-config = <0x80040868>;
>>> +
>>> +			mmc-ddr-1_8v;
>>> +			mmc-hs200-1_8v;
>>> +			mmc-hs400-1_8v;
>>> +			mmc-hs400-enhanced-strobe;
>>> +
>>> +			status = "disabled";
>>> +
>>> +		};
>>> +
>>> +		sdhc_2: sdhci@8804000 {
>>> +			compatible = "qcom,sdhci-msm-v5";
>>> +			reg = <0 0x08804000 0 0x1000>;
>>> +
>>> +			iommus = <&apps_smmu 0x100 0x0>;
>>> +			interrupts = <GIC_SPI 207 IRQ_TYPE_LEVEL_HIGH>,
>>> +					<GIC_SPI 223 IRQ_TYPE_LEVEL_HIGH>;
>>> +			interrupt-names = "hc_irq", "pwr_irq";
>>> +
>>> +			clocks = <&gcc GCC_SDCC2_APPS_CLK>,
>>> +					<&gcc GCC_SDCC2_AHB_CLK>,
>>> +					<&rpmhcc RPMH_CXO_CLK>;
>>> +			clock-names = "core", "iface", "xo";
>>> +
>>> +			bus-width = <4>;
>>> +
>>> +			no-mmc;
>>> +			no-sdio;
>>> +
>>> +			max-frequency = <202000000>;
>>> +
>>> +			qcom,dll-config = <0x0007642c>;
>>> +
>>> +			status = "disabled";
>>> +
>>> +		};
>>> +
>>>  		qupv3_id_0: geniqup@9c0000 {
>>>  			compatible = "qcom,geni-se-qup";
>>>  			reg = <0 0x009c0000 0 0x2000>;
>>> @@ -385,6 +453,108 @@
>>>  				pins = "gpio46", "gpio47";
>>>  				function = "qup13";
>>>  			};
>>> +
>>> +			sdc1_on: sdc1-on {
>>> +				pinconf-clk {
>> 
>> The "pinconf-" prefix does not provide any value here. Can you please
>> drop it?
>> 
>> Regards,
>> Bjorn
> 
> sure will drop
>> 
>>> +					pins = "sdc1_clk";
>>> +					bias-disable;
>>> +					drive-strength = <16>;
>>> +				};
>>> +
>>> +				pinconf-cmd {
>>> +					pins = "sdc1_cmd";
>>> +					bias-pull-up;
>>> +					drive-strength = <10>;
>>> +				};
>>> +
>>> +				pinconf-data {
>>> +					pins = "sdc1_data";
>>> +					bias-pull-up;
>>> +					drive-strength = <10>;
>>> +				};
>>> +
>>> +				pinconf-rclk {
>>> +					pins = "sdc1_rclk";
>>> +					bias-pull-down;
>>> +				};
>>> +			};
>>> +
>>> +			sdc1_off: sdc1-off {
>>> +				pinconf-clk {
>>> +					pins = "sdc1_clk";
>>> +					bias-disable;
>>> +					drive-strength = <2>;
>>> +				};
>>> +
>>> +				pinconf-cmd {
>>> +					pins = "sdc1_cmd";
>>> +					bias-pull-up;
>>> +					drive-strength = <2>;
>>> +				};
>>> +
>>> +				pinconf-data {
>>> +					pins = "sdc1_data";
>>> +					bias-pull-up;
>>> +					drive-strength = <2>;
>>> +				};
>>> +
>>> +				pinconf-rclk {
>>> +					pins = "sdc1_rclk";
>>> +					bias-pull-down;
>>> +				};
>>> +			};
>>> +
>>> +			sdc2_on: sdc2-on {
>>> +				pinconf-clk {
>>> +					pins = "sdc2_clk";
>>> +					bias-disable;
>>> +					drive-strength = <16>;
>>> +				};
>>> +
>>> +				pinconf-cmd {
>>> +					pins = "sdc2_cmd";
>>> +					bias-pull-up;
>>> +					drive-strength = <10>;
>>> +				};
>>> +
>>> +				pinconf-data {
>>> +					pins = "sdc2_data";
>>> +					bias-pull-up;
>>> +					drive-strength = <10>;
>>> +				};
>>> +
>>> +				pinconf-sd-cd {
>>> +					pins = "gpio91";
>>> +					bias-pull-up;
>>> +					drive-strength = <2>;
>>> +				};
>>> +			};
>>> +
>>> +			sdc2_off: sdc2-off {
>>> +				pinconf-clk {
>>> +					pins = "sdc2_clk";
>>> +					bias-disable;
>>> +					drive-strength = <2>;
>>> +				};
>>> +
>>> +				pinconf-cmd {
>>> +					pins = "sdc2_cmd";
>>> +					bias-pull-up;
>>> +					drive-strength = <2>;
>>> +				};
>>> +
>>> +				pinconf-data {
>>> +					pins = "sdc2_data";
>>> +					bias-pull-up;
>>> +					drive-strength = <2>;
>>> +				};
>>> +
>>> +				pinconf-sd-cd {
>>> +					pins = "gpio91";
>>> +					bias-disable;
>>> +					drive-strength = <2>;
>>> +				};
>>> +			};
>>>  		};
>>> 
>>>  		apps_smmu: iommu@15000000 {
>>> --
>>> 2.7.4
>>> 

  reply	other threads:[~2021-03-13  8:18 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-09 19:18 [PATCH V1] arm64: dts: qcom: sc7280: Add nodes for eMMC and SD card Shaik Sajida Bhanu
2021-03-09 20:02 ` Bjorn Andersson
2021-03-10 13:47   ` sbhanu
2021-03-13  8:17     ` sbhanu [this message]
2021-03-09 20:50 ` Konrad Dybcio
2021-03-10 13:15   ` sbhanu
2021-03-10  4:48 ` Veerabhadrarao Badiganti
2021-03-10 13:14   ` sbhanu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bfd67fa65b0c012e06dc5691c85c1c63@codeaurora.org \
    --to=sbhanu@codeaurora.org \
    --cc=adrian.hunter@intel.com \
    --cc=agross@kernel.org \
    --cc=asutoshd@codeaurora.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=cang@codeaurora.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=nitirawa@codeaurora.org \
    --cc=pragalla@codeaurora.org \
    --cc=rampraka@codeaurora.org \
    --cc=rnayak@codeaurora.org \
    --cc=robh+dt@kernel.org \
    --cc=saiprakash.ranjan@codeaurora.org \
    --cc=sartgarg@codeaurora.org \
    --cc=sayalil@codeaurora.org \
    --cc=sibis@codeaurora.org \
    --cc=stummala@codeaurora.org \
    --cc=ulf.hansson@linaro.org \
    --cc=vbadigan@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.