Re: [PATCH 2/3] arm: dts: apple: Add watchdog timer node

[Stefan Roese <sr@denx.de>]

On 11/14/21 12:19, Mark Kettenis wrote:
> Add a node for the watchdog timer based on the proposed Linux
> device tree bindings.
> 
> Signed-off-by: Sven Peter <sven@svenpeter.dev>
> Signed-off-by: Mark Kettenis <kettenis@openbsd.org>
> ---
>   arch/arm/dts/t8103.dtsi | 13 ++++++++-----
>   1 file changed, 8 insertions(+), 5 deletions(-)
> 
> diff --git a/arch/arm/dts/t8103.dtsi b/arch/arm/dts/t8103.dtsi
> index 7d9cb272f9..03d8436fec 100644
> --- a/arch/arm/dts/t8103.dtsi
> +++ b/arch/arm/dts/t8103.dtsi
> @@ -328,6 +328,14 @@
>   				     <AIC_IRQ 336 IRQ_TYPE_LEVEL_HIGH>;
>   		};
>   
> +		wdt: watchdog@23d2b0000 {
> +			compatible = "apple,t8103-wdt", "apple,wdt";
> +			reg = <0x2 0x3d2b0000 0x0 0x4000>;
> +			clocks = <&clkref>;
> +			interrupt-parent = <&aic>;
> +			interrupts = <AIC_IRQ 338 IRQ_TYPE_LEVEL_HIGH>;
> +		};
> +
>   		pinctrl_smc: pinctrl@23e820000 {
>   			compatible = "apple,t8103-pinctrl", "apple,pinctrl";
>   			reg = <0x2 0x3e820000 0x0 0x4000>;
> @@ -529,11 +537,6 @@
>   			status = "disabled";
>   		};
>   
> -		reboot@23d2b0000 {
> -			compatible = "apple,reboot-v0";
> -			reg = <0x2 0x3d2b0000 0x0 0x4000>;
> -		};
> -

It would be helpful IMHO, if you could add a small comment in the commit
text, why you are removing this DT node with this patch.

Other than this:

Reviewed-by: Stefan Roese <sr@denx.de>

Thanks,
Stefan