All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Rosin <peda@axentia.se>
To: Philipp Zabel <p.zabel@pengutronix.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mux: add SPDX identifiers to all mux source files
Date: Fri, 8 Dec 2017 11:06:48 +0100	[thread overview]
Message-ID: <bff16a3b-92d8-9beb-78dd-d29a4f57f99e@axentia.se> (raw)
In-Reply-To: <1512726226.8762.1.camel@pengutronix.de>

On 2017-12-08 10:43, Philipp Zabel wrote:
> Hi Peter,
> 
> On Thu, 2017-12-07 at 22:08 +0100, Peter Rosin wrote:
>> diff --git a/drivers/mux/mmio.c b/drivers/mux/mmio.c
>> index 37c1de359a70..935ac44aa209 100644
>> --- a/drivers/mux/mmio.c
>> +++ b/drivers/mux/mmio.c
>> @@ -1,11 +1,8 @@
>> +// SPDX-License-Identifier: GPL-2.0
> 
> Acked-by: Philipp Zabel <p.zabel@pengutronix.de>

Thanks!

>> diff --git a/include/linux/mux/consumer.h b/include/linux/mux/consumer.h
>> index ea96d4c82be7..5fc6bb2fefad 100644
>> --- a/include/linux/mux/consumer.h
>> +++ b/include/linux/mux/consumer.h
>> @@ -1,13 +1,10 @@
>> +/* SPDX-License-Identifier: GPL-2.0 */
> 
> Is there a system to the different comment styles in c the files vs in
> the headers?

Yes, headers are sometimes included by assemblers and other tools that
can't handle "new style" comments. I think. I'm just following the lead
set by others...

Cheers,
Peter

  reply	other threads:[~2017-12-08 10:10 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-07 21:08 [PATCH] mux: add SPDX identifiers to all mux source files Peter Rosin
2017-12-07 21:24 ` Philippe Ombredanne
2017-12-08  9:43 ` Philipp Zabel
2017-12-08 10:06   ` Peter Rosin [this message]
2017-12-08 10:38   ` Philippe Ombredanne
2017-12-28 23:22 [PATCH] mux: core: fix double get_device() Peter Rosin
2017-12-28 23:22 ` [PATCH] mux: add SPDX identifiers to all mux source files Peter Rosin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bff16a3b-92d8-9beb-78dd-d29a4f57f99e@axentia.se \
    --to=peda@axentia.se \
    --cc=linux-kernel@vger.kernel.org \
    --cc=p.zabel@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.