All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laurent Vivier <laurent@vivier.eu>
To: Richard Henderson <rth@twiddle.net>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v4] target-m68k: add rol/ror/roxl/roxr instructions
Date: Sat, 12 Nov 2016 09:27:08 +0100	[thread overview]
Message-ID: <bff1bc45-502e-f069-2c0f-79bea67348a5@vivier.eu> (raw)
In-Reply-To: <8ae26fb1-89cb-f6c9-0d2c-ebd04b4d92f1@twiddle.net>

Le 12/11/2016 à 09:26, Richard Henderson a écrit :
> On 11/11/2016 10:25 PM, Laurent Vivier wrote:
>> Signed-off-by: Laurent Vivier <laurent@vivier.eu>
>> ---
>> v4:
>>  - don't overwrite TCGv descriptor in rotate16_reg()
>> v3:
>>  - fix rotate memory decoding
>>  - use "shx = shx < 0 ? size : shx;"
>>  - some cleanup
>> v2:
>>  - use shift to do rotate_x() for 8 and 16bit value
>>  - rotate_x()/rotate32_x() are  a no-op when shift % (size + 1) == 0
>>  - add some missing tcg_temp_free()
>>
>>  target-m68k/translate.c | 391
>> ++++++++++++++++++++++++++++++++++++++++++++++++
>>  1 file changed, 391 insertions(+)
> 
> Reviewed-by: Richard Henderson <rth@twiddle.net>
> 
>> +/* Result of rotate_x() is valid if 0 <= shift < 32 */
> 
> Comment is wrong now -- 0 <= shift <= size.

OK, I update the comment and put it in m68k-for-2.9

Thanks,
Laurent

  reply	other threads:[~2016-11-12  8:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-11 21:25 [Qemu-devel] [PATCH v4] target-m68k: add rol/ror/roxl/roxr instructions Laurent Vivier
2016-11-12  8:26 ` Richard Henderson
2016-11-12  8:27   ` Laurent Vivier [this message]
2016-11-27 17:48 ` Laurent Vivier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bff1bc45-502e-f069-2c0f-79bea67348a5@vivier.eu \
    --to=laurent@vivier.eu \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.