From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1lHyFk-0004QT-H0 for mharc-grub-devel@gnu.org; Thu, 04 Mar 2021 19:23:36 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:51754) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lHyFc-0004M7-3F for grub-devel@gnu.org; Thu, 04 Mar 2021 19:23:29 -0500 Received: from mail-qk1-x72a.google.com ([2607:f8b0:4864:20::72a]:34222) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lHyFO-0006QE-7g for grub-devel@gnu.org; Thu, 04 Mar 2021 19:23:27 -0500 Received: by mail-qk1-x72a.google.com with SMTP id t4so383805qkp.1 for ; Thu, 04 Mar 2021 16:23:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficientek-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=5FW/33FuSTbSljQDB+fWcmo4AtuqRcqOamnp41uD0bU=; b=Z3T9+BTelrQcGJ0ibJpzUecmEuk/bHuWvcK8WU6mZIcbla5Ju3yiqKU2k+GQiiEVAd kagZ9thdFUFdoKSp+rm5aOJk0YBwAu2/tw2iCUWB5gfM/kyyZKFEFc1edMfLO+w7Ex9M kMVffKH5DkrBAXrPqJrjNc+49nsINkY9mJAA4KAAX8cW8G5AYhYVypmxuYTZNsua1aVY +PygbOtNjUfHJVz5sobdPl2ZOEiVNu4vaZHnv/C4LBAs5MKGMIiaEV5RvoFWaIpu9T0x 5aS/ke+ng8liqvjQG0rcylEBJYQE3xTfNbUHHlS/4Vr9JwCXDAMTsdSGpEayh9M0nis9 of8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=5FW/33FuSTbSljQDB+fWcmo4AtuqRcqOamnp41uD0bU=; b=tvgovZJIrLym+9lH5Yv9WB9AytcbArqgh/aGP7p1S/QAObelEQtt99J2dXMmpphtqt TEdNUaRw8Qy6gngRjx7bfcxIPJYa8H6UjeQXCNcyretgmgY6PC6941+pz1RQlxTSfmnb 7+X/SXFIuwGIrOBXSgLGs1ob+n4/vr5FRJ/dT+v3SLkf9mITa4Cgvvm5Da1O63TUgGUo xlKH668rel6TLLq8LVIn6IUtDA5y/VZoYdEAmoAeeP1W215WNq97JRc8MeV9gm23LDRV +6gyjp8vpWUgISgV+j/o+ooEJs2mu1zAZfuMy+USwR73BOUJ5g7Qpr2SWyMvg2pJLdBJ P4CA== X-Gm-Message-State: AOAM530fjQx7ti9mK2GtzP+tSU+Hel85znF4dGhfbxir8XzEvCvZ+vgR yT6htoifBEVOXl6WEP8UhMiSn3B2aXK3uA== X-Google-Smtp-Source: ABdhPJxe5GD1FEmfrUv8WERykJ/oQEb4DLAIMga8miIU01NUhRv0f8BrCttSbNEOmK00uhwLvADDUg== X-Received: by 2002:a37:5905:: with SMTP id n5mr6618953qkb.191.1614903792174; Thu, 04 Mar 2021 16:23:12 -0800 (PST) Received: from localhost.localdomain ([2605:a601:aac5:3700:9763:81c2:19e4:8a8f]) by smtp.gmail.com with ESMTPSA id 75sm674558qkd.114.2021.03.04.16.23.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Mar 2021 16:23:11 -0800 (PST) From: Glenn Washburn To: grub-devel@gnu.org, Daniel Kiper Cc: Glenn Washburn Subject: [PATCH v6 06/14] pgp: Format code for grub_error is incorrect Date: Thu, 4 Mar 2021 18:22:37 -0600 Message-Id: X-Mailer: git-send-email 2.27.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::72a; envelope-from=development@efficientek.com; helo=mail-qk1-x72a.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Mar 2021 00:23:30 -0000 The format code is for a 32-bit int, but the argument, keyid, is declared as a 64 bit int. The comment above says keyid is 32-bit. I'm not sure if the comment or declaration is wrong, so force the display of a 64-bit int for now. Signed-off-by: Glenn Washburn --- grub-core/commands/pgp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/grub-core/commands/pgp.c b/grub-core/commands/pgp.c index bbf6871fe..5daa1e9d0 100644 --- a/grub-core/commands/pgp.c +++ b/grub-core/commands/pgp.c @@ -633,8 +633,8 @@ grub_verify_signature_real (struct grub_pubkey_context *ctxt, if (!sk) { /* TRANSLATORS: %08x is 32-bit key id. */ - grub_error (GRUB_ERR_BAD_SIGNATURE, N_("public key %08x not found"), - keyid); + grub_error (GRUB_ERR_BAD_SIGNATURE, + N_("public key %08" PRIxGRUB_UINT64_T " not found"), keyid); goto fail; } -- 2.27.0