From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 787E3C4320A for ; Wed, 25 Aug 2021 15:42:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 60C416109E for ; Wed, 25 Aug 2021 15:42:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231995AbhHYPnD (ORCPT ); Wed, 25 Aug 2021 11:43:03 -0400 Received: from codesynthesis.com ([188.40.148.39]:44846 "EHLO codesynthesis.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240878AbhHYPnC (ORCPT ); Wed, 25 Aug 2021 11:43:02 -0400 X-Greylist: delayed 453 seconds by postgrey-1.27 at vger.kernel.org; Wed, 25 Aug 2021 11:43:01 EDT Received: from brak.codesynthesis.com (197-255-152-207.static.adept.co.za [197.255.152.207]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by codesynthesis.com (Postfix) with ESMTPSA id EC3275F7CB; Wed, 25 Aug 2021 15:34:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codesynthesis.com; s=mail1; t=1629905681; bh=njRimGOIAbqbKx/5ZrZSGnm8dBTrS6TRY3ucp7C/bzU=; h=Date:From:To:Subject:Message-ID:MIME-Version:From; b=M4Zeq9iy/BsSsC3ucqhrc8i/ZaAxdzH10P5jgmpgL4PwLblF/Fp947GMfSBXeNsjq NuVIW50/nTWLqphqH0bmluRAxc0xwe2C4oPm8c3f82SB7NkwrgSfclPFXG73pD0L0h BXOpQO6Icl3wl7OePxAFtZ7q+2CMRU9b3Qt4+Lm1L2wJkxTOQ3DpJExmWuUMQyAheR kyHK+EDh37gLQ1jZZ8I0aj6iXvXQ9trqsiJeiZDTSWqktv5++p/YTyknMZMmxFNd7P pNCo5LQJUmP3rmiNyTGDZjJtNKJ5AnGpM3Qc/HQWkVB6YyRtxYHeF5BjZsSZXaAbiu PCHHvOofYHbwQ== Received: by brak.codesynthesis.com (Postfix, from userid 1000) id 1A3B11A800C4; Wed, 25 Aug 2021 17:34:37 +0200 (SAST) Date: Wed, 25 Aug 2021 17:34:37 +0200 From: Boris Kolpackov To: Masahiro Yamada Cc: linux-kbuild@vger.kernel.org, "David S. Miller" , Jakub Kicinski , Jaroslav Kysela , Kalle Valo , Liam Girdwood , Luca Coelho , Mark Brown , Peter Ujfalusi , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH] kconfig: forbid symbols that end with '_MODULE' Message-ID: References: <20210825041637.365171-1-masahiroy@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210825041637.365171-1-masahiroy@kernel.org> Organization: Code Synthesis User-Agent: Mutt/1.5.24 (2015-08-30) Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Masahiro Yamada writes: > Kconfig (syncconfig) generates include/generated/autoconf.h to make > CONFIG options available to the pre-processor. > > The macros are suffixed with '_MODULE' for symbols with the value 'm'. > > Here is a conflict; CONFIG_FOO=m results in '#define CONFIG_FOO_MODULE 1', > but CONFIG_FOO_MODULE=y also results in the same define. > > fixdep always assumes CONFIG_FOO_MODULE comes from CONFIG_FOO=m, so the > dependency is not properly tracked for symbols that end with '_MODULE'. It seem to me the problem is in autoconf.h/fixdep, not in the Kconfig language. > This commit makes Kconfig error out if it finds a symbol suffixed with > '_MODULE'. I know you don't care, but I will voice my objection, for the record: Kconfig is used by projects other than the Linux kernel and some of them do not use the autoconf.h functionality. For such projects this restriction seems arbitrary and potentially backwards-incompatible. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E858CC432BE for ; Thu, 26 Aug 2021 12:57:45 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DA5FF60F5C for ; Thu, 26 Aug 2021 12:57:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org DA5FF60F5C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codesynthesis.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 71C82165E; Thu, 26 Aug 2021 14:56:53 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 71C82165E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1629982663; bh=njRimGOIAbqbKx/5ZrZSGnm8dBTrS6TRY3ucp7C/bzU=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=tylLDF8lfnMggt3oQhf6mPH708iJpRb+vPKqfeDxKv4w3CVIYLxncDwcoMUSZnPuO u9wlS2XoFV+ppjIFMxOtAcIOcheEe1tUZKBV1rEGqaHeKeuc5HR5XXaQurzUPBRq9X JfPvU35hPCT9q71DVR4WSb+EVvl38ADtFy24KHqU= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 02EA7F80224; Thu, 26 Aug 2021 14:56:14 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 77094F800AE; Wed, 25 Aug 2021 17:34:46 +0200 (CEST) Received: from codesynthesis.com (codesynthesis.com [188.40.148.39]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 33E60F800C9 for ; Wed, 25 Aug 2021 17:34:41 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 33E60F800C9 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=codesynthesis.com header.i=@codesynthesis.com header.b="M4Zeq9iy" Received: from brak.codesynthesis.com (197-255-152-207.static.adept.co.za [197.255.152.207]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by codesynthesis.com (Postfix) with ESMTPSA id EC3275F7CB; Wed, 25 Aug 2021 15:34:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codesynthesis.com; s=mail1; t=1629905681; bh=njRimGOIAbqbKx/5ZrZSGnm8dBTrS6TRY3ucp7C/bzU=; h=Date:From:To:Subject:Message-ID:MIME-Version:From; b=M4Zeq9iy/BsSsC3ucqhrc8i/ZaAxdzH10P5jgmpgL4PwLblF/Fp947GMfSBXeNsjq NuVIW50/nTWLqphqH0bmluRAxc0xwe2C4oPm8c3f82SB7NkwrgSfclPFXG73pD0L0h BXOpQO6Icl3wl7OePxAFtZ7q+2CMRU9b3Qt4+Lm1L2wJkxTOQ3DpJExmWuUMQyAheR kyHK+EDh37gLQ1jZZ8I0aj6iXvXQ9trqsiJeiZDTSWqktv5++p/YTyknMZMmxFNd7P pNCo5LQJUmP3rmiNyTGDZjJtNKJ5AnGpM3Qc/HQWkVB6YyRtxYHeF5BjZsSZXaAbiu PCHHvOofYHbwQ== Received: by brak.codesynthesis.com (Postfix, from userid 1000) id 1A3B11A800C4; Wed, 25 Aug 2021 17:34:37 +0200 (SAST) Date: Wed, 25 Aug 2021 17:34:37 +0200 From: Boris Kolpackov To: Masahiro Yamada Subject: Re: [PATCH] kconfig: forbid symbols that end with '_MODULE' Message-ID: References: <20210825041637.365171-1-masahiroy@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210825041637.365171-1-masahiroy@kernel.org> Organization: Code Synthesis User-Agent: Mutt/1.5.24 (2015-08-30) X-Mailman-Approved-At: Thu, 26 Aug 2021 14:56:12 +0200 Cc: alsa-devel@alsa-project.org, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, Takashi Iwai , linux-wireless@vger.kernel.org, Liam Girdwood , Mark Brown , Luca Coelho , netdev@vger.kernel.org, Jakub Kicinski , Peter Ujfalusi , "David S. Miller" , Kalle Valo X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Masahiro Yamada writes: > Kconfig (syncconfig) generates include/generated/autoconf.h to make > CONFIG options available to the pre-processor. > > The macros are suffixed with '_MODULE' for symbols with the value 'm'. > > Here is a conflict; CONFIG_FOO=m results in '#define CONFIG_FOO_MODULE 1', > but CONFIG_FOO_MODULE=y also results in the same define. > > fixdep always assumes CONFIG_FOO_MODULE comes from CONFIG_FOO=m, so the > dependency is not properly tracked for symbols that end with '_MODULE'. It seem to me the problem is in autoconf.h/fixdep, not in the Kconfig language. > This commit makes Kconfig error out if it finds a symbol suffixed with > '_MODULE'. I know you don't care, but I will voice my objection, for the record: Kconfig is used by projects other than the Linux kernel and some of them do not use the autoconf.h functionality. For such projects this restriction seems arbitrary and potentially backwards-incompatible.