[Bug 100510] [radeon] Heavy artifacts during hw accelerated playback of wmv files

[Bug 100510] [radeon] Heavy artifacts during hw accelerated playback of wmv files

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 1712 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=100510

            Bug ID: 100510
           Summary: [radeon] Heavy artifacts during hw accelerated
                    playback of wmv files
           Product: DRI
           Version: unspecified
          Hardware: Other
                OS: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: libdrm
          Assignee: dri-devel@lists.freedesktop.org
          Reporter: jan.burgmeier@unicon-software.com

Hi,

with versions newer than libdrm-2.4.66 I have heavy artifacts during hw
accelerated playback of wmv files vaapi/vdpau tested with gstreamer-
0.10 and ffmpeg based mpv.

The error occures only with wmv, h264 works.

Bisect result:
db138b9ba12a0de5d6140832c0679c2418e3e7e0 is the first bad commit
commit db138b9ba12a0de5d6140832c0679c2418e3e7e0
Author: Michel Dänzer <michel.daenzer@amd.com>
Date:   Thu Jan 21 18:08:49 2016 +0900

    radeon: Pass radeon_bo_open flags to the DRM_RADEON_GEM_CREATE ioctl

    Not doing so makes it impossible for radeon_bo_open callers to set any
    RADEON_GEM_* flags for the newly created BO.

    Reviewed-by: Alex Deucher <alexander.deucher@amd.com>

If I revert this commit on the current master branch the artefacts are
gone.

System environment:
-- chipset: AMD GX-217GA SOC with Radeon(tm) HD Graphics
-- system architecture: 32-bit
-- xserver: 1.19.1
-- mesa: 13.0.3, 13.0.6, 17.0.2
-- libdrm: 2.4.74
-- kernel: 4.4.11
-- Linux distribution: eLux
-- Machine or mobo model: HP t620 dual core thin client

Regards,
Jan Burgmeier

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 3126 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 100510] [radeon] Heavy artifacts during hw accelerated playback of wmv files

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 248 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=100510

--- Comment #1 from Christian König <deathsimple@vodafone.de> ---
Please attach your full dmesg output as well.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1077 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 100510] [radeon] Heavy artifacts during hw accelerated playback of wmv files

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 327 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=100510

--- Comment #2 from Jan Burgmeier <jan.burgmeier@unicon-software.com> ---
Created attachment 130614
  --> https://bugs.freedesktop.org/attachment.cgi?id=130614&action=edit
full dmesg output

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1289 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 100510] [radeon] Heavy artifacts during hw accelerated playback of wmv files

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 585 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=100510

--- Comment #3 from Christian König <deathsimple@vodafone.de> ---
Created attachment 130615
  --> https://bugs.freedesktop.org/attachment.cgi?id=130615&action=edit
Hack for testing

Please apply the attached code change with "git apply hack.patch" on a linux
kernel tree and see if that helps.

It overrides the setting from libdrm to always use VRAM for UVD submissions.
Not a final solution, but it should help to narrow down the problem.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1634 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 100510] [radeon] Heavy artifacts during hw accelerated playback of wmv files

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 278 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=100510

--- Comment #4 from Jan Burgmeier <jan.burgmeier@unicon-software.com> ---
I applied the hack to HEAD of the staging-next branch and it worked.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1114 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 100510] [radeon] Heavy artifacts during hw accelerated playback of wmv files

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 1211 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=100510

Christian König <deathsimple@vodafone.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #130615|0                           |1
        is obsolete|                            |

--- Comment #5 from Christian König <deathsimple@vodafone.de> ---
Created attachment 130618
  --> https://bugs.freedesktop.org/attachment.cgi?id=130618&action=edit
Hack number 2 for testing

Ok, just as I expected we suddenly don't put buffers into VRAM any more and the
UVD block has an undocumented requirement for WMV playback that those buffers
needs to be in VRAM.

No idea why user space is broken, but the kernel should catch such cases and
force them into VRAM when the hardware needs that.

Please revert the last hack and try this one. It should only the first and
second buffer into VRAM.

If that doesn't work try to change the if so that the first,second and third
buffer are forced into VRAM etc....

I need to know which one is needed in VRAM here.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2814 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 100510] [radeon] Heavy artifacts during hw accelerated playback of wmv files

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 245 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=100510

--- Comment #6 from Jan Burgmeier <jan.burgmeier@unicon-software.com> ---
Your hack number 2 worked directly.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1081 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 100510] [radeon] Heavy artifacts during hw accelerated playback of wmv files

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 318 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=100510

--- Comment #7 from Christian König <deathsimple@vodafone.de> ---
Created attachment 130810
  --> https://bugs.freedesktop.org/attachment.cgi?id=130810&action=edit
Final solution.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1355 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 100510] [radeon] Heavy artifacts during hw accelerated playback of wmv files

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 437 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=100510

Christian König <deathsimple@vodafone.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1291 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 100510] [radeon] Heavy artifacts during hw accelerated playback of wmv files

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 596 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=100510

Michel Dänzer <michel@daenzer.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|michel@daenzer.net          |

--- Comment #8 from Michel Dänzer <michel@daenzer.net> ---
Thanks, but I actually receive updates via the dri-devel mailing list.

Do we know yet which flags are getting passed to radeon_bo_open for the BO(s)
in question?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2080 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 100510] [radeon] Heavy artifacts during hw accelerated playback of wmv files

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 505 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=100510

--- Comment #9 from Christian König <deathsimple@vodafone.de> ---
(In reply to Michel Dänzer from comment #8)
> Thanks, but I actually receive updates via the dri-devel mailing list.
> 
> Do we know yet which flags are getting passed to radeon_bo_open for the
> BO(s) in question?

No, so far I've concentrated on figuring out what's going on inside the kernel.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1466 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 100510] [radeon] Heavy artifacts during hw accelerated playback of wmv files

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 1213 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=100510

Arthur Marsh <arthur.marsh@internode.on.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |---

--- Comment #10 from Arthur Marsh <arthur.marsh@internode.on.net> ---
commit 8f12bbe6d94a51f3ae314c27cc7b9b315adfe383
Author: Christian König <christian.koenig@amd.com>
Date:   Tue Apr 11 19:20:20 2017 +0200

    drm/radeon: force the UVD DPB into VRAM as well

    Seems to be mandatory for WMV playback.

    Bugs: https://bugs.freedesktop.org/show_bug.cgi?id=100510

breaks video playback for me with a VERDE card (DVD and some other formats),
with the error: 

[75728.141010] [drm:radeon_uvd_cs_parse [radeon]] *ERROR* msg/fb buffer
14674000-1686F000 out of 256MB segment!                                         
[75728.141030] [drm:radeon_cs_ioctl [radeon]] *ERROR* Invalid command stream !

I'm happy to supply more specifics of my configuration.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2995 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 100510] [radeon] Heavy artifacts during hw accelerated playback of wmv files

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 622 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=100510

Michel Dänzer <michel@daenzer.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|REOPENED                    |RESOLVED

--- Comment #11 from Michel Dänzer <michel@daenzer.net> ---
Arthur, please file your own report. The commit in question did fix the problem
reported here, so this is the correct status.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2187 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel