[Bug 101294] radeonsi minecraft forge splash freeze since 17.1

[Bug 101294] radeonsi minecraft forge splash freeze since 17.1

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 1862 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=101294

            Bug ID: 101294
           Summary: radeonsi minecraft forge splash freeze since 17.1
           Product: Mesa
           Version: 17.1
          Hardware: x86-64 (AMD64)
                OS: Linux (All)
            Status: NEW
          Severity: normal
          Priority: medium
         Component: Drivers/Gallium/radeonsi
          Assignee: dri-devel@lists.freedesktop.org
          Reporter: tobi291019@gmail.com
        QA Contact: dri-devel@lists.freedesktop.org

Launching Minecraft with Forge installed (vanilla is fine, only happens with
the splash screen enabled) often causes a glSwapBuffers to never return and
spin on a single cpu core.

The freeze seems to always occur right after the texture atlas was created (can
be seen in log) and similarly on the same step on the splash itself, so it is
possible that this is some interaction between the splash rendering and loading
resources.

The rest of the system continues to run fine and running SIGKILL is enough to
stop the process (Other OpenGL-based applications continue function as
expected).

Running on Arch Linux, with Mesa 17.1.0, OpenJDK 8.u121-1 with an AMD Radeon
RX480 (8 GB) and a custom compiled Linux 4.11.3 kernel (Based linux-zen package
with ACS override).

This has happened on older kernel versions as well and the exact Minecraft and
Forge versions do not seem to matter (beside that it is at least Minecraft 1.7,
which is when that splash screen got added).

I have also observed a very similar freeze (spinning on single core, no
system-wide effects) with QupZilla (Qt 5.8, WebEngine), however this is very
rare and I could not get any specific info on it. No other programs seem
affected.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 3236 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 101294] radeonsi minecraft forge splash freeze since 17.1

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 299 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=101294

--- Comment #1 from Michel Dänzer <michel@daenzer.net> ---
When it's frozen, attach gdb to the process, run

 thread apply all bt

and attach the output here.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1083 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 101294] radeonsi minecraft forge splash freeze since 17.1

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 372 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=101294

--- Comment #2 from Tobias Auerochs <tobi291019@gmail.com> ---
Created attachment 131700
  --> https://bugs.freedesktop.org/attachment.cgi?id=131700&action=edit
Thread dump on Arch Linux mesa 17.1.0 PKGBUILD rebuilt with debug symbols

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1397 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 101294] radeonsi minecraft forge splash freeze since 17.1

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 361 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=101294

--- Comment #3 from Tobias Auerochs <tobi291019@gmail.com> ---
Created attachment 131721
  --> https://bugs.freedesktop.org/attachment.cgi?id=131721&action=edit
Same freeze in QupZilla (main process) with similar backtraces

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1364 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 101294] radeonsi minecraft forge splash freeze since 17.1

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 389 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=101294

--- Comment #4 from Michel Dänzer <michel@daenzer.net> ---
Looks like a deadlock involving struct pb_cache::mutex and struct
amdgpu_winsys::bo_fence_lock. One thread locked the former and wants to lock
the latter, another thread the other way around.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1173 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 101294] radeonsi minecraft forge splash freeze since 17.1

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 951 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=101294

Fabian Maurer <dark.shadow4@web.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dark.shadow4@web.de

--- Comment #5 from Fabian Maurer <dark.shadow4@web.de> ---
I can confirm the issue.

It doesn't always happen, but most of the time - it's fairly easy to reproduce.
Usually happens when you have a lot mods (I think).

LIBGL_ALWAYS_SOFTWARE resolves that issue and lets it load, and you can play it
just fine.

System the issue was tested on:
- Arch Linux 64bit
- Linux 4.11.6, AMDGPU driver
- Mesa 17.2.0-devel (git-58d337941e) / Mesa 17.1.2
- Radeon R9 285

I think it used to work previously, I'll run some regression tests in the
coming days.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2282 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 101294] radeonsi minecraft forge splash freeze since 17.1

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 1030 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=101294

--- Comment #6 from Fabian Maurer <dark.shadow4@web.de> ---
Bisected to
commit 2769dadb0fafdbafc98630fdf96924a3bb209ab7
Author: Marek Olšák <marek.olsak@amd.com>
Date:   Thu Apr 13 23:46:59 2017 +0200

    gallium/radeon: always flush asynchronously and wait after begin_new_cs

    This hides the overhead of everything in the driver after the CS flush and
    before returning from pipe_context::flush.
    Only microbenchmarks will benefit.

    +2% FPS for glxgears.

    Reviewed-by: Nicolai Hähnle <nicolai.haehnle@amd.com>


Reverting this commit on the recent git tree fixes the freezes.
Now since the bug doesn't always appear, I'm not 100% sure, but I didn't get a
single freeze in 20 runs, while I got 13 out of 20 without reverting it.


Could you maybe look into this? I have no idea how to fix the issue without
throwing away all changes from this commit.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1928 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 101294] radeonsi minecraft forge splash freeze since 17.1

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 374 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=101294

Fabian Maurer <dark.shadow4@web.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |bisected

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1085 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 101294] radeonsi minecraft forge splash freeze since 17.1

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 826 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=101294

--- Comment #7 from Marek Olšák <maraeo@gmail.com> ---
The bisected commit only uncovers the existing deadlock scenario.

Summary of the issue.

amdgpu_bo_create
-> pb_cache_reclaim_buffer (lock pb_cache::mutex)
-> pb_cache_is_buffer_compat
-> amdgpu_bo_wait (lock bo_fence_lock) - DEADLOCK

pb_reference
-> pb_destroy
-> amdgpu_bo_destroy_or_cache
-> pb_cache_add_buffer (lock::pb_cache::mutex) - DEADLOCK

amdgpu_cs_flush (lock bo_fence_lock)
-> amdgpu_add_fence_dependency (loop-wait for submission_in_progress) -
DEADLOCK


It looks the best way to prevent this deadlock is to unify pb_cache::mutex and
bo_fence_lock under one lock, that is, one of them has to go.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1628 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 101294] radeonsi minecraft forge splash freeze since 17.1

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 296 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=101294

--- Comment #8 from Marek Olšák <maraeo@gmail.com> ---
Actually, I think it's 3 locks we have to unify:
- bo_fence_lock
- pb_cache::mutex
- pb_slabs::mutex

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1077 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 101294] radeonsi minecraft forge splash freeze since 17.1

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 610 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=101294

--- Comment #9 from Marek Olšák <maraeo@gmail.com> ---
Hm, I think the proper fix is not to loop on submission_in_progress in
amdgpu_cs_flush while bo_fence_lock is held. The looping is there because we
need to prepare the request.dependencies list. We can remove that looping
rather trivially by passing an amdgpu_fence list (with potential submissions in
progress) to the CS thread as dependencies, and the CS thread can initialize
request.dependencies accordingly.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1391 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 101294] radeonsi minecraft forge splash freeze since 17.1

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 350 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=101294

--- Comment #10 from Marek Olšák <maraeo@gmail.com> ---
Created attachment 132069
  --> https://bugs.freedesktop.org/attachment.cgi?id=132069&action=edit
tentative fix

Please test the attached patch. Thanks.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1336 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 101294] radeonsi minecraft forge splash freeze since 17.1

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 416 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=101294

--- Comment #11 from Fabian Maurer <dark.shadow4@web.de> ---
Thanks for explaining, I already feared that the issue was deeper.

I think I found a configuration for Minecraft that triggers the issue in ~100%
of all tries.
I tested the patch, and it reliable fixes the freezes.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1201 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 101294] radeonsi minecraft forge splash freeze since 17.1

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 334 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=101294

--- Comment #12 from Tobias Auerochs <tobi291019@gmail.com> ---
Can also confirm that this fixed the issue for me it seems.

It also patched nicely on 17.1.0, I should update my PKGBUILD I know...

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1122 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 101294] radeonsi minecraft forge splash freeze since 17.1

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 590 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=101294

Marek Olšák <maraeo@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #13 from Marek Olšák <maraeo@gmail.com> ---
Fixed by
https://cgit.freedesktop.org/mesa/mesa/commit/?id=58af1f6bb074168669aaec2755c7f369a8b58d62

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2192 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 101294] radeonsi minecraft forge splash freeze since 17.1

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 1126 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=101294

--- Comment #14 from MirceaKitsune <sonichedgehog_hyperblast00@yahoo.com> ---
Greetings. I'm also getting a GPU crash / system lockup, when running Minecraft
as well as other game engines. It doesn't happen during the splash screen, but
probabilistically while the game is running. The problem was introduced at the
same date as the making of this report, also around the time my distribution
upgraded to Mesa 17.1.

I assume I'm experiencing the same bug described here, since I honestly don't
see Mesa 17.1 introducing two completely unrelated crashes that would cause a
renderer as simple as Minecraft to crash the OS. However I updated to Mesa
17.1.4, and surprisingly it still occurs.

Therefore it's possible that this was not fixed. Since it's not my bug and I
don't wish to inconvenience folks, I won't set the status to reopened...
however the developers might wish to take a look at this. Here is my own
report:

https://bugs.freedesktop.org/show_bug.cgi?id=101672

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2136 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 101294] radeonsi minecraft forge splash freeze since 17.1

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 549 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=101294

--- Comment #15 from Michel Dänzer <michel@daenzer.net> ---
(In reply to MirceaKitsune from comment #14)
> I assume I'm experiencing the same bug described here [...]

You're most definitely not. Many different causes can result in similar
symptoms. If the symptoms you experience differ from those described in a bug
report by even just a detail, it's better to assume you're experiencing a
different bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1458 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel