From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@freedesktop.org Subject: [Bug 105760] [4.17-rc1] RIP: smu7_populate_single_firmware_entry.isra.6+0x57/0xc0 [amdgpu] RSP: ffffa17901efb930 Date: Thu, 12 Jul 2018 13:21:31 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0563923786==" Return-path: Received: from culpepper.freedesktop.org (culpepper.freedesktop.org [131.252.210.165]) by gabe.freedesktop.org (Postfix) with ESMTP id 408D06EFB8 for ; Thu, 12 Jul 2018 13:21:31 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0563923786== Content-Type: multipart/alternative; boundary="15314016913.F60a.9703" Content-Transfer-Encoding: 7bit --15314016913.F60a.9703 Date: Thu, 12 Jul 2018 13:21:31 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated https://bugs.freedesktop.org/show_bug.cgi?id=3D105760 --- Comment #38 from Alex Deucher --- (In reply to Thomas Martitz from comment #36) > Created attachment 140591 [details] [review] > workaround without memcpy >=20 > I made the following patch as an alternative workaround. The printks I ad= ded > indicate what's going wrong. The smu_data->header pointer does not become > busted. Instead, the toc->num_entries member somehow gets set to -1 (perh= aps > by accident), and since toc->num_entries is used as an index for the > toc->entry array, the smu7_populate_single_firmware_entry() function gets > passed an invalid pointer. >=20 > The workaround uses a temp. variable as the index (which seems to make > resume work), but it's still to be found out why toc->num_entries changes= to > -1. Also, I still get lots of powerplay error messages with this patch. I= 'll > attach dmesg next, below is just the output of the printks I added. That explains it. The problem is that the GPU does not power up properly on resume so when you read back from vram to get the index, it returns all 1s since the device is offline. --=20 You are receiving this mail because: You are the assignee for the bug.= --15314016913.F60a.9703 Date: Thu, 12 Jul 2018 13:21:31 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated

Comme= nt # 38 on bug 10576= 0 from Alex Deucher 
(In reply to Thomas Martitz from comment #36)
> Created =
attachment 140591 [details] [review]=
 [review]
> workaround without memcpy
>=20
> I made the following patch as an alternative workaround. The printks I=
 added
> indicate what's going wrong. The smu_data->header pointer does not =
become
> busted. Instead, the toc->num_entries member somehow gets set to -1=
 (perhaps
> by accident), and since toc->num_entries is used as an index for the
> toc->entry array, the smu7_populate_single_firmware_entry() functio=
n gets
> passed an invalid pointer.
>=20
> The workaround uses a temp. variable as the index (which seems to make
> resume work), but it's still to be found out why toc->num_entries c=
hanges to
> -1. Also, I still get lots of powerplay error messages with this patch=
. I'll
> attach dmesg next, below is just the output of the printks I added.

That explains it.  The problem is that the GPU does not power up properly on
resume so when you read back from vram to get the index, it returns all 1s
since the device is offline.

You are receiving this mail because:
  • You are the assignee for the bug.
= --15314016913.F60a.9703-- --===============0563923786== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============0563923786==--